[HOLD for payment 2023-12-21][$500] Update CONSTS to direct developers to use role instead of accessibilityRole

[dangrous]

• Restore CONST.ACCESSIBLITY_ROLE.TEXT to have the value text
• Create CONST.ROLE with comments on appropriate use
• Add a deprecation JSDoc on CONST.ACCESSIBLITY_ROLE with an instruction to use role instead of accessibilityRole
• Update any role props that point to CONST.ACCESSIBLITY_ROLE to point to CONST.ROLE instead.

This will encourage appropriate code syntax moving forward and keep things clean and on the cutting edge!

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012561c8136f1b8b5a
• Upwork Job ID: 1726618160989405184
• Last Price Increase: 2023-11-20

Issue Owner

Current Issue Owner: @JmillsExpensify

[trevor-coleman]

Hey @dangrous -- this is my baby!

[melvin-bot]

📣 @trevor-coleman! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[trevor-coleman]

As a note: I don't get paid via Upwork as I'm with Infinite Red.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012561c8136f1b8b5a

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[melvin-bot]

📣 @allroundexperts Please request via NewDot manual requests for the Contributor role ($500)

[melvin-bot]

📣 @allroundexperts Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

The BZ member will need to manually hire trevor-coleman for the Contributor role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

[dangrous]

sorry for all the notifications - trying to get a C+ here, (thanks @allroundexperts!), @trevor-coleman will be handling the issue

[trevor-coleman]

I've got a draft PR going, but not sure how to handle the testing part.

Should I write up tests for every component touched her?

It would be quite a few components (~100), and as the changes are a like-for-like substitution of values from a known list of acceptable values I think the risk it pretty low.

Happy to do whatever is needed, just wanted to get some advice on what an appropriate testing section looks like for a find-replace PR like this.

[dangrous]

That's a great question. I think if most of the changes are exactly the same, I think we can call out the testing steps for just a few of them. Since this also shouldn't cause any visual change, it shouldn't be too bad.

@allroundexperts since you've done a lot more testing, what are your thoughts on the best way forward?

[getusha]

@trevor-coleman @dangrous what about adding a new lint rule?

[abekkala]

PAYOUT NOTES
$500
@allroundexperts paid in NEWDOT, not Upwork

@dangrous you can close this when needed as @allroundexperts will request his payment via NewDot

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @peterdbarkerUK you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

### Payment Summary
[Upwork Job](https://www.upwork.com/jobs/~012561c8136f1b8b5a)
- <Role>: @trevor-coleman paid $(<amount>) via Upwork (<Replace with offer link>)

• Reviewer: @allroundexperts owed $500 via NewDot

  BugZero Checklist (@peterdbarkerUK)

  • I have verified the correct assignees and roles are listed above
  • I have verified that there are no duplicate or incorrect contracts on Upwork (https://www.upwork.com/ab/applicants/1726618160989405184/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

[peterdbarkerUK]

@trevor-coleman doesn't need to be paid via UpWork, as he's Infinite Red.

@allroundexperts could you send your request via NewDot? @JmillsExpensify is OoO so it might take a week or so to action: $500 for C+ review.

[peterdbarkerUK]

Weird that this assigned me for the payment issue in addition to @abekkala, maybe due to holiday season OoO?

[peterdbarkerUK]

@JmillsExpensify $500 to @allroundexperts when it's sent, thanks!

[melvin-bot]

@JmillsExpensify, @dangrous, @abekkala, @peterdbarkerUK, @trevor-coleman, @allroundexperts Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[abekkala]

@allroundexperts have you requested your payment in New Dot?

[abekkala]

This one is ready to be closed out once:
@allroundexperts requests $500 payment in New Dot

@JmillsExpensify

[melvin-bot]

@JmillsExpensify, @dangrous, @abekkala, @peterdbarkerUK, @trevor-coleman, @allroundexperts Eep! 4 days overdue now. Issues have feelings too...

[allroundexperts]

@abekkala I've noted it down. Feel free to close. Thanks!

[melvin-bot]

@JmillsExpensify, @dangrous, @abekkala, @peterdbarkerUK, @trevor-coleman, @allroundexperts Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[peterdbarkerUK]

@allroundexperts sorry Sibtain, I'm a bit confused: did you already request and receive this payment?

[melvin-bot]

@JmillsExpensify, @dangrous, @abekkala, @peterdbarkerUK, @trevor-coleman, @allroundexperts 10 days overdue. Is anyone even seeing these? Hello?

[allroundexperts]

@peterdbarkerUK I have requested payment but haven't received it yet. I think we can close this issue because receiving the payment does take some time.

[peterdbarkerUK]

CC @JmillsExpensify this one should be ready to go, $500 to @allroundexperts

Let's close once payment is confirmed, no need to risk things slipping through the cracks :)

[melvin-bot]

This issue has not been updated in over 14 days. @JmillsExpensify, @dangrous, @abekkala, @peterdbarkerUK, @trevor-coleman, @allroundexperts eroding to Weekly issue.

[dangrous]

How are we looking on this one? I think still waiting on payment for @allroundexperts from @JmillsExpensify, is that right?

[abekkala]

How are we looking on this one? I think still waiting on payment for @allroundexperts from @JmillsExpensify, is that right?

yes, that is correct

[JmillsExpensify]

I don't think I've received a payment request, though as a heads up, we don't keep issues open that are waiting payment in Expensify. Feel free to close it.

[JmillsExpensify]

Ah yeah, I just checked. @allroundexperts needs to submit the report to me, as that's the only way it shows up in my LHN. But again, no need to keep this issue open for Expensify payments, so I'd go ahead and close it.

[abekkala]

sounds good @JmillsExpensify thanks!

[JmillsExpensify]

$500 payment to @allroundexperts based on this comment.