Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for Payment] [$125] [Form Provider Refactor] ReportWelcomeMessagePage #31560

Closed
luacmartins opened this issue Nov 20, 2023 · 17 comments
Closed

[HOLD for Payment] [$125] [Form Provider Refactor] ReportWelcomeMessagePage #31560

luacmartins opened this issue Nov 20, 2023 · 17 comments
Assignees
@sakluger @luacmartins @getusha @cdOut
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Nov 20, 2023 •
edited by pecanoro
Loading

Coming from #25397 (comment), we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.

This issue is specific to refactoring src/pages/ReportWelcomeMessagePage.js

cc @kowczarz @cdOut

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c7c99c61efa281a3
  • Upwork Job ID: 1726650931727286272
  • Last Price Increase: 2023-11-23
Issue OwnerCurrent Issue Owner: @sakluger
@luacmartins luacmartins added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Bug Something is broken. Auto assigns a BugZero manager. labels Nov 20, 2023
@luacmartins luacmartins self-assigned this Nov 20, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 20, 2023

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 20, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01c7c99c61efa281a3

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 20, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 20, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @getusha (Internal)

@luacmartins
Copy link
Contributor Author

@cdOut @kowczarz are either of you available to work on this one?

@cdOut
Copy link
Contributor

cdOut commented Nov 23, 2023

Yes! I'm Tymoteusz Kałuzieński from Software Mansion, the expert agency and I would like to work on this task.

@luacmartins luacmartins added External Added to denote the issue can be worked on by a contributor and removed Internal Requires API changes or must be handled by Expensify staff labels Nov 23, 2023
@melvin-bot melvin-bot bot changed the title [Form Provider Refactor] ReportWelcomeMessagePage [$500] [Form Provider Refactor] ReportWelcomeMessagePage Nov 23, 2023
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 23, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 23, 2023

Current assignee @getusha is eligible for the External assigner, not assigning anyone new.

@luacmartins luacmartins changed the title [$500] [Form Provider Refactor] ReportWelcomeMessagePage [$125] [Form Provider Refactor] ReportWelcomeMessagePage Nov 23, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 23, 2023

Upwork job price has been updated to $125

@luacmartins luacmartins removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 23, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 27, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 27, 2023

@sakluger, @luacmartins, @getusha, @cdOut Whoops! This issue is 2 days overdue. Let's get this updated quick!

@luacmartins
Copy link
Contributor Author

waiting on draft PR

@melvin-bot melvin-bot bot removed the Overdue label Nov 27, 2023
@cdOut cdOut mentioned this issue Nov 28, 2023
Merged
47 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Nov 30, 2023
@getusha
Copy link
Contributor

getusha commented Dec 14, 2023

@luacmartins Friendly bump for payment.

@luacmartins
Copy link
Contributor Author

@sakluger can you assist with payment?

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Dec 25, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 25, 2023

This issue has not been updated in over 15 days. @sakluger, @luacmartins, @getusha, @cdOut eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@getusha
Copy link
Contributor

getusha commented Jan 3, 2024

Friendly bump @sakluger

@blazejkustra blazejkustra mentioned this issue Jan 18, 2024
Merged
49 tasks
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Monthly KSv2 labels Jan 18, 2024
@pecanoro pecanoro removed the Reviewing Has a PR in review label Jan 29, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 29, 2024
@pecanoro pecanoro added Awaiting Payment Auto-added when associated PR is deployed to production and removed Overdue labels Jan 29, 2024
@sakluger
Copy link
Contributor

Sorry all, I should have noticed this one, I missed it I think because the automations failed.

@getusha I sent you an offer via Upwork, please let me know once you've accepted. Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Jan 29, 2024
@sakluger sakluger added Daily KSv2 and removed Weekly KSv2 labels Jan 29, 2024
@sakluger sakluger changed the title [$125] [Form Provider Refactor] ReportWelcomeMessagePage [HOLD for Payment] [$125] [Form Provider Refactor] ReportWelcomeMessagePage Jan 29, 2024
@getusha
Copy link
Contributor

getusha commented Jan 29, 2024

@sakluger accepted

@sakluger
Copy link
Contributor

Thanks! All paid.

@blazejkustra blazejkustra mentioned this issue Feb 7, 2024
Merged
50 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sakluger sakluger

@luacmartins luacmartins

@getusha getusha

@cdOut cdOut

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sakluger @pecanoro @luacmartins @getusha @cdOut