[HOLD for payment 2023-11-30] [$500] Request money - Hmm it's not here page opens when click on Learn more via the banner below

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.1-5
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any account
3. Go to FAB -> Request -> Manually
4. Enter any amount -> Next
5. Click on get $250 -> Learn more

Expected Result:

The additional information page opens

Actual Result:

Hmm it's not here page opens

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6284020_1700498537224.Recording__6807.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fc74f5c607d04925
• Upwork Job ID: 1726668962396127232
• Last Price Increase: 2023-11-20
• Automatic offers:
• ishpaul777 | Contributor | 27755628

[melvin-bot]

Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[ishpaul777]

Probem

Hmm it's not here page opens when click on Learn more via the banner below

Root Cause

we are using a wrong route for referral page https://help.expensify.com/articles/new-expensify/getting-started/Referral-Program instead of https://help.expensify.com/articles/new-expensify/billing-and-plan-types/Referral-Program

Changes

update CONST.LEARN_MORE_LINK to https://help.expensify.com/articles/new-expensify/billing-and-plan-types/Referral-Program

Alternative

Match the file location to the route getting-started/Referral-Program maybe not sure ?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fc74f5c607d04925

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[luacmartins]

@ishpaul777 are you able to raise a PR soon?

[ishpaul777]

Yes i am available

[melvin-bot]

📣 @mananjadhav Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[ishpaul777]

thank you! raising a PR in few minutes

[luacmartins]

Removing label since we CPed a fix

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.2-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix link to the referral program details #31574

If no regressions arise, payment will be issued on 2023-11-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mananjadhav does not require payment (Eligible for Manual Requests)
• @ishpaul777 requires payment offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[lschurr]

@mananjadhav could you work on the checklist for this one if needed?

[lschurr]

Payment summary:

• Bug reporter: Applause (no payment)
• Contributor: @ishpaul777 $500 (to be paid in Upwork)
• Contributor+: This was reviewed by @luacmartins internally

[lschurr]

Bump on the checklist @mananjadhav

[mananjadhav]

Contributor+: @mananjadhav $500 (to be paid in Newdot)

@lschurr I wasn't able to review this PR. Do you want me to still work on the checklist for the payout?

[lschurr]

Ah, thanks for clarifying @mananjadhav! Nope, if you didn't work on it, I'll update the payment summary.

[lschurr]

@luacmartins - do we need a regression test for this one?

[mananjadhav]

Do you want me to still work on the checklist for the payout

just clarifying, I meant the payout for the external contributor if it is stuck because of this.

[luacmartins]

@luacmartins - do we need a regression test for this one?

I don't think we do. Applause caught this during regression test.

[lschurr]

Cool, we're good! I'll pay @ishpaul777 tomorrow and we'll be set to close.

[lschurr]

Paid! Closing this one out.