[Needs payment][Track Tax] Add new input fields for tax tracking in Money requests

[MonilBhavsar]

Problem

Internal master Issue:https://github.com/Expensify/Expensify/issues/338212
Coming from this section in design doc https://docs.google.com/document/d/1nkusVPiYN3uYCJAH_2XknBv_oPpNOifVxheuxRvFTxs/edit?pli=1#bookmark=id.l319wrhremwa

This issue is divided in 2 phases to keep PR's small, test use cases efficiently and deliver in milestones

Phase 1

In phase 1, we create a simple input fields that can allow inserting, editing and viewing tax details
As discussed in design doc, we need to create tax selector and tax amount components. Also add handles to update transaction tax details in Onyx and also pass tax details to API

Components and handlers should be created in a new way following this refactor PR #28618

Phase 2

In phase 2, we'll add more logic to tax input fields.

• Handling and displaying system messages when tax rates are updated
• When updating category, we need to apply category expense rule and hence update tax rate field and tax amount field accordingly
• As mentioned in design doc, only specific users can edit the tax details depending on the state of report

Why is this important?

To allow users to track tax on the expenses, and migration users to newdot.

Solution

Implement the section of the design doc

Issue Owner

Current Issue Owner: @kadiealexander

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fe3f2f6f3d94b969
• Upwork Job ID: 1785541230062321664
• Last Price Increase: 2024-05-01

[melvin-bot]

Triggered auto assignment to @kadiealexander (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[MonilBhavsar]

Discussing here https://expensify.slack.com/archives/C03UK30EA1Z/p1700633473392829

[teneeto]

Hi, I'm Eto from Callstack - expert contributor group - and I would like to take care of this issue.

[waterim]

Hey, Im Artem from Callstack, and would like to help with this issue

[MonilBhavsar]

We're discussing next steps in slack.
Artem Makushow and Eto Olei are going through design doc and will start working on it soon

[melvin-bot]

@teneeto, @MonilBhavsar, @waterim, @kadiealexander Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[teneeto]

Hi @MonilBhavsar Couldn't raise a draft earlier.

But I Should today.

[MonilBhavsar]

Thank you @teneeto !

[MonilBhavsar]

Issue is already updated, Melvin!

[melvin-bot]

@teneeto, @MonilBhavsar, @waterim, @kadiealexander Still overdue 6 days?! Let's take care of this!

[kadiealexander]

Not overdue!

[MonilBhavsar]

Draft PR is up!

[MonilBhavsar]

@alitoshmatov the second PR is ready for review!
Thanks @teneeto 🙇

[melvin-bot]

This issue has not been updated in over 15 days. @teneeto, @MonilBhavsar, @waterim, @kadiealexander, @alitoshmatov eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[alitoshmatov]

Is there any plan for our next step on this feature?

[MonilBhavsar]

We're working on other parallel issues. We can issue payment here and close this now

[alitoshmatov]

@kadiealexander Can we complete payment and close this one

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fe3f2f6f3d94b969

[melvin-bot]

Current assignee @alitoshmatov is eligible for the Internal assigner, not assigning anyone new.

[kadiealexander]

@MonilBhavsar I'm finding this hard to follow, could you please quickly summarise who is due payment for what?

[MonilBhavsar]

Payment summary: Pay $1000 to @alitoshmatov for reviewing two PR's created before the price update

1. feat: add edit fields for tax tracking #33927
2. feat: add new input fields for tax tracking #32550

There were some regressions coming out of it, but since it was a new feature and lots of new introductions to App, i think it's fine to pay full payment.

[MonilBhavsar]

Eto Olei is from Callstack and does not need payment

[alitoshmatov]

@kadiealexander Bump

[kadiealexander]

@alitoshmatov I've sent you an upwork contract.

[alitoshmatov]

@kadiealexander Accepted the offer

[kadiealexander]

Payouts due:

• Contributor: $1000 @alitoshmatov

Upwork job is here.