[HOLD for payment 2024-02-07] [$500] Chat - "Hmm..page isn't here" briefly displayed after select business account

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.3.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #30582

Action Performed:

1. Go to staging.new.expensify.com
2. Create 2 accounts, one will be used as employee and second as an admin
3. Request 1:1 money as employee from the admin
4. Choose to pay with Business Bank account

Expected Result:

"Hmm..page isn't here" should not be displayed after select business account

Actual Result:

"Hmm..page isn't here" briefly displayed after select business account

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.5520.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f1c9cf0878a15b40
• Upwork Job ID: 1731883805219770368
• Last Price Increase: 2023-12-05
• Automatic offers:
• dukenv0307 | Contributor | 28012502
• ntdiary | Contributor | 28065456

Issue Owner

Current Issue Owner: @michaelhaxhiu

[melvin-bot]

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[devstar1014]

Hi

[melvin-bot]

📣 @devstar1014! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[devstar1014]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~014b4c2f5c016b08c8

[melvin-bot]

⚠️ Invalid email. Please make sure to create an Expensify account with this email first here.

[devstar1014]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~014b4c2f5c016b08c8

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[devstar1014]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~014b4c2f5c016b08c8

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[luacmartins]

This happens when we navigate before the optimistic data created in CreateWorkspaceFromIOUPayment is available in Onyx. Using Onyx.set instead of merge of optimisticData seems to solve the issue.

Given this is a small issue that doesn't affect functionality and the solution above might be controversial, I'm gonna demote this to NAB so we can land on a proper solution.

[neil-marcellini]

I'm downgrading this to weekly and I'll set a reminder to work on it on Monday.

[devstar1014]

Thanks for your email. I am looking forward to hearing from you. Regards.

…

On Thu, Nov 30, 2023 at 2:52 PM Neil Marcellini ***@***.***> wrote: I'm downgrading this to weekly and I'll set a reminder to work on it on Monday. — Reply to this email directly, view it on GitHub <#31836 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BDJJTJIN5XGB7XGS2MMN3WDYHDPWHAVCNFSM6AAAAAA7ZKJ2WGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZUGQ2DSMZRGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[neil-marcellini]

Oh, I think this could be handled easily externally.

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[dukenv0307]

@mountiny What is the next step here.

[mountiny]

Thanks for the bump! @dukenv0307

I guess if there is no better way, lets continue with your PR. @ntdiary could you please resume the PR review? THanks!

[melvin-bot]

This issue has not been updated in over 15 days. @ntdiary, @michaelhaxhiu, @neil-marcellini, @dukenv0307 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[ntdiary]

This issue has not been updated in over 15 days. @ntdiary, @michaelhaxhiu, @neil-marcellini, @dukenv0307 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

PR #32959 has been merged and deployed to staging

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Use set method when creating policy for payment #32959

If no regressions arise, payment will be issued on 2024-02-07. 🎊

For reference, here are some details about the assignees on this issue:

• @ntdiary requires payment automatic offer (Contributor)
• @dukenv0307 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ntdiary] The PR that introduced the bug has been identified. Link to the PR: Create v1 Collect workspace Bottom Up flow #30582
• [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/30582/files#r1475531063
• [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
• [@ntdiary] Determine if we should create a regression test for this bug. Yes
• [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. Done
• [@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/367466

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[kadiealexander]

Payment issued for @dukenv0307. @ntdiary please don't forget the checklist!

[ntdiary]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ntdiary] The PR that introduced the bug has been identified. Link to the PR: Create v1 Collect workspace Bottom Up flow #30582
• [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/30582/files#r1475531063
• [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
• [@ntdiary] Determine if we should create a regression test for this bug. Yes
• [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. Done
• [@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

I think it's good to create a regression test. Because in the future, we might still optimize the logic here in some better ways, and both this issue and #35366 are related to the same business process. Regression test can help ensure that the bug doesn't occur again. :)

Regression test steps:

1. Prepare two accounts userA and userB.
2. Request 1:1 money as userA from userB.
3. As userB, choose to Pay with Expensify and select Business bank account.
4. Verify that "Hmm..it's not here" page doesn't briefly (or persistently) display.

[melvin-bot]

@ntdiary, @neil-marcellini, @kadiealexander, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[kadiealexander]

Payouts due:

• Contributor: $500 @dukenv0307
• Contributor+: $500 @ntdiary

Upwork job is here.