[HOLD for payment 2023-12-07] Fix deploy blocker workflow

[luacmartins]

Problem

We have 2 issues in the deploy blocker workflow:

1. The links to issues are broken, e.g. here
2. The workflow fails when the issue title has single or double quotes.

Why is this important

Our deploy workflows needs to work

Solution

Fix it!

[codecreator28]

The root cause is because single quotes (') in the issue title are not being escaped properly when they are replaced with the corresponding HTML entities. To fix it need to escape the single quotes before replacing them with HTML entities

App/.github/workflows/deployBlocker.yml
text: '💥 We have found a New Expensify Deploy Blocker, if you have any idea which PR could be causing this, please comment in the issue: <${{ github.event.issue.html_url }}|${{ github.event.issue.title }}>'.replace(/[&<>"'|]/g, function(m) { return {'&': '&amp;', '<': '&lt;', '>': '&gt;', '"': '&quot;', "'": '&#039;', '|': '&verbar;'}[m]; }),

change to -

text: '💥 We have found a New Expensify Deploy Blocker, if you have any idea which PR could be causing this, please comment in the issue: <${{ github.event.issue.html_url }}|${{ github.event.issue.title.replace("'", "&#039;") }}>'.replace(/[&<>"'|]/g, function(m) { return {'&': '&amp;', '<': '&lt;', '>': '&gt;', '"': '&quot;', '|': '&verbar;'}[m]; }),

In this updated code, the single quotes (') in the issue title are replaced with the HTML entity '. This ensures that the single quotes are not interpreted as part of the HTML syntax, preventing the error.

[luacmartins]

@sukach318 thanks for the post, but we already have a PR to fix this.

[michaelssingh]

@luacmartins wait is this no longer needed? I commented here

[luacmartins]

@michaelssingh that issue was closed as a dupe since we had this one that was created earlier and we also already had a PR with a fix.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.5-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Escape html chars in GH issue title #31847

If no regressions arise, payment will be issued on 2023-12-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

[melvin-bot]

@luacmartins Huh... This is 4 days overdue. Who can take care of this?

[luacmartins]

This is done!