[HOLD on #29080][$500] Web - Workspace - First member highlighted after inviting users

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.3-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Navigate to Settings > Workspace > New workspace
2. Go to the Members section > Invite
3. Select 3 users and invite them
4. Notice after inviting the first member is highlighted
5. Click on the back button and revisit the members page
6. Again revisit the members page
7. Notice the highlighting is removed

Expected Result:

Members should not be highlighted, particularly the first member, after inviting others

Actual Result:

The first member in the workspace is highlighted after inviting, and the highlighting is eventually removed after revisiting the members page twice

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6288988_1700776262152.2023-11-24_02-48-06.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0129dea2eb15178846
• Upwork Job ID: 1728452804485468160
• Last Price Increase: 2023-11-25
• Automatic offers:
• getusha | Contributor | 27866653

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0129dea2eb15178846

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[bernhardoj]

The first item on the list is highlighted whenever the list is changed. #29080 is planning to change that by only highlighting the first item if the search value changes, so I think we can hold for it.

[jgddesigns]

Please re-state the problem that we are trying to solve in this issue.
Workspace members are highlighted after inviting other users.

What is the root cause of that problem?
There is a styling option in BaseSelectionList.js that enables a list item to be highlighted.

What changes do you think we should make in order to solve the problem?
In BaseSelectionList.js, within the function renderItem, alter the variable 'isItemFocused' on line 295 to be equal to false. This would eliminate any list item from being highlighted in the specified manner.

What alternative solutions did you explore? (Optional)
N/A

[jgddesigns]

Whoops, a bit late after reading the post above my proposal. If the situation changes, let me know.

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Web - Workspace - First member highlighted after inviting users

What is the root cause of that problem?

• Generally, the first member is highlighted if the sections in
  

  App/src/components/SelectionList/BaseSelectionList.js

  Lines 344 to 355 in d985a0e

  	useEffect(() => {
  	// do not change focus on the first render, as it should focus on the selected item
  	if (firstLayoutRef.current) {
  	return;
  	}
  	// set the focus on the first item when the sections list is changed
  	if (sections.length > 0) {
  	updateAndScrollToFocusedIndex(0);
  	}
  	// eslint-disable-next-line react-hooks/exhaustive-deps
  	}, [sections]);

  is updated (just not highlighted in the first render) - This is the feature that is handled in here.

• After we invite any user to the workspace then go back to WorkspaceInitialPage, then we go to the WorkspaceMemberPage again, the props.policyMembers in this page is updated because of API OpenWorkspaceMembersPage is called, that leads to the sections data that is passed to BaseSeletionList is updated, so that lead to the case updateAndScrollToFocusedIndex(0) is called in the second render, that leads to the first member is highlighted.

• Then, if we go back to WorkspaceInitialPage and then go to WorkspaceMemberPage again, the API OpenWorkspaceMembersPage is still called but the props.policyMembers is not updated because there is no member is added anymore, so the updateAndScrollToFocusedIndex(0) is not called in the second render, that leads to the behavior The first member in the workspace is highlighted after inviting, and the highlighting is eventually removed after revisiting the members page twice"

What changes do you think we should make in order to solve the problem?

• We can call the API OpenWorkspaceMembersPage right after inviting any user to make sure the props.policyMembers is up-to-date. Can do it by updating:
  

  App/src/pages/workspace/WorkspaceMembersPage.js

  Lines 132 to 135 in d985a0e

  	useEffect(() => {
  	getWorkspaceMembers();
  	// eslint-disable-next-line react-hooks/exhaustive-deps
  	}, []);

  
  to:

    const isFocused = useIsFocused();
    useEffect(() => {
        getWorkspaceMembers();
        // eslint-disable-next-line react-hooks/exhaustive-deps
    }, [isFocused]);

What alternative solutions did you explore? (Optional)

• NA

Result

Screencast.from.26-11-2023.03.35.32.webm

[ntdiary]

Hi, @lschurr, I've got a lot on my plate, can you please re-assign another c+? :)

[lschurr]

Asking for help here - https://expensify.slack.com/archives/C01GTK53T8Q/p1701187582770199

[lschurr]

Thanks @getusha! Looks like we have a few proposals up for review.

[situchan]

Should this be hold based on #31865 (comment)?

[lschurr]

@getusha could you take a look at this one?

[getusha]

@lschurr this should be held for #29080 as it could potentially change the current behavior.

[lschurr]

On hold.

[lschurr]

On hold.

[lschurr]

On hold.

[lschurr]

On hold.

[lschurr]

On hold.

[lschurr]

On hold.

[lschurr]

On hold.

[lschurr]

On hold.

[lschurr]

The bug this was held on is fixed - #29080

@getusha are you able to reproduce this bug?

[getusha]

@lschurr the layout is entirely changed, we no longer highlight the first member. we can close this.

[lschurr]

Perfect, thanks!