-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-01-28] Filter out reports based on the active workspace #31877
Comments
Triggered auto assignment to @alexpensify ( |
@hayata-suenaga - does this one need to remain in [Draft]? |
Yes because this issue is related to Wave 8 Ideal Nav, which is still in detailed design doc phase. We'll probably delegate this task to an expert agency. When it's time to pay for C+ review, I gonna assign a Bug Zero team back to this issue 🙇 |
Thanks for the context. I'll check in next week again to see if there is any new update. |
Weekly Update: No update yet. |
the design doc is still in review. I gonna remove |
Weekly Update: Thank you @hayata-suenaga! |
I'm going to work on this task |
@WojtekBoman, @hayata-suenaga Eep! 4 days overdue now. Issues have feelings too... |
Because of the requirement change (instead of storing the active workspace ID, we decided to store the URL of the last visited path), we need some adjustment in term of implementation for this issue. @WojtekBoman, are you working on this right now? |
This issue has not been updated in over 15 days. @WojtekBoman, @hayata-suenaga eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
The new backend API has been deployed to the staging environment. @WojtekBoman can use the new API to test their PR. I also commented about the new API in the PR. |
This is completed and merged to the feature branch, great work! |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.28-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-01-28. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@hayata-suenaga I have a question related to the requirement:
Here, are we displaying only the DMs, or both the DMs and their thread reports? |
Filter out reports based on the active workspace with the following criteria. Display only the filtered reports in LHN.
The list of reports that are displayed on the current LHN (we're changing the design of LHN) are generated in this part of the code. Filter out reports based on the active workspace.
When the active workspace is Expensify/All, all reports across workspaces should be displayed.
Relevant design doc section
Issue Owner
Current Issue Owner: @WojtekBomanThe text was updated successfully, but these errors were encountered: