Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-01-28] Filter out reports based on the active workspace #31877

Closed
hayata-suenaga opened this issue Nov 26, 2023 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2

Comments

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Nov 26, 2023

Filter out reports based on the active workspace with the following criteria. Display only the filtered reports in LHN.

  • Reports that belong to the active workspace
  • DMs and GroupDMs from members on the active workspace (there is a caveat on this requirements. See this part and this part of the design doc for detailed requirements)

The list of reports that are displayed on the current LHN (we're changing the design of LHN) are generated in this part of the code. Filter out reports based on the active workspace.

When the active workspace is Expensify/All, all reports across workspaces should be displayed.

Relevant design doc section

Issue OwnerCurrent Issue Owner: @WojtekBoman
@hayata-suenaga hayata-suenaga added the NewFeature Something to build that is a new item. label Nov 26, 2023
@hayata-suenaga hayata-suenaga self-assigned this Nov 26, 2023
Copy link

melvin-bot bot commented Nov 26, 2023

@alexpensify
Copy link
Contributor

@hayata-suenaga - does this one need to remain in [Draft]?

@hayata-suenaga
Copy link
Contributor Author

Yes because this issue is related to Wave 8 Ideal Nav, which is still in detailed design doc phase. We'll probably delegate this task to an expert agency. When it's time to pay for C+ review, I gonna assign a Bug Zero team back to this issue 🙇

@alexpensify
Copy link
Contributor

Thanks for the context. I'll check in next week again to see if there is any new update.

@alexpensify
Copy link
Contributor

Weekly Update: No update yet.

@hayata-suenaga
Copy link
Contributor Author

the design doc is still in review. I gonna remove [Draft] once the review is done (which will be by the end of this week at the latest).

@alexpensify
Copy link
Contributor

Weekly Update: Thank you @hayata-suenaga!

@hayata-suenaga hayata-suenaga changed the title [Draft] Filter out reports based on the active workspace Filter out reports based on the active workspace Dec 12, 2023
@WojtekBoman
Copy link
Contributor

I'm going to work on this task

@hayata-suenaga hayata-suenaga added Daily KSv2 and removed Weekly KSv2 labels Dec 13, 2023
@hayata-suenaga hayata-suenaga moved this from Todo to In Progress in Wave 8 Ideal Nav Dec 13, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 18, 2023
Copy link

melvin-bot bot commented Dec 19, 2023

@WojtekBoman, @hayata-suenaga Eep! 4 days overdue now. Issues have feelings too...

@hayata-suenaga
Copy link
Contributor Author

Because of the requirement change (instead of storing the active workspace ID, we decided to store the URL of the last visited path), we need some adjustment in term of implementation for this issue.

@WojtekBoman, are you working on this right now?

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Jan 11, 2024
Copy link

melvin-bot bot commented Jan 11, 2024

This issue has not been updated in over 15 days. @WojtekBoman, @hayata-suenaga eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@hayata-suenaga hayata-suenaga added Weekly KSv2 and removed Monthly KSv2 labels Jan 11, 2024
@hayata-suenaga
Copy link
Contributor Author

The new backend API has been deployed to the staging environment. @WojtekBoman can use the new API to test their PR.

I also commented about the new API in the PR.

@mountiny
Copy link
Contributor

This is completed and merged to the feature branch, great work!

@github-project-automation github-project-automation bot moved this from In Progress to Done in Wave 8 Ideal Nav Jan 19, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 21, 2024
@melvin-bot melvin-bot bot changed the title Filter out reports based on the active workspace [HOLD for payment 2024-01-28] Filter out reports based on the active workspace Jan 21, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 21, 2024
Copy link

melvin-bot bot commented Jan 21, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jan 21, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.28-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-28. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jan 21, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@WojtekBoman] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@truph01
Copy link
Contributor

truph01 commented Dec 23, 2024

@hayata-suenaga I have a question related to the requirement:

DMs and GroupDMs from members on the active workspace (there is a caveat on this requirements. See this part and this part of the design doc for detailed requirements)

Here, are we displaying only the DMs, or both the DMs and their thread reports?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

5 participants