Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-01-22] Check for the presence of reports that require attention and reports with errors in a given workspace. #31878

Closed
hayata-suenaga opened this issue Nov 26, 2023 · 15 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2

Comments

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Nov 26, 2023

Implement a utility function that, given a workspace id, figures out if a workspace has any unread chats or chats with reports.

Find a best, existing file or create one to write this utility function.

Relevant design doc section

Issue OwnerCurrent Issue Owner: @WojtekBoman
@hayata-suenaga hayata-suenaga added the NewFeature Something to build that is a new item. label Nov 26, 2023
@hayata-suenaga hayata-suenaga self-assigned this Nov 26, 2023
Copy link

melvin-bot bot commented Nov 26, 2023

@melvin-bot melvin-bot bot added the Weekly KSv2 label Nov 26, 2023
@hayata-suenaga hayata-suenaga changed the title Check the existence of unread reports and reports with errors for a given workspace [Draft] Check the existence of unread reports and reports with errors for a given workspace Nov 26, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 4, 2023
@twisterdotcom
Copy link
Contributor

Going to ⭐ you @hayata-suenaga.

@melvin-bot melvin-bot bot removed the Overdue label Dec 4, 2023
@hayata-suenaga
Copy link
Contributor Author

hayata-suenaga commented Dec 4, 2023

wait what's the star ⭐ ?

Screenshot 2023-12-04 at 8 41 37 AM

@twisterdotcom
Copy link
Contributor

Yeah!

@hayata-suenaga hayata-suenaga changed the title [Draft] Check the existence of unread reports and reports with errors for a given workspace Check for the presence of reports that require attention and reports with errors in a given workspace. Dec 12, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 12, 2023
@hayata-suenaga
Copy link
Contributor Author

@melvin-bot melvin-bot bot removed the Overdue label Dec 12, 2023
@WojtekBoman
Copy link
Contributor

@hayata-suenaga You can assign me to this :)

@hayata-suenaga hayata-suenaga added Daily KSv2 and removed Weekly KSv2 labels Dec 13, 2023
@hayata-suenaga hayata-suenaga moved this from Todo to In Progress in Wave 8 Ideal Nav Dec 13, 2023
@hayata-suenaga
Copy link
Contributor Author

Copy from a Slack message

@wojciech.boman
please assume that there is a backend API that returns the list of members of a given workspace while you work on the GH issue. (you need to iterate over reports belonging for a given workspace to figure out if we need to display RBR/GBR. To do this, we first need to get the list of all reports that belong to the given workspace. For reports that has the policyId attribute, this is easy because we can just look at it to figure out if the report belongs to the given workspace (i.e. policy). However, for DM and Group DM reports, we consider a report as belonging to a workspace if at least one of the participants of the report is a member of the given workspace. To figure out this, you need the member list of the workspace. This is the piece of information we lack currently on the front end. That's why we have to create a new backend API to fetch it.

Copy link

melvin-bot bot commented Dec 18, 2023

@twisterdotcom, @WojtekBoman, @hayata-suenaga Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Dec 18, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Overdue Daily KSv2 labels Dec 18, 2023
@melvin-bot melvin-bot bot added the Weekly KSv2 label Dec 18, 2023
@aldo-expensify aldo-expensify self-assigned this Jan 8, 2024
@aldo-expensify
Copy link
Contributor

Prepared draft PR with changes https://github.com/Expensify/Web-Expensify/pull/40429

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Jan 10, 2024
Copy link

melvin-bot bot commented Jan 10, 2024

This issue has not been updated in over 15 days. @twisterdotcom, @WojtekBoman, @aldo-expensify, @hayata-suenaga eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Jan 10, 2024
@hayata-suenaga hayata-suenaga removed their assignment Jan 11, 2024
@hayata-suenaga
Copy link
Contributor Author

The PR was merged and deployed to staging. I'll close this issue once the code is deployed to production.

also, I unassigned myself as Aldo worked on the PR

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Monthly KSv2 labels Jan 15, 2024
@melvin-bot melvin-bot bot changed the title Check for the presence of reports that require attention and reports with errors in a given workspace. [HOLD for payment 2024-01-22] Check for the presence of reports that require attention and reports with errors in a given workspace. Jan 15, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 15, 2024
Copy link

melvin-bot bot commented Jan 15, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jan 15, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.24-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-22. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jan 15, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@WojtekBoman] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@mountiny
Copy link
Contributor

This is completed and merged to the feature branch, great work!

@github-project-automation github-project-automation bot moved this from In Progress to Done in Wave 8 Ideal Nav Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

5 participants