Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-01-11] [$250] [TS migration] Migrate 'ReportActionItemSingle.js' component to TypeScript #31968

Closed
melvin-bot bot opened this issue Nov 27, 2023 · 32 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Nov 27, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/pages/home/report/ReportActionItemSingle.js 29
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012251f67c9d81c8f9
  • Upwork Job ID: 1736777420442447872
  • Last Price Increase: 2023-12-18
  • Automatic offers:
    • abdulrahuman5196 | Reviewer | 28070252
    • rayane-djouah | Contributor | 28070253
Issue OwnerCurrent Issue Owner: @MitchExpensify
@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Dec 18, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'ReportActionItemSingle.js' component to TypeScript [$500] [TS migration] Migrate 'ReportActionItemSingle.js' component to TypeScript Dec 18, 2023
Copy link
Author

melvin-bot bot commented Dec 18, 2023

Job added to Upwork: https://www.upwork.com/jobs/~012251f67c9d81c8f9

@melvin-bot melvin-bot bot added Overdue Help Wanted Apply this label when an issue is open to proposals by contributors labels Dec 18, 2023
Copy link
Author

melvin-bot bot commented Dec 18, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Overdue Weekly KSv2 labels Dec 18, 2023
@mountiny mountiny changed the title [$500] [TS migration] Migrate 'ReportActionItemSingle.js' component to TypeScript [$250] [TS migration] Migrate 'ReportActionItemSingle.js' component to TypeScript Dec 18, 2023
Copy link
Author

melvin-bot bot commented Dec 18, 2023

Upwork job price has been updated to $250

@KrAbhas
Copy link
Contributor

KrAbhas commented Dec 18, 2023

I would like to work on this

@ZhenjaHorbach
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

[TS migration] Migrate 'ReportActionItemSingle.js' component to TypeScript

What is the root cause of that problem?

Not problem (Technical ticket )

What changes do you think we should make in order to solve the problem?

We need to update this file using best practices using TS guide

https://github.com/Expensify/App/blob/main/contributingGuides/TS_STYLE.md

What alternative solutions did you explore? (Optional)

NA

@rayane-d
Copy link
Contributor

I would like to work on this issue

1 similar comment
@yh-0218
Copy link
Contributor

yh-0218 commented Dec 18, 2023

I would like to work on this issue

@krimo11
Copy link

krimo11 commented Dec 18, 2023

I would love to work on this

Copy link
Author

melvin-bot bot commented Dec 18, 2023

📣 @krimo11! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@djabdou
Copy link

djabdou commented Dec 18, 2023

I would like to work on this

@DylanDylann
Copy link
Contributor

I would like to work on this issue

1 similar comment
@annscode
Copy link

I would like to work on this issue

@expertscoders
Copy link

I'm available to work on this

@abdulrahuman5196
Copy link
Contributor

@rayane-djouah is the first to comment here #31968 (comment) without any recent TS migration issues assigned.

🎀 👀 🎀
C+ Reviewed

Copy link
Author

melvin-bot bot commented Dec 20, 2023

Triggered auto assignment to @mountiny, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@mountiny mountiny added the NewFeature Something to build that is a new item. label Dec 29, 2023
Copy link
Author

melvin-bot bot commented Dec 29, 2023

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 2, 2024
@melvin-bot melvin-bot bot changed the title [$250] [TS migration] Migrate 'ReportActionItemSingle.js' component to TypeScript [HOLD for payment 2024-01-11] [$250] [TS migration] Migrate 'ReportActionItemSingle.js' component to TypeScript Jan 4, 2024
Copy link
Author

melvin-bot bot commented Jan 4, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 4, 2024
Copy link
Author

melvin-bot bot commented Jan 4, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.21-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-11. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

Copy link
Author

melvin-bot bot commented Jan 4, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@parasharrajat] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@MitchExpensify
Copy link
Contributor

Reminder set to pay

@parasharrajat
Copy link
Member

  1. No regression tests are required for this refactor.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 11, 2024
Copy link
Author

melvin-bot bot commented Jan 11, 2024

Issue is ready for payment but no BZ is assigned. @NicMendonca you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

@NicMendonca
Copy link
Contributor

@MitchExpensify is on BZ, so unassigning myself here!

@NicMendonca NicMendonca removed their assignment Jan 11, 2024
@MitchExpensify
Copy link
Contributor

Payment summary:

C+ - $250 @parasharrajat (NewDot)
C - $250 @rayane-djouah (Upwork)

@MitchExpensify
Copy link
Contributor

Paid and contract ended for @rayane-djouah !

@github-project-automation github-project-automation bot moved this from In Progress to Done in Typescript migration Jan 13, 2024
@parasharrajat
Copy link
Member

Payment requested as per #31968 (comment)

@JmillsExpensify
Copy link

$250 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests