Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-02-07] [$250] [TS migration] Migrate 'ReportActionItemTaskView.js' component to TypeScript #31970

Closed
melvin-bot bot opened this issue Nov 27, 2023 · 39 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Nov 27, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/ReportActionItem/TaskView.js 30
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0110409592d755247f
  • Upwork Job ID: 1744724311075110912
  • Last Price Increase: 2024-01-09
  • Automatic offers:
    • 0xmiroslav | Reviewer | 28092399
    • shahinyan11 | Contributor | 28092400
    • ishpaul777 | Contributor | 28120165
Copy link
Author

melvin-bot bot commented Dec 21, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@mountiny mountiny added External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. labels Jan 9, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'ReportActionItemTaskView.js' component to TypeScript [$500] [TS migration] Migrate 'ReportActionItemTaskView.js' component to TypeScript Jan 9, 2024
Copy link
Author

melvin-bot bot commented Jan 9, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0110409592d755247f

Copy link
Author

melvin-bot bot commented Jan 9, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors and removed Monthly KSv2 labels Jan 9, 2024
Copy link
Author

melvin-bot bot commented Jan 9, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 9, 2024
@ishpaul777
Copy link
Contributor

ishpaul777 commented Jan 9, 2024

I'd like to work on it.

@ghost
Copy link

ghost commented Jan 9, 2024

I am interested to work on it

@yh-0218
Copy link
Contributor

yh-0218 commented Jan 9, 2024

I'd like to work on it.

@vadymbokatov
Copy link
Contributor

Hi. I've been offline for a while and I would like to work on this. I think it would help me make a good comeback easier.

@mountiny mountiny changed the title [$500] [TS migration] Migrate 'ReportActionItemTaskView.js' component to TypeScript [$250] [TS migration] Migrate 'ReportActionItemTaskView.js' component to TypeScript Jan 9, 2024
Copy link
Author

melvin-bot bot commented Jan 9, 2024

Upwork job price has been updated to $250

@tienifr
Copy link
Contributor

tienifr commented Jan 9, 2024

Would like to work on this

@HezekielT
Copy link
Contributor

I'd like to work on this.

@rayane-djouah
Copy link
Contributor

I would like to work on this

@5war00p
Copy link
Contributor

5war00p commented Jan 9, 2024

I would love to contribute to this

@ishpaul777
Copy link
Contributor

ishpaul777 commented Jan 24, 2024

I would like take this as c+. 😀

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 24, 2024
Copy link
Author

melvin-bot bot commented Jan 24, 2024

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

Copy link
Author

melvin-bot bot commented Jan 30, 2024

Triggered auto assignment to @robertjchen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@ishpaul777
Copy link
Contributor

@robertjchen PR is ready for your review #34276

@robertjchen
Copy link
Contributor

Reviewed, thanks! 🙇

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jan 31, 2024
@melvin-bot melvin-bot bot changed the title [$250] [TS migration] Migrate 'ReportActionItemTaskView.js' component to TypeScript [HOLD for payment 2024-02-07] [$250] [TS migration] Migrate 'ReportActionItemTaskView.js' component to TypeScript Jan 31, 2024
Copy link
Author

melvin-bot bot commented Jan 31, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 31, 2024
Copy link
Author

melvin-bot bot commented Jan 31, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-07. 🎊

For reference, here are some details about the assignees on this issue:

Copy link
Author

melvin-bot bot commented Jan 31, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@ishpaul777] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@peterdbarkerUK] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@kadiealexander kadiealexander added NewFeature Something to build that is a new item. and removed NewFeature Something to build that is a new item. labels Feb 1, 2024
Copy link
Author

melvin-bot bot commented Feb 1, 2024

@trjExpensify
Copy link
Contributor

Waiting out the regression period!

@ishpaul777
Copy link
Contributor

Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

no regression test requires for TS Migration

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 7, 2024
@shahinyan11
Copy link

@trjExpensify I didn't receive payment

@trjExpensify
Copy link
Contributor

Yeah, that would be because I haven't paid it out yet! 😅

Payment summary:

@trjExpensify
Copy link
Contributor

Everyone is paid, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests