Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [HOLD for payment 2024-02-07] [TS migration] Migrate 'ReportActionItemReportPreview.js' component to TypeScript #31973

Closed
melvin-bot bot opened this issue Nov 27, 2023 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Nov 27, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/ReportActionItem/ReportPreview.js 34
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01df7d0f355dcd20c0
  • Upwork Job ID: 1755376801234128896
  • Last Price Increase: 2024-02-07
Copy link
Author

melvin-bot bot commented Dec 21, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@VickyStash
Copy link
Contributor

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

Copy link
Author

melvin-bot bot commented Jan 29, 2024

Triggered auto assignment to @jasperhuangg, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added the NewFeature Something to build that is a new item. label Jan 29, 2024
Copy link
Author

melvin-bot bot commented Jan 29, 2024

@jasperhuangg
Copy link
Contributor

We just merged the linked PR for this issue 👏

@jliexpensify
Copy link
Contributor

jliexpensify commented Jan 30, 2024

Ok cool, so from the PR - is this correct @jasperhuangg ?

Payment Summary:

https://www.upwork.com/jobs/~01df7d0f355dcd20c0

@jasperhuangg
Copy link
Contributor

@jliexpensify that looks good to me!

@jliexpensify
Copy link
Contributor

Cool, looks like we've deployed to Staging, but we generally pay when it's been 7 days since it was deployed to Production. I'll keep an eye out on that and adjust the payment date accordingly.

@situchan anything to complete for the checklist?

@situchan
Copy link
Contributor

This doesn't require BZ checklist

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 31, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'ReportActionItemReportPreview.js' component to TypeScript [HOLD for payment 2024-02-07] [TS migration] Migrate 'ReportActionItemReportPreview.js' component to TypeScript Jan 31, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 31, 2024
Copy link
Author

melvin-bot bot commented Jan 31, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Jan 31, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-07. 🎊

For reference, here are some details about the assignees on this issue:

Copy link
Author

melvin-bot bot commented Jan 31, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@VickyStash] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 7, 2024
Copy link
Author

melvin-bot bot commented Feb 7, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@jliexpensify jliexpensify added the External Added to denote the issue can be worked on by a contributor label Feb 7, 2024
Copy link
Author

melvin-bot bot commented Feb 7, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01df7d0f355dcd20c0

@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-02-07] [TS migration] Migrate 'ReportActionItemReportPreview.js' component to TypeScript [$500] [HOLD for payment 2024-02-07] [TS migration] Migrate 'ReportActionItemReportPreview.js' component to TypeScript Feb 7, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 7, 2024
Copy link
Author

melvin-bot bot commented Feb 7, 2024

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

@jliexpensify jliexpensify removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 7, 2024
@jliexpensify
Copy link
Contributor

@jliexpensify jliexpensify changed the title [$500] [HOLD for payment 2024-02-07] [TS migration] Migrate 'ReportActionItemReportPreview.js' component to TypeScript [$250] [HOLD for payment 2024-02-07] [TS migration] Migrate 'ReportActionItemReportPreview.js' component to TypeScript Feb 7, 2024
Copy link
Author

melvin-bot bot commented Feb 7, 2024

Upwork job price has been updated to $250

@jliexpensify
Copy link
Contributor

Paid and job closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests

4 participants