-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] [TS migration] Migrate 'IOUCurrencySelection' page to TypeScript #31992
Comments
This issue has not been updated in over 15 days. eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
I can work on this |
I would love to take this one. (slack ref) |
Job added to Upwork: https://www.upwork.com/jobs/~01da9898957c41a5b4 |
Triggered auto assignment to @twisterdotcom ( |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary ( |
Upwork job price has been updated to $250 |
📣 @ntdiary 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
Okay, making this Monthly. |
Still Held. |
The holding PR is merged. I have created the PR. |
Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
This issue has not been updated in over 15 days. @ntdiary, @twisterdotcom, @grgia, @bernhardoj eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
Is this no longer on hold now @grgia and @bernhardoj? |
@twisterdotcom oh, yes it's no longer on hold. The PR for this issue is already merged too. |
Wow, deployed three weeks ago! Okay, so we're due some payments here right? This seems to be right: Payment Summary:
|
Hi, @twisterdotcom, could you please hold off my payments? I'll switch to NewDot for receiving payments this/next week. :) |
No worries, I updated your payment summary to say you'll be requesting it in newDot. I updated Bernhard's link to be the contract and paid it. No need for any regression steps here so will close now. @ntdiary keep this bookmarked so you know to come back to it for when you have newDot requests setup. I've closed out the contract for this one in Upwork for you. |
$250 approved for @ntdiary |
TypeScript migration
Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.
Files
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: