Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [TS migration] Migrate 'IOUCurrencySelection' page to TypeScript #31992

Closed
melvin-bot bot opened this issue Nov 27, 2023 · 29 comments
Closed

[$250] [TS migration] Migrate 'IOUCurrencySelection' page to TypeScript #31992

melvin-bot bot opened this issue Nov 27, 2023 · 29 comments
Assignees
Labels
External Added to denote the issue can be worked on by a contributor Monthly KSv2 NewFeature Something to build that is a new item. Reviewing Has a PR in review Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Nov 27, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/pages/iou/IOUCurrencySelection.js 21
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01da9898957c41a5b4
  • Upwork Job ID: 1750844989409779712
  • Last Price Increase: 2024-01-26
  • Automatic offers:
    • ntdiary | Reviewer | 28123432
    • bernhardoj | Contributor | 28123433
Copy link
Author

melvin-bot bot commented Dec 21, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@abzokhattab
Copy link
Contributor

I can work on this

@melvin-bot melvin-bot bot added the Overdue label Jan 26, 2024
@bernhardoj
Copy link
Contributor

I would love to take this one. (slack ref)

@mountiny mountiny added External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. and removed Task labels Jan 26, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'IOUCurrencySelection' page to TypeScript [$500] [TS migration] Migrate 'IOUCurrencySelection' page to TypeScript Jan 26, 2024
Copy link
Author

melvin-bot bot commented Jan 26, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01da9898957c41a5b4

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 26, 2024
Copy link
Author

melvin-bot bot commented Jan 26, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Overdue labels Jan 26, 2024
Copy link
Author

melvin-bot bot commented Jan 26, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

@mountiny mountiny changed the title [$500] [TS migration] Migrate 'IOUCurrencySelection' page to TypeScript [$250] [TS migration] Migrate 'IOUCurrencySelection' page to TypeScript Jan 26, 2024
@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 Weekly KSv2 labels Jan 26, 2024
Copy link
Author

melvin-bot bot commented Jan 26, 2024

Upwork job price has been updated to $250

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 26, 2024
Copy link
Author

melvin-bot bot commented Jan 26, 2024

📣 @ntdiary 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@melvin-bot melvin-bot bot added the Overdue label Mar 4, 2024
@twisterdotcom
Copy link
Contributor

Okay, making this Monthly.

@twisterdotcom
Copy link
Contributor

Still Held.

@melvin-bot melvin-bot bot removed the Overdue label Apr 8, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Apr 11, 2024
@bernhardoj
Copy link
Contributor

The holding PR is merged. I have created the PR.

Copy link
Author

melvin-bot bot commented Apr 12, 2024

Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Copy link
Author

melvin-bot bot commented Apr 18, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels May 7, 2024
Copy link
Author

melvin-bot bot commented May 7, 2024

This issue has not been updated in over 15 days. @ntdiary, @twisterdotcom, @grgia, @bernhardoj eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@twisterdotcom
Copy link
Contributor

Is this no longer on hold now @grgia and @bernhardoj?

@bernhardoj
Copy link
Contributor

@twisterdotcom oh, yes it's no longer on hold. The PR for this issue is already merged too.

@twisterdotcom twisterdotcom changed the title [HOLD #34607] [$250] [TS migration] Migrate 'IOUCurrencySelection' page to TypeScript [$250] [TS migration] Migrate 'IOUCurrencySelection' page to TypeScript May 13, 2024
@twisterdotcom
Copy link
Contributor

twisterdotcom commented May 14, 2024

Wow, deployed three weeks ago! Okay, so we're due some payments here right? This seems to be right:

Payment Summary:

@ntdiary
Copy link
Contributor

ntdiary commented May 14, 2024

Hi, @twisterdotcom, could you please hold off my payments? I'll switch to NewDot for receiving payments this/next week. :)

@twisterdotcom
Copy link
Contributor

No worries, I updated your payment summary to say you'll be requesting it in newDot. I updated Bernhard's link to be the contract and paid it.

No need for any regression steps here so will close now. @ntdiary keep this bookmarked so you know to come back to it for when you have newDot requests setup. I've closed out the contract for this one in Upwork for you.

@JmillsExpensify
Copy link

$250 approved for @ntdiary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Added to denote the issue can be worked on by a contributor Monthly KSv2 NewFeature Something to build that is a new item. Reviewing Has a PR in review Typescript Migration
Projects
No open projects
Development

No branches or pull requests

7 participants