Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-05-02] [$250] [TS migration] Migrate 'IOUEditRequestReceipt' page to TypeScript #32000

Closed
melvin-bot bot opened this issue Nov 27, 2023 · 45 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Nov 27, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/pages/EditRequestReceiptPage.js 10
src/pages/iou/ReceiptDropUI.js 8
src/pages/iou/ReceiptSelector/index.native.js 27
src/pages/iou/ReceiptSelector/index.js 30
src/pages/iou/ReceiptSelector/NavigationAwareCamera/index.native.js 4
src/pages/iou/ReceiptSelector/NavigationAwareCamera/index.js 5
src/pages/iou/ReceiptSelector/CameraPermission/index.js 0
src/pages/iou/ReceiptSelector/CameraPermission/index.ios.js 1
src/pages/iou/ReceiptSelector/CameraPermission/index.android.js 1
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01420471b55c08c38c
  • Upwork Job ID: 1750848104777138176
  • Last Price Increase: 2024-01-26
  • Automatic offers:
    • akinwale | Reviewer | 28123473
Copy link
Author

melvin-bot bot commented Dec 21, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Overdue label Jan 26, 2024
@blazejkustra
Copy link
Contributor

@abzokhattab @shahinyan11 Have you read Vit message on slack? 😅

@eucool
Copy link
Contributor

eucool commented Jan 26, 2024

dibs Slack

@mountiny mountiny added NewFeature Something to build that is a new item. External Added to denote the issue can be worked on by a contributor and removed Task labels Jan 26, 2024
Copy link
Author

melvin-bot bot commented Jan 26, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01420471b55c08c38c

Copy link
Author

melvin-bot bot commented Jan 26, 2024

@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'IOUEditRequestReceipt' page to TypeScript [$500] [TS migration] Migrate 'IOUEditRequestReceipt' page to TypeScript Jan 26, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors and removed Overdue Monthly KSv2 labels Jan 26, 2024
Copy link
Author

melvin-bot bot commented Jan 26, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 26, 2024
@eucool
Copy link
Contributor

eucool commented Jan 26, 2024

dibs slack

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 26, 2024
Copy link
Author

melvin-bot bot commented Jan 26, 2024

📣 @akinwale 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

Copy link
Author

melvin-bot bot commented Jan 26, 2024

📣 @codinggeek2023 You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

@eucool
Copy link
Contributor

eucool commented Mar 21, 2024

Please review this day after tomorrow,

we are having merge conflicts in the whole file, will need to remigrate it to typescript :)

Major components were changed so have to remigrate few files :)

@eucool
Copy link
Contributor

eucool commented Mar 24, 2024

@akinwale, thanks for the wait, fixed most of it, left few comments too, can you address them when you find time please :)

@eucool
Copy link
Contributor

eucool commented Mar 31, 2024

PR is ready for review @akinwale !

@Christinadobrzyn
Copy link
Contributor

hi @akinwale can you provide an update? Thank you!

@akinwale
Copy link
Contributor

akinwale commented Apr 4, 2024

@Christinadobrzyn Left some feedback yesterday.

cc @codinggeek2023

Copy link
Author

melvin-bot bot commented Apr 9, 2024

Triggered auto assignment to @MonilBhavsar, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Copy link
Author

melvin-bot bot commented Apr 19, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 19, 2024
@melvin-bot melvin-bot bot changed the title [$250] [TS migration] Migrate 'IOUEditRequestReceipt' page to TypeScript [HOLD for payment 2024-05-02] [$250] [TS migration] Migrate 'IOUEditRequestReceipt' page to TypeScript Apr 25, 2024
Copy link
Author

melvin-bot bot commented Apr 25, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 25, 2024
Copy link
Author

melvin-bot bot commented Apr 25, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-05-02. 🎊

For reference, here are some details about the assignees on this issue:

Copy link
Author

melvin-bot bot commented Apr 25, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@akinwale] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 1, 2024
@Christinadobrzyn
Copy link
Contributor

@akinwale do we need a regression test for this?

@akinwale
Copy link
Contributor

akinwale commented May 2, 2024

@Christinadobrzyn Yes, we do. I'll complete the checklist today.

@akinwale
Copy link
Contributor

akinwale commented May 3, 2024

  • [@akinwale] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

Regression Test Steps

  1. Launch Expensify
  2. Click on the global create menu and select Submit expense
  3. Switch to the Scan tab if not already active
  4. Execute the following steps based on the platform

Web Safari/Chrome and Desktop

  • Upload an image.
  • Verify that the image was successfully uploaded and the app can navigate to the confirmation page afterwards.

Native Android / iOS and mWeb

  • Select a photo from the gallery or take a new picture.
  • Verify that the photo was successfully selected or taken, and the app can navigate to the confirmation page afterwards.

Do we agree 👍 or 👎?

@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented May 3, 2024

Regression test - https://github.com/Expensify/Expensify/issues/392952

Payouts due:

Upwork posting - https://www.upwork.com/ab/applicants/1750848104777138176/job-details

@akinwale
Copy link
Contributor

akinwale commented May 3, 2024

  • @akinwale just a heads up that the price for this job was listed at $500 but we pay $250 for these TS Migration jobs so I adjusted the price in the offer. let me know if you have any questions about that!

I was aware of this. Thanks!

@eucool
Copy link
Contributor

eucool commented May 3, 2024

Accepted the offer @Christinadobrzyn

@Christinadobrzyn
Copy link
Contributor

Awesome! this is paid out based on this payment summary - #32000 (comment)

Closing - let me know if I missed anything!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Typescript Migration
Projects
No open projects
Development

No branches or pull requests

6 participants