Unexpected Whisper Message Displayed in NewDot #admins Room

[mallenexpensify]

Coming from this internal issue

INTERNAL SLACK CONVERSATION FOR BACKGROUND: https://expensify.slack.com/archives/C03U7DCU4/p1700167829911559

Action Performed:

1. Created an account with the email [email protected].
2. Created a new workspace within the account.
3. Accessed the 'Setup Specialist' option in the Left Hand Navigation (LHN) under Support.
4. Entered the NewDot #admins room.

Expected Result:

No unexpected messages should appear in the #admins room, especially relating to changes not made by the user.

Actual Result:

An unexpected whisper message indicating "updated the auto-reporting frequency from 'weekly' to 'manual'" appeared in the #admins room before any interaction from the Guide, despite no changes being made to the scheduled submit settings by the user.

Workaround:

Is there a known workaround for this issue? If yes, specify if the user can still use Expensify effectively without this being fixed. Also, confirm if the user has been informed about the workaround.

Platform:

• Web

• iOS

• Android

• Desktop App

• Mobile Web

• Version Number: N/A

• Logs: Not applicable.

• Notes/Photos/Videos: None available.

• Is this issue reproducible in staging, production, or both? Needs confirmation.

Internal only, do not post to External repos

• Customer affected: [email protected]
• Admin email: N/A
• Concierge issue: N/A
• Policy IDs: Specify if any specific policy IDs are affected.
• Report IDs: Specify if any specific report IDs are affected.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e1dc004aac63e68a
• Upwork Job ID: 1729266543722729472
• Last Price Increase: 2023-11-27

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e1dc004aac63e68a

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @fedirjh (Internal)

[mallenexpensify]

@lschurr unassigned, forgot to add myself before the Bug label.
@fedirjh do you think this can be external?

[fedirjh]

@mallenexpensify It seems that you shared an image from a private repository:

Accessed the 'Setup Specialist' option in the Left Hand Navigation (LHN) under Support.

@mallenexpensify How to access this option?

[mallenexpensify]

oh, interesting, it hadn't crossed my mind that the image might now show (kinda cool it doesn't). Here it is

I'm checking on Setup Specialist in this internal Slack post, should have an update soon

[mallenexpensify]

Fedi, you need to start in OldDot then get bumped over to NewDot

I am referring to the OldDot LHN, when someone clicks setup specialist in the support LHN you of olddot it should redirect them to the admins room of NewDot

[fedirjh]

@mallenexpensify I got it. I was able to reproduce it consistently with new accounts, I think this should be fixed on the backend. The Whisper Message is related to this option, if you update it, a new Whisper is created in newDot, My guess is that when you create a new workspace in a brand new account, this policy reporting frequency is set to weekly

CleanShot.2023-11-28.at.23.59.41.mp4

[melvin-bot]

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mallenexpensify]

Thanks @fedirjh , adding Engineering. I'm going to leave you assigned so that, hopefully, you'll get the C+ job for reviewing the PR.

[MariaHCD]

Looks like the report action is ACTION_POLICYCHANGELOG_UPDATE_AUTOREPORTING_FREQUENCY and here's the changelog that we send: https://github.com/Expensify/Web-Expensify/blob/6831794396c449298316b766345b57ec541001c8/lib/Report/Action/PolicyChangeLog/AutoReportingFrequency.php

Next step for me would be to evaluate to narrow down (in the backend) when auto reporting frequency is changed such that it's triggering the policy changelog.

[melvin-bot]

@MariaHCD, @mallenexpensify, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@MariaHCD @mallenexpensify @fedirjh this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[MariaHCD]

Found the original PR that introduced the support tab in OldDot: https://github.com/Expensify/Web-Expensify/pull/37108

Looks like the auto-reporting frequency message was being sent when a user clicks on their guide and is then redirected to the #admins room. cc: @yuwenmemon @AndrewGable I'm assuming this isn't expected, any ideas on how to fix this?

[mallenexpensify]

Looks like the auto-reporting frequency message was being sent when a user clicks on their guide and is then redirected tot the #admins room. cc: @yuwenmemon @AndrewGable I'm assuming this isn't expected, any ideas on how to fix this?

@AndrewGable @yuwenmemon, 👀 plz

[melvin-bot]

@MariaHCD @mallenexpensify @fedirjh this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[melvin-bot]

@MariaHCD, @mallenexpensify, @fedirjh Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@MariaHCD @mallenexpensify @fedirjh this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[melvin-bot]

@MariaHCD, @mallenexpensify, @fedirjh Eep! 4 days overdue now. Issues have feelings too...

[mallenexpensify]

No unexpected messages should appear in the #admins room, especially relating to changes not made by the user.

@marcochavezf , are you working on a PR right now about extra text showing up in chats? If so, do you think this instance will also be fixed by that PR? Also.. please provide a link if one exists.

[melvin-bot]

@MariaHCD, @mallenexpensify, @fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mallenexpensify]

Posted in #vip-vsb
https://expensify.slack.com/archives/C066HJM2CAZ/p1703356251181219

[melvin-bot]

@MariaHCD @mallenexpensify @fedirjh this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

[melvin-bot]

@MariaHCD, @mallenexpensify, @fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@MariaHCD, @mallenexpensify, @fedirjh Eep! 4 days overdue now. Issues have feelings too...

[MariaHCD]

Back from OOO and resuming looking into this. @mallenexpensify I can't seem to reproduce the issue on staging. I don't get the message from the Guide at all when testing with an expensifail account setup with a workspace on the free plan:

Screen.Recording.2024-01-01.at.6.34.18.PM.mov

Are there any other prerequisites that I need in order to reproduce the issue?

[mallenexpensify]

Not able to reproduce via a gmail address either. In NewDot I see this.

In OldDot I don't see a setup specialist option.