Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] All - Split Bill - Employee can successfully access IOU detail page #32078

Closed
5 of 6 tasks
lanitochka17 opened this issue Nov 28, 2023 · 9 comments
Closed
5 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@lanitochka17
Copy link

lanitochka17 commented Nov 28, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.4-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #31291

Action Performed:

  1. Navigate to staging.new.epxpensify.com
    2.. Create a workspace
  2. Open the #announce room
  3. Do a split bill in the room
  4. Log in on another device (with the same/different account, if you use a different account, make sure invite it to the workspace)
  5. Visit the #announce room

Expected Result:

The split bill preview should show as a skeleton and a not found page should be shown when enter preview details

Actual Result:

Employee can successfully access IOU detail page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6292435_1701124370320.Recording__1415.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013577bb1c6b9e9765
  • Upwork Job ID: 1729293708655165440
  • Last Price Increase: 2023-11-28
@lanitochka17 lanitochka17 added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 28, 2023
@melvin-bot melvin-bot bot changed the title All - Split Bill - Employee can successfully access IOU detail page [$500] All - Split Bill - Employee can successfully access IOU detail page Nov 28, 2023
Copy link

melvin-bot bot commented Nov 28, 2023

Job added to Upwork: https://www.upwork.com/jobs/~013577bb1c6b9e9765

Copy link

melvin-bot bot commented Nov 28, 2023

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 28, 2023
Copy link

melvin-bot bot commented Nov 28, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link

melvin-bot bot commented Nov 28, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

@bernhardoj
Copy link
Contributor

@lanitochka17 I would like to do some clarification on the reproduction steps.

  1. Log in on another device

If you are already logged in, you need to log out first.

Expected Result:

The split bill preview should show as a skeleton and a not found page should be shown when enter preview details

Sorry, but I forgot to update the test step in #31291. We agree to disable the click when the IOU preview is still loading (shown as a skeleton), so the expected result should be:

The split bill preview should show as a skeleton and be disabled.

Can you please recheck this? Thanks!

Copy link

melvin-bot bot commented Nov 28, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@twisterdotcom twisterdotcom added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Nov 29, 2023
Copy link

melvin-bot bot commented Nov 29, 2023

Current assignee @hoangzinh is eligible for the Internal assigner, not assigning anyone new.

@twisterdotcom
Copy link
Contributor

@lanitochka17 I think based on @bernhardoj's comment, we can close this?

Copy link

melvin-bot bot commented Nov 29, 2023

@twisterdotcom Be sure to fill out the Contact List!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

4 participants