[$500] Bank account - User is redirected to BA page when paying with Expensify and BA is set up

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.4.0
Reproducible in staging?: y
Reproducible in production?: cannot check the production
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: Workspace has a Chase bank account set up via Connect online with Plaid method.

1. Go to the workspace chat.
2. Create a workspace expense (Manual).
3. Click Pay with Expensify.
4. Click Business bank account.

Expected Result:

User will be redirected to the next payment step.

Actual Result:

User is redirected to workspace bank account page although the bank account is already set up.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6293161_1701176443844.20231128_135303.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cb3238d2b83fb332
• Upwork Job ID: 1729823536743481344
• Last Price Increase: 2024-02-07
• Automatic offers:
• fedirjh | Reviewer | 0

Issue Owner

Current Issue Owner: @muttmuure

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[johnmlee101]

Hmm all of our code regarding the business bank account refers to setup in our code.

App/src/components/AddPaymentMethodMenu.js

Line 98 in a137813

onSelected: () => onItemSelected(CONST.PAYMENT_METHODS.BUSINESS_BANK_ACCOUNT),

App/src/components/KYCWall/BaseKYCWall.js

Line 102 in 23dda79

} else if (paymentMethod === CONST.PAYMENT_METHODS.BUSINESS_BANK_ACCOUNT) {

App/src/pages/settings/Wallet/WalletPage/WalletPage.js

Line 204 in 1163dc3

@flodnv it looks like you changed this code most recently however, curious on your thoughts. Maybe this shouldn't be a blocker yet

[johnmlee101]

#31784 PR that added this option

[johnmlee101]

Actually this was the commit I was looking at: e564ecc

[johnmlee101]

@mountiny https://github.com/Expensify/App/pull/30582/files#diff-8c06fd96ed7306e88ac43532f2b2cdbc6a46c9914847c6d9f4c14c45af7f36cbR92 I think it originated from the addition here?

[mountiny]

Discussing in slack

[johnmlee101]

Demoting this since its a very edge-case flow we're debugging, and it requires more time to investigate- but we won't need to block on it

[mountiny]

So I have done some more testing locally and it just seems that the reimbursementAccount onyx key is being deleted somewhere as you navigate from the bank account flow to the report to be paid. If you sign out and sign back in, the bank account is loaded correctly, when you go to the workspace bank account settings, api call loads the correct bank account and then you can pay just fine.

I think we can make this external for more eyes

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cb3238d2b83fb332

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[GItGudRatio]

Able to repro on staging but not on latest main!

[melvin-bot]

@johnmlee101, @fedirjh Eep! 4 days overdue now. Issues have feelings too...

[fedirjh]

Still awaiting proposals.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[hayata-suenaga]

@rezkiy37 do you have an idea what might be the issue?

[rezkiy37]

@rezkiy37 do you have an idea what might be the issue?

@hayata-suenaga, I posted a question and asked how to reproduce this flow. The problem exists between those lines:

App/src/components/KYCWall/BaseKYCWall.tsx

Lines 128 to 137 in 98a51b3

	} else if (paymentMethod === CONST.PAYMENT_METHODS.BUSINESS_BANK_ACCOUNT) {
	if (iouReport && ReportUtils.isIOUReport(iouReport)) {
	const policyID = Policy.createWorkspaceFromIOUPayment(iouReport);
	// Navigate to the bank account set up flow for this specific policy
	Navigation.navigate(ROUTES.BANK_ACCOUNT_WITH_STEP_TO_OPEN.getRoute('', policyID));
	return;
	}
	Navigation.navigate(addBankAccountRoute);

[hayata-suenaga]

@rezkiy37 could you ask the question in #open-source channel?

[rezkiy37]

@rezkiy37 could you ask the question in #open-source channel?

Looks like we found an answer here. Trying today.

[rezkiy37]

I've successfully added a bank account to my workspace and account.
Actually, the app has a condition once a user clicks on "Pay with Expensify", the app does not show a drop down menu with debit card or business bank account, when the user has at least 1 connected bank account. So, seems like the bug is not replicable and the "Action Performed" list is not relevant anymore. Please re-test.

Flow.mp4

[hayata-suenaga]

asking the QA team for retest

[hayata-suenaga]

QA team confirmed that the issue still exists

cc: @rezkiy37

[melvin-bot]

@johnmlee101, @fedirjh, @muttmuure, @rezkiy37 Huh... This is 4 days overdue. Who can take care of this?

[hayata-suenaga]

The QA team tested with your comment in mind, and they were able to confirm the issue still exists. @rezkiy37 please resume work on this 🙇

[rezkiy37]

Well, let me try one more time.

[rezkiy37]

@hayata-suenaga, can I ask you to provide more info. I need KYC Wallet logs, they are available on the staging ND in the console (example). Also, I tried with another bank, because there are test credentials. How can I test with a Chase account?

[kavimuru]

@rezkiy37 tester added test cards as a payment card.

[melvin-bot]

@johnmlee101, @fedirjh, @muttmuure, @rezkiy37 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[rezkiy37]

I've tried to reproduce the bug one more time on the latest main. It still works properly from my end. Please let me what I am doing wrong on an attached video below.

cc @kavimuru @hayata-suenaga

Flow.1.mp4

[hayata-suenaga]

@rezkiy37 can you test this on staging? if the staging fails and it works on main, maybe some recent PR fixed it.

[rezkiy37]

@hayata-suenaga, just tested on staging on the same account and workspace. It works properly.

Staging.mp4

[hayata-suenaga]

as this issue is not reproducible, I'm closing this issue

[lanitochka17]

Issue is still reproducible on the latest build 1.4.53-2

bandicam.2024-03-18.21-39-07-700.mp4

[hayata-suenaga]

@rezkiy37 @fedirjh could you check back this issue and what step we need to take next? 🙇

[rezkiy37]

I've tried to reproduce with the same account and configs I had before. I cannot see the problem.

Bank.mp4

[hayata-suenaga]

seems like this is not reproducible anymore. closing this issue

thank you for checking @rezkiy37