[$500] [HOLD for payment 2023-12-08] [HOLD for payment 2023-12-07] Mention - Suggested user @ with closed account remains visible when click on it

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.5-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Navigate to a group chat or #Room that has several members (>6)
3. Enter "@" in the compose box
4. Select user that have closed their account

Expected Result:

When user with close account is selected the suggestion list should close

Actual Result:

Suggested user with closed account remains visible when click on it

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6294956_1701281080089.Recording__1428.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @sakluger

Issue Owner

Current Issue Owner: @sakluger

Issue Owner

Current Issue Owner: @sakluger

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c3279b7c2be27d87
• Upwork Job ID: 1755287424781955072
• Last Price Increase: 2024-02-07

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[ishpaul777]

could be a regression from #31435 for me this happen when i try to mention myself in composer

[situchan]

@joelbettner I tested and confirmed reverting #31435 fixed this issue.
Test branch: #32220

[joelbettner]

Thank you @situchan!

[ishpaul777]

if assigned, I am available to raise a quick PR as this issue is Deploy Blocker

Problem

when display name and email for searched user is same, suggestion menu not close after selecting user.

Root Cause

Here when we filter for filteredPersonalDetails we use this condition

!`${detail.displayName} ${detail.login}`.toLowerCase().includes(searchValue.toLowerCase())

so when user display name is same as login this returns true for searchValue so we have a suggestion email

Changes

we should check seperatly for displayName and login like below here

!`${detail.displayName}`.toLowerCase().includes(searchValue.toLowerCase()) && !`${detail.login}`.toLowerCase().includes(searchValue.toLowerCase()

If user is selecting with a email or phone it would irrelevant to match with displayName with a space " "

[situchan]

@ishpaul777 your solution will cause regression if search for displayName email

@joelbettner I have solution:
We can sync filter logic with display logic.

App/src/pages/home/report/ReportActionCompose/SuggestionMention.js

Lines 161 to 162 in ef65a0a

	text: detail.displayName,
	alternateText: formatPhoneNumber(detail.login),

So display logic is if text = alternateText, don't display alternativeText
Same applies to filter logic:

If display name and formatted login is same, just filter with display name

                if (searchValue && !`${detail.displayName}`.toLowerCase().includes(searchValue.toLowerCase())) {

If different, use current logic

[joelbettner]

@allroundexperts if you wouldn't mind taking a look at the proposals that'd be great. I have some other time sensitive stuff I need to get worked on at the moment. Feel free to ping me when I should jump back in here.

[ishpaul777]

why user will search for displayName email ? IMO, this should not be a valid search

[allroundexperts]

I think @situchan's proposal is better. @joelbettner Should I raise a PR or will @situchan do that?

[joelbettner]

@allroundexperts we can have @situchan raise the PR. Then you and I can review it.

[allroundexperts]

Sounds like a plan!

[sakluger]

Still figuring out the regression.

[sakluger]

No update, I will prioritize this soon.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c3279b7c2be27d87

[melvin-bot]

Current assignees @allroundexperts and @situchan are eligible for the External assigner, not assigning anyone new.

[sakluger]

There's still not agreement over whether #32280 is a regression of this issue - given the uncertainty, I'm going to pay this one out in full.

[sakluger]

Summarizing payment on this issue:

Contributor: @situchan $500 (Upwork offer)
Contributor+: @sobitneupane $500, please request on Newdot

Upwork job is here: https://www.upwork.com/jobs/~01c3279b7c2be27d87

[sakluger]

Paid @situchan. @sobitneupane feel free to request payment. Thanks everyone for your patience on this one!

[sobitneupane]

@allroundexperts Did you work on this issue? I don't remember working on it.😀

[allroundexperts]

@sakluger I reviewed this PR instead of @sobitneupane. Also, please go through #32214 (comment) and let me know if you agree.

[allroundexperts]

@sakluger Bump for the updated payment summary!

[JmillsExpensify]

Re-opening for the updated payment summary.

[sakluger]

Sorry for the payment summary mixup, I've reposted the correct payment summary is below. @allroundexperts regarding the payment amount, there were reasonable arguments on both sides of whether this was a regression or not. Given the uncertainty, I decided that we would pay the full original amount.

Summarizing payment on this issue:

Contributor: @situchan $500 (paid via Upwork)
Contributor+: @allroundexperts $500, payable via Newdot

[JmillsExpensify]

$500 approved for @allroundexperts based on latest summary.