Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOU - App crashes when Employee click "Show more" on created Split expense details page #32299

Closed
6 tasks done
lanitochka17 opened this issue Nov 30, 2023 · 16 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@lanitochka17
Copy link

lanitochka17 commented Nov 30, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.6-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Click on FAB> Request money
  2. Enter an amount and continue
  3. On the participant selection - Click split next to a workspace
  4. Click on "Show more"
  5. Select a category
  6. Create the expense
  7. Click on created expense to open details
  8. Click on "Show more"

Expected Result:

Details page should be open with no errors and crashes

Actual Result:

App crashes when Employee click "Show more" on created Split expense details page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6296472_1701372563484.Recording__1436.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Nov 30, 2023
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Nov 30, 2023

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@situchan
Copy link
Contributor

@lanitochka17 do you have console log? Not able to reproduce

@lanitochka17
Copy link
Author

@situchan Hello
logs.txt

@luacmartins
Copy link
Contributor

Looking at this now

@luacmartins
Copy link
Contributor

It crashes with TypeError: Cannot read properties of undefined (reading 'requiresCategory'), coming from this line

@luacmartins
Copy link
Contributor

I think that came from this PR, but that's already in production

@luacmartins
Copy link
Contributor

Yea, crash also happens in production. Gonna remove the blocker label and work on a fix:

Screenshot 2023-11-30 at 3 43 43 PM

@luacmartins luacmartins added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Nov 30, 2023
@luacmartins
Copy link
Contributor

hmm I can't reproduce in dev

@luacmartins
Copy link
Contributor

Yea, categories are not saving for split transactions with a workspace in dev. Not sure why.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Nov 30, 2023
@luacmartins luacmartins added the Bug Something is broken. Auto assigns a BugZero manager. label Dec 18, 2023
Copy link

melvin-bot bot commented Dec 18, 2023

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 18, 2023
Copy link

melvin-bot bot commented Dec 18, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@jjcoffee
Copy link
Contributor

@bfitzexpensify I reviewed the PR for this issue. It should be due for payment as the PR hit production Dec 6. Thanks! 🙇

@bfitzexpensify
Copy link
Contributor

Cool, offer sent.

@jjcoffee
Copy link
Contributor

@bfitzexpensify Accepted, thanks!

@bfitzexpensify
Copy link
Contributor

All paid out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

5 participants