[$500] Private notes - Note editor opens instead of list for user with existing private notes

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.6-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #31344

Action Performed:

Precondition: There is a chat with some content in the Privates notes and the note is not visited before. If visited, please log out and log in again

1. Go to staging.new.expensify.com
2. Open the chat from the precondition
3. Click on the header
4. Click Private notes

Expected Result:

User is navigated to private note list screen

Actual Result:

User is navigated to private note editor instead of private note list screen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6296532_1701375305114.bandicam_2023-12-01_02-53-05-577__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b1540c07c23a34c8
• Upwork Job ID: 1730368222515441664
• Last Price Increase: 2023-11-30

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[chiragsalian]

@lanitochka17, can you elaborate what you mean by this,

Open the chat from the precondition

what do you mean by precondition?

Also i tested the private notes on a DM and a group chat and it seemed to work fine for me on staging chrome. Can you double check?
Meanwhile I'll ping the authors of #31344 to double check as well.

[chiragsalian]

Asked authors in slack here
Asked QA here.

I don't see any issue so I've asked others to confirm. If the issue does infact persist we can revert #31344 but i'd like to confirm it first before reverting.

[chiragsalian]

As discussed here, not a blocker.

Assigning @DylanDylann and @ArekChr to follow up with a fix as early as possible.
If it helps, i was able to reproduce the issue by logging out, logging in and then clicking on an existing private notes. Then i see the editor instead of the list. For me this happens just once and then its fine until i log out and log in again. Please check and implement a fix.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b1540c07c23a34c8

[melvin-bot]

Current assignee @ArekChr is eligible for the External assigner, not assigning anyone new.

[chiragsalian]

i removed the job posting from upwork because it was created by accident, this issue is about fixing a logic with a very recent PR.

[DylanDylann]

I am working on it

[DylanDylann]

@ArekChr Please help review PR #32327

[jjcoffee]

Found a possible regression whilst testing for #31257. If you go offline before the GetReportPrivateNote request completes, the notes page still loads but is always empty (even when there are notes saved).

[DylanDylann]

@jjcoffee

the notes page still loads but is always empty

• What is the "notes page" that you mentioned? (Currently, we have two page, "notes list" page and "notes edit" page

[jjcoffee]

Apologies, forgot to attach a video. It's the notes list page (I think), but we get navigated to the edit page (incorrectly):

issue-2023-12-14_14.44.06.mp4

[DylanDylann]

@jjcoffee

• Do you have any suggestions in this case? Because if the getReportPrivateNote is not called successfully, we will navigate user to edit note page as expected.
• My suggestion is that, BE will return the private note data when in the OpenReport API.

[melvin-bot]

This issue has not been updated in over 15 days. @chiragsalian, @ArekChr eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[DylanDylann]

@jjcoffee Can you help check this one #32302 (comment) once you have a chance

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[jjcoffee]

@DylanDylann I'm not sure I fully understand your comment or if you are proposing a particular solution, but I think it's up to the C+ on this issue to handle regressions. cc @ArekChr

[DylanDylann]

@jjcoffee Maybe @ArekChr is not available at this time

[ArekChr]

Hey, sorry for the late reply. I wanted to let you know that I'm no longer in the C+ role, as I've moved to the Waves team. Could you please assign a new C+ to take over here? Thanks!

[shubham1206agra]

@mallenexpensify This seems to require a new C+ for some time, and Overdue was not applied here due to the Reviewing label. Can QA retest #32302 (comment) and maybe we can open this for External contributors? I am happy to volunteer for C+ position here.

[melvin-bot]

@chiragsalian, @ArekChr, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[mallenexpensify]

QA, for retesting, here's a vid example
#32302 (comment)

@shubham1206agra , yes, I'll assign you as C+ if the bug persists after more testing. Did you try to reproduce?