Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-01-18] [DISTANCE] LOW: UpdateDistanceRequest 1:1:1 - UpdateMoneyRequestBillable - Split out into its own command #32310

Closed
Tracked by #28358
tgolen opened this issue Nov 30, 2023 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Distance Wave5-free-submitters Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@tgolen
Copy link
Contributor

tgolen commented Nov 30, 2023

There will be three pieces to this:

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01384414fb594d70a3
  • Upwork Job ID: 1730347404278726656
  • Last Price Increase: 2023-11-30
@tgolen tgolen changed the title UpdateDistanceRequest 1:1:1 - UpdateRequestBillable - Split out into its own command [DISTANCE] LOW: UpdateDistanceRequest 1:1:1 - UpdateRequestBillable - Split out into its own command Nov 30, 2023
@tgolen tgolen changed the title [DISTANCE] LOW: UpdateDistanceRequest 1:1:1 - UpdateRequestBillable - Split out into its own command [DISTANCE] LOW: UpdateDistanceRequest 1:1:1 - UpdateMoneyRequestBillable - Split out into its own command Nov 30, 2023
@tgolen tgolen added Engineering Weekly KSv2 Internal Requires API changes or must be handled by Expensify staff Distance Wave5-free-submitters labels Nov 30, 2023
Copy link

melvin-bot bot commented Nov 30, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01384414fb594d70a3

Copy link

melvin-bot bot commented Nov 30, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @c3024 (Internal)

@luacmartins luacmartins self-assigned this Dec 12, 2023
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Dec 12, 2023
@luacmartins
Copy link
Contributor

I started on a draft PR. Will continue tomorrow.

@melvin-bot melvin-bot bot added the Overdue label Dec 15, 2023
@luacmartins
Copy link
Contributor

Auth and Web-E PRs in review

@melvin-bot melvin-bot bot removed the Overdue label Dec 15, 2023
@luacmartins luacmartins added Reviewing Has a PR in review Overdue labels Dec 15, 2023
@melvin-bot melvin-bot bot removed the Overdue label Dec 15, 2023
Copy link

melvin-bot bot commented Dec 25, 2023

@luacmartins, @c3024 Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Dec 27, 2023

@luacmartins, @c3024 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Copy link

melvin-bot bot commented Dec 29, 2023

@luacmartins, @c3024 Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

Copy link

melvin-bot bot commented Jan 1, 2024

@luacmartins, @c3024 12 days overdue now... This issue's end is nigh!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jan 4, 2024
Copy link

melvin-bot bot commented Jan 4, 2024

This issue has not been updated in over 14 days. @luacmartins, @c3024 eroding to Weekly issue.

@luacmartins
Copy link
Contributor

Back from ooo. Will work on it this week.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 8, 2024
@melvin-bot melvin-bot bot changed the title [DISTANCE] LOW: UpdateDistanceRequest 1:1:1 - UpdateMoneyRequestBillable - Split out into its own command [HOLD for payment 2024-01-18] [DISTANCE] LOW: UpdateDistanceRequest 1:1:1 - UpdateMoneyRequestBillable - Split out into its own command Jan 11, 2024
Copy link

melvin-bot bot commented Jan 11, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 11, 2024
Copy link

melvin-bot bot commented Jan 11, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.24-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-18. 🎊

For reference, here are some details about the assignees on this issue:

  • @c3024 requires payment (Needs manual offer from BZ)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 17, 2024
Copy link

melvin-bot bot commented Jan 18, 2024

Issue is ready for payment but no BZ is assigned. @twisterdotcom you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

Copy link

melvin-bot bot commented Jan 18, 2024

Payment Summary

Upwork Job

  • ROLE: @c3024 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@twisterdotcom)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1730347404278726656/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@twisterdotcom
Copy link
Contributor

@luacmartins and @tgolen this is $500 is it? Issue doesn't say.

Also @c3024 - see no name on your GitHub account. Could you share your profile for me please?

@c3024
Copy link
Contributor

c3024 commented Jan 18, 2024

@twisterdotcom

Here is my Upwork profile

https://www.upwork.com/freelancers/~0105555e2f227dbf47

Thanks

@luacmartins
Copy link
Contributor

@luacmartins and @tgolen this is $500 is it? Issue doesn't say.

Yea, I think this is the standard amount

@twisterdotcom
Copy link
Contributor

Payment Summary:

@c3024 paid $500 via Upwork here (C+)

@github-project-automation github-project-automation bot moved this from Release 5: Best in Class to Done in [#whatsnext] Wave 05 - Deprecate Free Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Distance Wave5-free-submitters Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
No open projects
Development

No branches or pull requests

4 participants