[HOLD for payment 2024-02-05] [DISTANCE] LOW: UpdateDistanceRequest 1:1:1 - UpdateMoneyRequestDistance - Split out into its own command

[tgolen]

There will be three pieces to this:

• Auth: Using the logic from EditMoneyRequest, create a new command called UpdateMoneyRequestDistance following the example in https://github.com/Expensify/Auth/pull/8986
• Web-E: Add a new API endpoint called UpdateMoneyRequestDistance following the example in https://github.com/Expensify/Web-Expensify/pull/39445
• App: Implement the new API command following the example in Implement new UpdateMoneyRequestDate API endpoint #30737

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01000e51bf1fe56625
• Upwork Job ID: 1730347061784563712
• Last Price Increase: 2023-11-30

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01000e51bf1fe56625

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

[aldo-expensify]

I'm planning to work on this early this week, after I get #32312 done

[aldo-expensify]

Started working on the Auth part of this: https://github.com/Expensify/Auth/pull/9503

[aldo-expensify]

Just came back from being OOO, I'll start working again on this this week

[aldo-expensify]

At some point we should take care of this comment: https://github.com/Expensify/Auth/blob/cc55ad80c7feddc6a27cc1cbc50e5fb1cd2d40ea/auth/command/UpdateMoneyRequestDistance.cpp#L119

I left a suggestion on how I think we should do it here: #32314 (comment)

[aldo-expensify]

Made #34107 ready for review

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[joekaufmanexpensify]

Looks like this PR caused a few regressions. We are investigating above.

[parasharrajat]

Technically, these issues are not caused by the PR. They are internal backend issues.

[aldo-expensify]

Yes, the Auth PR missed to update the report's total. That is fixed, but not deployed yet. I think we won't deploy today because it is Friday, so hopefully the fix goes out on Monday's deploy

[joekaufmanexpensify]

Got it. TY for confirming!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.32-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Refactor] Add UpdateMoneyRequestDistance command #34107

If no regressions arise, payment will be issued on 2024-02-05. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: NA
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
• [@parasharrajat] Determine if we should create a regression test for this bug. NA
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[joekaufmanexpensify]

Great. TY!

[joekaufmanexpensify]

All set to issue payment. Only payment here is $500 to @parasharrajat for C+ review. Paid via NewDot.

[joekaufmanexpensify]

@parasharrajat please request $500 via NewDot and confirm here once done!

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @parasharrajat owed $500 via NewDot

BugZero Checklist (@joekaufmanexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1730347061784563712/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[parasharrajat]

We can close this after you are done @joekaufmanexpensify I will request it later. Thank you.

[joekaufmanexpensify]

Great. TY! All set.

[parasharrajat]

Payment requested as per #32311 (comment)

[JmillsExpensify]

$500 approved for @parasharrajat