[HOLD for payment 2024-01-02] [$500] Web - Search - Selected dropdown item with tab key is not opened in Search #32388

lanitochka17 · 2023-12-01T22:04:54Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 1.4.7-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Login to ND Expensify
Press CTRL+K or click Magnifying glass icon
Select any dropdown item with Tab key
Press Enter key

Expected Result:

Items in search dropdown should be selected consistently both with up&down and tab keys, and the correct one is opened after pressing Enter key

Actual Result:

Highlighted item (default first one) with Up&Down keys is opened instead of blue bordered item which is selected with Tab key

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6297806_1701459856402.2023-12-01_20-58-59.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015640f29df912d30c
Upwork Job ID: 1730709594365632512
Last Price Increase: 2023-12-01
Automatic offers:

alitoshmatov | Reviewer | 28062509
DylanDylann | Contributor | 28062510

melvin-bot · 2023-12-01T22:04:58Z

Job added to Upwork: https://www.upwork.com/jobs/~015640f29df912d30c

melvin-bot · 2023-12-01T22:05:00Z

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-12-01T22:05:02Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2023-12-01T22:05:04Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

unidev727 · 2023-12-01T22:50:02Z

Proposal

from: @unicorndev-727

Please re-state the problem that we are trying to solve in this issue.

Highlighted item (default first one) with Up&Down keys is opened instead of blue bordered item which is selected with Tab key

What is the root cause of that problem?

The root cause is that the pressOnEnter is set on Confirm button and it's priority is 1 so when we click enter, the button is pressed first with highlighted item.

App/src/components/OptionsSelector/BaseOptionsSelector.js

Lines 656 to 662 in 414c08c

    
           <Button 
        
               success 
        
               style={[this.props.themeStyles.w100]} 
        
               text={defaultConfirmButtonText} 
        
               onPress={this.props.onConfirmSelection} 
        
               pressOnEnter 
        
               enterKeyEventListenerPriority={1}

What changes do you think we should make in order to solve the problem?

we need to adjust button's priority here or can change the default item when we select other item using tab.

What alternative solutions did you explore? (Optional)

N/A

DylanDylann · 2023-12-02T03:27:33Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Search - Selected dropdown item with tab key is not opened in Search

What is the root cause of that problem?

We're selecting the row based on highlighted item, and we don't consider the blue focus one

App/src/components/OptionsSelector/BaseOptionsSelector.js

Lines 302 to 325 in 1682be4

    
           selectFocusedOption() { 
        
               const focusedOption = this.state.allOptions[this.state.focusedIndex]; 
        
               if (!focusedOption || !this.props.isFocused) { 
        
                   return; 
        
               } 
        
               if (this.props.canSelectMultipleOptions) { 
        
                   this.selectRow(focusedOption); 
        
               } else if (!this.state.shouldDisableRowSelection) { 
        
                   this.setState({shouldDisableRowSelection: true}); 
        
                   let result = this.selectRow(focusedOption); 
        
                   if (!(result instanceof Promise)) { 
        
                       result = Promise.resolve(); 
        
                   } 
        
                   setTimeout(() => { 
        
                       result.finally(() => { 
        
                           this.setState({shouldDisableRowSelection: false}); 
        
                       }); 
        
                   }, 500); 
        
               } 
        
           }

What changes do you think we should make in order to solve the problem?

The idea to solve this bug was approved by C+ and internal in other issue. fix: 31635 the blue focus is not prioritized over the application highlight #32252
Generally, we need to change the logic that we use to get focusedOption:

App/src/components/OptionsSelector/BaseOptionsSelector.js

Line 303 in 1682be4

const focusedOption = this.state.allOptions[this.state.focusedIndex];
Now, it only based on the this.state.focusedIndex, so if there is another option is select by tab key, we will not consider it.
To implement the above idea:

Passing additional prop named keyForList to OptionRow. It will become to:

            <OptionRow
                keyForList={item.keyForList}

Then, pass the above keyForList props to PressableWithFeedback
It will become to:

                    <PressableWithFeedback
                        testID={props.keyForList}

Finally, update the logic to get the focusedOption in here:

App/src/components/OptionsSelector/BaseOptionsSelector.js

Line 303 in 1682be4

const focusedOption = this.state.allOptions[this.state.focusedIndex];

It will become to:

const focusedItemKey = lodashGet(e, ['target', 'attributes', 'data-testid', 'value']);
        const focusedOption = focusedItemKey ? _.find(this.state.allOptions, (option) => option.keyForList === focusedItemKey) : this.state.allOptions[this.state.focusedIndex];

What alternative solutions did you explore? (Optional)

NA

alexpensify · 2023-12-04T21:40:25Z

@alitoshmatov please keep us posted if any of the proposals will fix this issue. Thanks!

alitoshmatov · 2023-12-06T19:17:54Z

Reviewing

alitoshmatov · 2023-12-07T18:22:21Z

@unicorndev-727 I don't think confirm button is related here.

alitoshmatov · 2023-12-07T18:35:02Z

@Sourcecodedeveloper I think binding tab key to our selection will effect native accessibility that used by tab key. Moreover
as @DylanDylann mention #32252 PR already solved similar issue, and logical approach would be applying consistent, similar approach here.

alitoshmatov · 2023-12-07T18:38:18Z

@DylanDylann your RCA is correct. Your solution looks good also as you mention we can follow #32252 PR and apply the same solution here. But can you make sure we are covering all instances of this issue so that we don not come across similar one again.

alitoshmatov · 2023-12-07T18:39:00Z

We can go with @DylanDylann 's proposal.

C+ reviewed 🎀 👀 🎀

melvin-bot · 2023-12-07T18:39:08Z

Triggered auto assignment to @deetergp, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

situchan · 2023-12-07T18:54:07Z

We haven't started yet fixing accessibility issues

DylanDylann · 2023-12-07T19:00:21Z

@situchan I think the #31635 is fixed, so, for consistency, I think we should fix this issue as well

melvin-bot · 2023-12-11T11:24:04Z

@deetergp, @alexpensify, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

alitoshmatov · 2023-12-11T16:27:41Z

I agree with @DylanDylann, @deetergp Can you confirm this?

alexpensify · 2023-12-13T23:07:44Z

@deetergp - can we get feedback here? Let me know if we need to have a bigger discussion in Open Source. Thanks!

alexpensify · 2023-12-21T00:00:15Z

Daily Update: PR is in review!

alexpensify · 2023-12-23T18:39:21Z

Heads up, I will be offline from Friday, December 22, to Thursday, January 4, 2024. I will not be actively watching over this GitHub during that period. If anything urgent is needed here, please ask for help in the #expensify-open-source Slack Room-- thanks!

melvin-bot · 2023-12-26T00:06:14Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-12-26T00:06:17Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.16-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix: focusing on item by tab key does not work #33265

If no regressions arise, payment will be issued on 2024-01-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@alitoshmatov requires payment automatic offer (Reviewer)
@DylanDylann requires payment automatic offer (Contributor)

melvin-bot · 2023-12-26T00:06:18Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@alitoshmatov] The PR that introduced the bug has been identified. Link to the PR:
[@alitoshmatov] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@alitoshmatov] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@alitoshmatov] Determine if we should create a regression test for this bug.
[@alitoshmatov] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-12-27T20:04:03Z

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

alexpensify · 2023-12-29T18:16:19Z

Here is the payment summary-- TBD, @alitoshmatov please confirm if this regression is due to this PR or something else. Thank you!

External issue reporter - N/A
Contributor that fixed the issue - @DylanDylann $500
Contributor+ that helped on the issue and/or PR - @alitoshmatov $500

Upwork Job: https://www.upwork.com/jobs/~015640f29df912d30c

Extra Notes regarding payment: Heads up, I'm OOO until January 4, but I will log in on Wednesday, January 3, to check this payment process pending if the regression is resolved by then. I've confirmed that everyone here is a pending hire, so all set here for the payment date.

January 11 Update

Based on the feedback here #32388 (comment), we will keep the payment amounts the same and there is no penalty.

alexpensify · 2024-01-03T18:42:23Z

@alitoshmatov or @deetergp - can you please help confirm if this PR did cause regression? Thanks!

alitoshmatov · 2024-01-04T13:25:03Z

Based on my observation, our PR didn't directly cause this regression, the regression didn't occur after merging our PR. However our solution was based on faulty approach which was already implemented by #32252. We took this solution for granted and followed the same approach. Finally #33491 PR caused the regression which broke our faulty solution. I am okay if penalty is applied to my payment, since I should have been more cautious on my review.

cc: @alexpensify, @deetergp, @Beamanator (since you worked on fixing the regression)

alexpensify · 2024-01-05T00:14:20Z

Thank you @alitoshmatov for this update. @Beamanator and @deetergp can I get some feedback here regarding this payment? Thanks!

melvin-bot · 2024-01-08T17:16:23Z

@deetergp, @alexpensify, @alitoshmatov, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

alexpensify · 2024-01-08T22:22:46Z

Bumping - @deetergp and @Beamanator can I get your feedback here?

Beamanator · 2024-01-10T12:24:05Z

I agree with @alitoshmatov 's summary here: #32388 (comment)

The PR for this issue (Fix: focusing on item by tab key does not work #33265) was merged 3 weeks ago
The PR which technically caused the regression was [NoQA] add perf tests to OptionsSelector #33491, which was merged 2 weeks ago

While the PR for this issue and this one were a bit iffy & weren't perfect, they didn't cause the regressions so I don't believe payment here should have the penalty applied

alexpensify · 2024-01-11T00:08:09Z

Thanks, I'll work on the payment process tomorrow.

alexpensify · 2024-01-11T22:01:20Z

Closing - I updated the summary here: #32388 (comment)

Everyone has been paid via Upwork and I closed that job.

lanitochka17 added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 1, 2023

melvin-bot bot changed the title ~~Web - Search - Selected dropdown item with tab key is not opened in Search~~ [$500] Web - Search - Selected dropdown item with tab key is not opened in Search Dec 1, 2023

melvin-bot bot assigned alexpensify Dec 1, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 1, 2023

melvin-bot bot assigned alitoshmatov Dec 1, 2023

melvin-bot bot added the Overdue label Dec 4, 2023

melvin-bot bot removed the Overdue label Dec 4, 2023

melvin-bot bot assigned deetergp Dec 7, 2023

melvin-bot bot added the Overdue label Dec 11, 2023

melvin-bot bot removed the Overdue label Dec 11, 2023

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 26, 2023

melvin-bot bot changed the title ~~[$500] Web - Search - Selected dropdown item with tab key is not opened in Search~~ [HOLD for payment 2024-01-02] [$500] Web - Search - Selected dropdown item with tab key is not opened in Search Dec 26, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Dec 26, 2023

situchan mentioned this issue Dec 27, 2023

[CP Staging] Fix: Search - Nothing happens when hitting Enter key on the selected user #33667

Merged

59 tasks

melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 Daily KSv2 labels Jan 1, 2024

melvin-bot bot removed the Overdue label Jan 3, 2024

melvin-bot bot added the Overdue label Jan 8, 2024

melvin-bot bot removed the Overdue label Jan 8, 2024

alexpensify closed this as completed Jan 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2024-01-02] [$500] Web - Search - Selected dropdown item with tab key is not opened in Search #32388

[HOLD for payment 2024-01-02] [$500] Web - Search - Selected dropdown item with tab key is not opened in Search #32388

lanitochka17 commented Dec 1, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Dec 1, 2023

melvin-bot bot commented Dec 1, 2023

melvin-bot bot commented Dec 1, 2023

melvin-bot bot commented Dec 1, 2023

unidev727 commented Dec 1, 2023 •

edited

Loading

DylanDylann commented Dec 2, 2023 •

edited

Loading

alexpensify commented Dec 4, 2023

alitoshmatov commented Dec 6, 2023

alitoshmatov commented Dec 7, 2023

alitoshmatov commented Dec 7, 2023

alitoshmatov commented Dec 7, 2023

alitoshmatov commented Dec 7, 2023

melvin-bot bot commented Dec 7, 2023

situchan commented Dec 7, 2023

DylanDylann commented Dec 7, 2023

melvin-bot bot commented Dec 11, 2023

alitoshmatov commented Dec 11, 2023

alexpensify commented Dec 13, 2023

alexpensify commented Dec 21, 2023

alexpensify commented Dec 23, 2023

melvin-bot bot commented Dec 26, 2023

melvin-bot bot commented Dec 26, 2023

melvin-bot bot commented Dec 26, 2023

melvin-bot bot commented Dec 27, 2023

alexpensify commented Dec 29, 2023 •

edited

Loading

alexpensify commented Jan 3, 2024

alitoshmatov commented Jan 4, 2024

alexpensify commented Jan 5, 2024

melvin-bot bot commented Jan 8, 2024

alexpensify commented Jan 8, 2024

Beamanator commented Jan 10, 2024

alexpensify commented Jan 11, 2024

alexpensify commented Jan 11, 2024

[HOLD for payment 2024-01-02] [$500] Web - Search - Selected dropdown item with tab key is not opened in Search #32388

[HOLD for payment 2024-01-02] [$500] Web - Search - Selected dropdown item with tab key is not opened in Search #32388

Comments

lanitochka17 commented Dec 1, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Dec 1, 2023

melvin-bot bot commented Dec 1, 2023

melvin-bot bot commented Dec 1, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Dec 1, 2023

unidev727 commented Dec 1, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

DylanDylann commented Dec 2, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

alexpensify commented Dec 4, 2023

alitoshmatov commented Dec 6, 2023

alitoshmatov commented Dec 7, 2023

alitoshmatov commented Dec 7, 2023

alitoshmatov commented Dec 7, 2023

alitoshmatov commented Dec 7, 2023

melvin-bot bot commented Dec 7, 2023

situchan commented Dec 7, 2023

DylanDylann commented Dec 7, 2023

melvin-bot bot commented Dec 11, 2023

alitoshmatov commented Dec 11, 2023

alexpensify commented Dec 13, 2023

alexpensify commented Dec 21, 2023

alexpensify commented Dec 23, 2023

melvin-bot bot commented Dec 26, 2023

melvin-bot bot commented Dec 26, 2023

melvin-bot bot commented Dec 26, 2023

melvin-bot bot commented Dec 27, 2023

alexpensify commented Dec 29, 2023 • edited Loading

January 11 Update

alexpensify commented Jan 3, 2024

alitoshmatov commented Jan 4, 2024

alexpensify commented Jan 5, 2024

melvin-bot bot commented Jan 8, 2024

alexpensify commented Jan 8, 2024

Beamanator commented Jan 10, 2024

alexpensify commented Jan 11, 2024

alexpensify commented Jan 11, 2024

lanitochka17 commented Dec 1, 2023 •

edited by melvin-bot bot

Loading

unidev727 commented Dec 1, 2023 •

edited

Loading

DylanDylann commented Dec 2, 2023 •

edited

Loading

alexpensify commented Dec 29, 2023 •

edited

Loading