[HOLD for payment 2024-01-04] [$500] Merchant line on preview card is using wrong text size

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.7.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1701391780917959

Action Performed:

Submit a request on a workspace

Expected Result:

In the preview card of both the workspace chat and the expense report, the merchant line should be in our normal font size which is 15px. The bottom of the receipt should also be rounded.

Actual Result:

The font size for the merchant is too small, at 13px. The bottom of the receipt is not rounded

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a6a405785ccbd170
• Upwork Job ID: 1731337099034644480
• Last Price Increase: 2023-12-03
• Automatic offers:
• 0xmiroslav | Reviewer | 28062368
• mkhutornyi | Contributor | 28062369

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a6a405785ccbd170

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[BhuvaneshPatil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Merchant line on preview card is using wrong text size

What is the root cause of that problem?

we are using textLabelSupporting which uses - fontSizeLabel here at

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 329 in 1682be4

<Text style={[styles.textLabelSupporting, styles.mb1, styles.lh20, styles.breakWord]}>

For radius we have not applied border radius for bottom side of image in reportActionItemImages styles.

What changes do you think we should make in order to solve the problem?

We should use fontSizeNormal instead of that, here -

App/src/styles/styles.ts

Lines 1138 to 1142 in 1682be4

	textLabelSupporting: {
	fontFamily: fontFamily.EXP_NEUE,
	fontSize: variables.fontSizeLabel,
	color: theme.textSupporting,
	},

But textLabelSupporting is being used at many places, so we shall avoid changing that, instead we can create a new style for merchant or add the style in styles prop.

For border radius -
We shall remove the borderTopLeftRadius and borderTopRightRadius and apply borderRadius styles with variables.componentBorderRadiusLarge

What alternative solutions did you explore? (Optional)

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Merchant line on preview card is using wrong text size and the bottom of the receipt is not rounded

What is the root cause of that problem?

We use other styles for merchant text in MoneyRequestPreview(Font size) and for ReportActionItemImages (Border radius)

What changes do you think we should make in order to solve the problem?

1. Pass on extra style here (The font size for the merchant is too small, at 13px)

styles.textNormal

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 329 in 1682be4

<Text style={[styles.textLabelSupporting, styles.mb1, styles.lh20, styles.breakWord]}>

Or change styles here

fontSize: variables.fontSizeNormal,

App/src/styles/styles.ts

Line 1140 in 1682be4

fontSize: variables.fontSizeLabel,

2. Update styles here (The bottom of the receipt is not rounded)

borderRadius: variables.componentBorderRadiusLarge,

App/src/styles/styles.ts

Lines 3710 to 3711 in 1682be4

	borderTopLeftRadius: variables.componentBorderRadiusLarge,
	borderTopRightRadius: variables.componentBorderRadiusLarge,

What alternative solutions did you explore? (Optional)

NA

[ZhenjaHorbach]

@BhuvaneshPatil
add comment that your proposal for updating border was later than my proposal)

[BhuvaneshPatil]

I was typing that when your proposal was posted.

[ZhenjaHorbach]

But the fact itself)

[BhuvaneshPatil]

Also, the root cause looks incomplete we should spend time on that as well.
Let the reviewer decide about it.

[ZhenjaHorbach]

As far as I've seen
When I wrote my proposal
You made no mention at all about changing the border radius (even in root cause )
So the complete solution was proposed by me first

And yeah
Let's wait )

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Merchant line on report preview, money request preview is using smaller text size
• bottom border of receipt image is not rounded

What is the root cause of that problem?

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 329 in 1682be4

<Text style={[styles.textLabelSupporting, styles.mb1, styles.lh20, styles.breakWord]}>

App/src/components/ReportActionItem/ReportPreview.js

Line 219 in 1682be4

<Text style={[styles.textLabelSupporting, styles.mb1, styles.lh20]}>{getPreviewMessage()}</Text>

styles.textLabelSupporting has 13px font size

App/src/styles/styles.ts

Lines 3710 to 3711 in 1682be4

	borderTopLeftRadius: variables.componentBorderRadiusLarge,
	borderTopRightRadius: variables.componentBorderRadiusLarge,

borderRadius is only applied to top left and top right

What changes do you think we should make in order to solve the problem?

• Add 15px font size (i.e. styles.textNormal) to both MoneyRequestPreview and ReportPreview above
• use borderRadius instead of borderTopLeftRadius, borderTopRightRadius

[abekkala]

@0xmiroslav can you address the proposals above?

[0xmiros]

@shawnborton should we fix report preview as well for consistency?

[shawnborton]

Yup! These should all look identical in terms of the text styling.

[0xmiros]

@mkhutornyi's proposal looks good to me.
Other proposals didn't consider report preview case (this can be easily missed even in PR stage)
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @pecanoro, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@pecanoro, @abekkala, @0xmiroslav Eep! 4 days overdue now. Issues have feelings too...

[abekkala]

@mkhutornyi do you have PR ready for this one?

[abekkala]

@adelekennedy

STATUS

I'm ooo through Jan 02

This is near the finish line. PR has been created and is in Review. But not yet deployed to production so waiting period has not started yet.

• Issue reported by: @shawnborton (no payment 😉 )
• Fix: @mkhutornyi [$500 if no regression] Offer link
• PR Review: @0xmiroslav [$500 if no regression] Offer link was sent, but I don't think payments are being sent through upwork yet, @0xmiroslav please confirm.

[adelekennedy]

@abekkala enjoy your ooo! I'll be checking in on my issues over the holiday weeks

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.18-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• update merchant line text size, receipt border radius on preview card #33216

If no regressions arise, payment will be issued on 2024-01-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @0xmiroslav requires payment automatic offer (Reviewer)
• @mkhutornyi requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
• [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@0xmiroslav] Determine if we should create a regression test for this bug.
• [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala / @adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abekkala]

@0xmiroslav can you complete the checklist please?

[pecanoro]

@0xmiroslav Friendly bump! Basically so we can complete the payments

[0xmiros]

No PR caused regression.
This is just minor design improvement.

Regression Test Proposal

1. Submit 2 requests (one for manual, one for scan) on any workspace
2. Observe preview card in workspace chat
3. Verify that receipt image is rounded in all 4 corners
4. Verify that "2 requests" text has 15px font size
5. Go to expense report
6. Verify that receipt image is rounded in all 4 corners
7. Verify that merchant line text has 15px font size

I am not sure regression test is needed here as this will change again in #33979

[abekkala]

@mkhutornyi payment sent and contract ended - thank you! 🎉

[abekkala]

@0xmiroslav you provided a regression test proposal but then also state that a regression test is not needed?

Also, are we still in the process of holding your payments? Do you not have your Upwork profile sorted yet?

[0xmiros]

I provided regression test in case anyone disagrees skipping it.
No issue with my upwork but still holding my payment.
Let's close this for now if everything else is set.

[abekkala]

Thanks @0xmiroslav