Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-01-26] [HOLD for payment 2024-01-25] [HOLD for payment 2024-01-02] Create new command for Payment cancelling in "Paid in Expensify" reports #32427

Closed
Gonals opened this issue Dec 4, 2023 · 19 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2

Comments

@Gonals
Copy link
Contributor

Gonals commented Dec 4, 2023

Problem
Currently, we have no way to revert an existing payment in NewDot. This is part of our core functionality and something we should be able to do.

Solution
Let's add that functionality as discussed here. Once we have it for "Paid Elsewhere" we need to expand it for "Paid in Expensify" reports.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f33337b0d8b040ed
  • Upwork Job ID: 1731662547311939584
  • Last Price Increase: 2023-12-04
@Gonals Gonals added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 4, 2023
Copy link

melvin-bot bot commented Dec 4, 2023

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Dec 4, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@Gonals Gonals added NewFeature Something to build that is a new item. and removed Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 4, 2023
Copy link

melvin-bot bot commented Dec 4, 2023

Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

@Gonals Gonals added the Internal Requires API changes or must be handled by Expensify staff label Dec 4, 2023
@melvin-bot melvin-bot bot added the Weekly KSv2 label Dec 4, 2023
Copy link

melvin-bot bot commented Dec 4, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01f33337b0d8b040ed

Copy link

melvin-bot bot commented Dec 4, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Ollyws (Internal)

@puneetlath
Copy link
Contributor

@Gonals is there any front-end aspect to this or is this purely back-end?

@Gonals
Copy link
Contributor Author

Gonals commented Dec 11, 2023

@Gonals is there any front-end aspect to this or is this purely back-end?

There's a a bit of a front-end part for this, but the bulk of the front-end changes will be done in the "Paid elsewhere" PRs

@melvin-bot melvin-bot bot added the Overdue label Dec 20, 2023
@Gonals Gonals added the Reviewing Has a PR in review label Dec 20, 2023
@melvin-bot melvin-bot bot removed the Overdue label Dec 20, 2023
Copy link

melvin-bot bot commented Dec 22, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Dec 22, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Dec 25, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 26, 2023
Copy link

melvin-bot bot commented Dec 26, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 26, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.16-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

  • @Ollyws requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Dec 26, 2023

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@Ollyws] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@puneetlath
Copy link
Contributor

It looks like @Ollyws wasn't involved in the PR, so no payment is needed for anyone here. Let me know if I'm mistaken in that. Otherwise, @Gonals I think you can just go ahead and close the issue.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 Daily KSv2 labels Jan 1, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jan 2, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jan 15, 2024
Copy link

melvin-bot bot commented Jan 17, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jan 18, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-01-02] Create new command for Payment cancelling in "Paid in Expensify" reports [HOLD for payment 2024-01-25] [HOLD for payment 2024-01-02] Create new command for Payment cancelling in "Paid in Expensify" reports Jan 18, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 18, 2024
Copy link

melvin-bot bot commented Jan 18, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jan 18, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.26-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-25. 🎊

For reference, here are some details about the assignees on this issue:

  • @Ollyws requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Jan 18, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@Ollyws] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jan 19, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-01-25] [HOLD for payment 2024-01-02] Create new command for Payment cancelling in "Paid in Expensify" reports [HOLD for payment 2024-01-26] [HOLD for payment 2024-01-25] [HOLD for payment 2024-01-02] Create new command for Payment cancelling in "Paid in Expensify" reports Jan 19, 2024
Copy link

melvin-bot bot commented Jan 19, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.27-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-26. 🎊

For reference, here are some details about the assignees on this issue:

  • @Ollyws requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Jan 19, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@Ollyws] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

3 participants