Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD PR #32124] Spinner appears at the bottom when scroll up 1/2 of the page and scroll back down #32462

Closed
1 of 6 tasks
m-natarajan opened this issue Dec 5, 2023 · 10 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Needs Reproduction Reproducible steps needed Weekly KSv2

Comments

@m-natarajan
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1698623055435299

Action Performed:

  1. Open a chat with lots of messages
  2. Scroll up like 1/2 of a page then scroll back down

Expected Result:

There should not be a spinner at the bottom

Actual Result:

There is a spinner at the bottom. Getting tons of log lines of API activity. Plus it seems to make the chat "jump around" a bit when the spinner appears/disappears.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

api call activity.txt

View all open jobs on GitHub

@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Dec 5, 2023
Copy link

melvin-bot bot commented Dec 5, 2023

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Dec 5, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@janicduplessis
Copy link
Contributor

@mallenexpensify I don't think so, @perunt I think this would be fixed by #32124 right?

@perunt
Copy link
Contributor

perunt commented Dec 5, 2023

Yes, the PR Chat loader flickering should fix it. But to be clear, we would have this spinner while doing comment-linking

@mallenexpensify mallenexpensify changed the title Spinner appears at the bottom when scroll up 1/2 of the page and scroll back down [HOLD PR #32124] Spinner appears at the bottom when scroll up 1/2 of the page and scroll back down Dec 5, 2023
@mallenexpensify
Copy link
Contributor

Thanks @janicduplessis and @perunt . I put this on hold pending PR #32124 . @stephanieelliott , once that PR has hit production, can you retest to confirm the bug is still reproducible?

@mallenexpensify mallenexpensify added Weekly KSv2 and removed Daily KSv2 labels Dec 5, 2023
@perunt perunt mentioned this issue Dec 6, 2023
47 tasks
@stephanieelliott
Copy link
Contributor

#32124 has hit production! @m-natarajan, can you restest this to see if it is still reproducible?

@melvin-bot melvin-bot bot added the Overdue label Dec 18, 2023
@stephanieelliott
Copy link
Contributor

#32124 has hit production! @m-natarajan, can you restest this to see if it is still reproducible?

bump @m-natarajan

@melvin-bot melvin-bot bot removed the Overdue label Dec 18, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 27, 2023
@stephanieelliott
Copy link
Contributor

Tested this myself, this is no longer reproducible!

@mallenexpensify
Copy link
Contributor

Also just tried to reproduce in Chrome on production, in #social room and BIG chat I have with Deeter and wasn't able to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Needs Reproduction Reproducible steps needed Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants