[CP Staging] Fix issues with scrollbar and status bar color #32672

chrispader · 2023-12-07T14:38:26Z

Details

Fixes multiple issues with status bar, color scheme and web background after theme switching, e.g. emoji/mention selection on Windows web.

Fixed Issues

$ #32591
$ #32695
$ #32657
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

situchan · 2023-12-07T17:38:24Z

-       :root {
-           color-scheme: dark !important;
-       }

Seems like another regression from above change: #32685
Can we fix it here?

grgia · 2023-12-07T17:58:34Z

@chrispader can we revert these as part of this PR and address any native issues with the wrapper as well?
https://github.com/Expensify/App/pull/13874/files#diff-bc1549da6355f7f82f324af9c667b78ff60672b6b80219062629fe4184e8fa93R69-R70

situchan · 2023-12-07T18:50:04Z

Another one: #32695

grgia · 2023-12-07T19:51:23Z

@situchan since you've been on top of these issues, mind I add you as C+?

situchan · 2023-12-07T19:54:34Z

@situchan since you've been on top of these issues, mind I add you as C+?

sure thanks. will review once ready for review

parasharrajat · 2023-12-07T21:08:41Z

Yeah, let's fix all scrollbar-related issues here which has the same root cause. Please add all to the issue list in the OP.

grgia · 2023-12-08T13:28:26Z

@parasharrajat shall I add you as C+ as well?

parasharrajat · 2023-12-08T14:05:59Z

I think its fine. One C+ is sufficient for this task. Please let me know if you need more eyes then I can help.

grgia · 2023-12-13T17:00:00Z

These minor issues are all related to the same root cause for tracking:
#32695
#32657
#32335 (comment)

melvin-bot · 2023-12-13T19:36:53Z

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

situchan · 2023-12-13T19:39:11Z

Can you please complete checklist, link fixed issues correctly and fix lint?

chrispader · 2023-12-13T19:40:22Z

Can you please complete checklist, link fixed issues correctly and fix lint?

done 👍

situchan · 2023-12-13T19:52:46Z

reviewing

src/Expensify.js

situchan · 2023-12-13T19:55:44Z

#32657 requires native code changes. Is it supposted to fix here?

grgia · 2023-12-14T03:39:53Z

I created an issue for the IOS issue discussed: #33037

situchan · 2023-12-14T03:57:14Z

Native part in #32591 should be handled in #33037 as well. Actually same issue.

Screen.Recording.2023-12-14.at.9.56.33.AM.mov

situchan · 2023-12-14T04:00:50Z

Please add all the cases fixed here in QA Steps

situchan · 2023-12-14T04:03:30Z

Please pull main as #21669 is merged

situchan · 2023-12-14T04:19:49Z

Not sure if this should be fixed here or out of scope, but some parts are not applied real time when change system theme
(tested after pull main which applied #21669)

Otherwise looks good!

Screen.Recording.2023-12-14.at.10.16.43.AM.mov

situchan · 2023-12-14T04:32:42Z

This maybe also related to native theme change in #33037. Btw out of scope

Keyboard theme should stick to app theme, not device theme

keyboard.mov

situchan · 2023-12-14T04:38:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

desktop-resize.mov

chrispader · 2023-12-14T13:08:16Z

Not sure if this should be fixed here or out of scope, but some parts are not applied real time when change system theme (tested after pull main which applied #21669)

yea, we can work on this in a follow-up PR

chrispader · 2023-12-14T13:23:19Z

This maybe also related to native theme change in #33037. Btw out of scope

Keyboard theme should stick to app theme, not device theme

I can only set this on IOS through the keyboardAppearance prop on TextInput.

Afaik, there is no official way to set the keyboard theme on Android, since Android allows "soft keyboards" and there technically is no protocol or system keyboard, just custom or preinstalled ones.

https://stackoverflow.com/a/39705139/5774312

We might be able to somehow natively change the keyboard theme, but developers of custom keyboards might still ignore it, so idk if we really want to pursue this

grgia · 2023-12-14T15:15:26Z

Not sure if this should be fixed here or out of scope, but some parts are not applied real time when change system theme (tested after pull main which applied #21669)

Otherwise looks good!

Screen.Recording.2023-12-14.at.10.16.43.AM.mov

Issue created: #33071

grgia · 2023-12-14T15:18:08Z

Keyboard theme should stick to app theme, not device theme

Afaik, there is no official way to set the keyboard theme on Android, since Android allows "soft keyboards" and there technically is no protocol or system keyboard, just custom or preinstalled ones.

@situchan @chrispader I wonder if other react native apps with dark/light mode handle this (i.e discord)
I agree it's polish and I think it looks okay if the keyboard matches the user's native OS- though if we can fix this, it would be nice polish.

Is it worth creating an issue for this?

grgia · 2023-12-14T15:18:59Z

@chrispader before I merge, could you add QA steps?

situchan · 2023-12-14T15:22:21Z

@situchan @chrispader I wonder if other react native apps with dark/light mode handle this (i.e discord)
I agree it's polish and I think it looks okay if the keyboard matches the user's native OS- though if we can fix this, it would be nice polish.

Is it worth creating an issue for this?

Not worth

OSBotify · 2023-12-14T15:24:40Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…ar-colors Fix issues with scrollbar and status bar color (cherry picked from commit b4d1777)

OSBotify · 2023-12-15T00:44:09Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 1.4.13-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-12-15T01:14:28Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 1.4.13-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-12-19T02:02:01Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.4.13-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

jjcoffee · 2024-03-07T09:52:08Z

Coming from #33674, where the status bar style wasn't correctly updating on initial app launch. This is due to setting the initial state of the status bar here:

App/src/components/CustomStatusBarAndBackground/index.tsx

Line 18 in 376bb95

const [statusBarStyle, setStatusBarStyle] = useState(theme.statusBarStyle);

But the status bar color isn't updated via updateStatusBarAppearance yet, so that initial state causes the status bar to not to change color due to this logic. More details here.

fix: scrollbar color on windows

3b2dbf4

chrispader mentioned this pull request Dec 7, 2023

[HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [HOLD #32672] [Theme Switching] 🐛 Web - Chat - The scroll bar is white in the emoji suggestion list #32591

Closed

6 tasks

grgia requested a review from situchan December 7, 2023 19:50

grgia self-requested a review December 8, 2023 13:01

chrispader added 3 commits December 13, 2023 19:44

Merge branch 'main' into @chrispader/fix-wrong-status-bar-colors

47dac4a

fix: set global background style

e3b7252

fix: status bar not chaning when changing theme from another device

119fff0

chrispader marked this pull request as ready for review December 13, 2023 19:36

chrispader requested a review from a team as a code owner December 13, 2023 19:36

melvin-bot bot requested review from fedirjh and removed request for a team December 13, 2023 19:36

remove unused import

b688242

grgia removed the request for review from fedirjh December 13, 2023 19:40

parasharrajat reviewed Dec 13, 2023

View reviewed changes

src/Expensify.js Outdated Show resolved Hide resolved

grgia mentioned this pull request Dec 14, 2023

[Theme Switching] 🐛 IOS Scrollbar Color Is Incorrect in Light Mode #33037

Closed

Merge branch 'main' into @chrispader/fix-wrong-status-bar-colors

269237a

set keyboard appearance

86d5e8a

situchan approved these changes Dec 14, 2023

View reviewed changes

grgia approved these changes Dec 14, 2023

View reviewed changes

grgia mentioned this pull request Dec 14, 2023

[Theme Switching] 🐛 Some parts of the App do not change in real time when changing system theme #33071

Closed

grgia merged commit b4d1777 into Expensify:main Dec 14, 2023
16 checks passed

grgia changed the title ~~Fix issues with scrollbar and status bar color~~ [CP Staging] Fix issues with scrollbar and status bar color Dec 14, 2023

grgia mentioned this pull request Dec 15, 2023

[Theme Switching] 🐛 Android - After applying light theme and opening IOU or task device status bar barely seen #33126

Closed

6 tasks

OSBotify pushed a commit that referenced this pull request Dec 15, 2023

Merge pull request #32672 from margelo/@chrispader/fix-wrong-status-b…

b4e59cb

…ar-colors Fix issues with scrollbar and status bar color (cherry picked from commit b4d1777)

github-actions bot mentioned this pull request Dec 15, 2023

Deploy Checklist: New Expensify 2023-12-14 #33072

Closed

77 tasks

jjcoffee mentioned this pull request Mar 7, 2024

[HOLD for payment 2024-03-07] [$500] Android - Home - Time and other elements in phone header is not visible in light mode #33674

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Fix issues with scrollbar and status bar color #32672

[CP Staging] Fix issues with scrollbar and status bar color #32672

chrispader commented Dec 7, 2023 •

edited

Loading

situchan commented Dec 7, 2023

grgia commented Dec 7, 2023

situchan commented Dec 7, 2023

grgia commented Dec 7, 2023

situchan commented Dec 7, 2023

parasharrajat commented Dec 7, 2023

grgia commented Dec 8, 2023

parasharrajat commented Dec 8, 2023

grgia commented Dec 13, 2023

melvin-bot bot commented Dec 13, 2023

situchan commented Dec 13, 2023

chrispader commented Dec 13, 2023

situchan commented Dec 13, 2023

situchan commented Dec 13, 2023

grgia commented Dec 14, 2023

situchan commented Dec 14, 2023

situchan commented Dec 14, 2023

situchan commented Dec 14, 2023

situchan commented Dec 14, 2023

situchan commented Dec 14, 2023

situchan commented Dec 14, 2023

chrispader commented Dec 14, 2023

chrispader commented Dec 14, 2023

grgia commented Dec 14, 2023

grgia commented Dec 14, 2023

grgia commented Dec 14, 2023

situchan commented Dec 14, 2023

OSBotify commented Dec 14, 2023

OSBotify commented Dec 15, 2023

OSBotify commented Dec 15, 2023

OSBotify commented Dec 19, 2023

jjcoffee commented Mar 7, 2024

[CP Staging] Fix issues with scrollbar and status bar color #32672

[CP Staging] Fix issues with scrollbar and status bar color #32672

Conversation

chrispader commented Dec 7, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

situchan commented Dec 7, 2023

grgia commented Dec 7, 2023

situchan commented Dec 7, 2023

grgia commented Dec 7, 2023

situchan commented Dec 7, 2023

parasharrajat commented Dec 7, 2023

grgia commented Dec 8, 2023

parasharrajat commented Dec 8, 2023

grgia commented Dec 13, 2023

melvin-bot bot commented Dec 13, 2023

situchan commented Dec 13, 2023

chrispader commented Dec 13, 2023

situchan commented Dec 13, 2023

situchan commented Dec 13, 2023

grgia commented Dec 14, 2023

situchan commented Dec 14, 2023

situchan commented Dec 14, 2023

situchan commented Dec 14, 2023

situchan commented Dec 14, 2023

situchan commented Dec 14, 2023

situchan commented Dec 14, 2023

Reviewer Checklist

Screenshots/Videos

chrispader commented Dec 14, 2023

chrispader commented Dec 14, 2023

grgia commented Dec 14, 2023

grgia commented Dec 14, 2023

grgia commented Dec 14, 2023

situchan commented Dec 14, 2023

OSBotify commented Dec 14, 2023

OSBotify commented Dec 15, 2023

OSBotify commented Dec 15, 2023

OSBotify commented Dec 19, 2023

jjcoffee commented Mar 7, 2024

chrispader commented Dec 7, 2023 •

edited

Loading