Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Chat - Screen blinks when open conversation #32752

Closed
3 of 6 tasks
lanitochka17 opened this issue Dec 8, 2023 · 17 comments
Closed
3 of 6 tasks

[$500] Chat - Screen blinks when open conversation #32752

lanitochka17 opened this issue Dec 8, 2023 · 17 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Dec 8, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.10-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Log in expensifail account
  3. Click FAB
  4. Click Start Chat
  5. Select any chat with conversations

Expected Result:

Conversation screen should open

Actual Result:

Conversation screen blinks

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6306286_1702069077567.Recording__1514.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b99b5f769ac6ad6a
  • Upwork Job ID: 1733230914660085760
  • Last Price Increase: 2023-12-15
@lanitochka17 lanitochka17 added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 8, 2023
@melvin-bot melvin-bot bot changed the title Chat - Screen blinks when open conversation [$500] Chat - Screen blinks when open conversation Dec 8, 2023
Copy link

melvin-bot bot commented Dec 8, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01b99b5f769ac6ad6a

Copy link

melvin-bot bot commented Dec 8, 2023

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 8, 2023
Copy link

melvin-bot bot commented Dec 8, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link

melvin-bot bot commented Dec 8, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

@AmjedNazzal
Copy link
Contributor

I this issue exclusive to expensifail accounts? if that's the case, shouldn't this be internal?

@melvin-bot melvin-bot bot added the Overdue label Dec 11, 2023
@shahinyan11
Copy link

My proposal for another issue will most likely fix this problem too

Copy link

melvin-bot bot commented Dec 12, 2023

@MitchExpensify, @fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@fedirjh
Copy link
Contributor

fedirjh commented Dec 12, 2023

Still awaiting proposals.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 12, 2023
Copy link

melvin-bot bot commented Dec 15, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@fedirjh
Copy link
Contributor

fedirjh commented Dec 15, 2023

Log in expensifail account

I was not able to reproduce on staging v1.4.13-5 . @lanitochka17 Is this bug only reproduced with expensifail accounts ?

@melvin-bot melvin-bot bot removed the Overdue label Dec 15, 2023
@lanitochka17
Copy link
Author

Issue reproducible on gmail account too. I used an account with a lot of conversations
Build 1.4.13-5

Recording.738.mp4

@melvin-bot melvin-bot bot added the Overdue label Dec 18, 2023
@keisyrzk
Copy link
Contributor

keisyrzk commented Dec 18, 2023

Do you mean this "loading" view state?
Simulator Screenshot - iPhone 15 Pro - 2023-12-18 at 08 28 13

If so it happens on ios as well. Btw. it looks like it happens only the first time you enter the conversation.

report: {
                key: ({route}) => `${ONYXKEYS.COLLECTION.REPORT}${getReportID(route)}`,
                allowStaleData: true,
                selector: reportWithoutHasDraftSelector,
            },

The "loading state" matches this code execution. If you wish not to see such a state perhaps we should move data fetching to the reports list view. Get the report's data on conversation record selection and when received navigate to its view. If you like to do so, we may expect some delay between click and navigation as data fetching in progress.
In this case, as a user, I would expect to see some kind of loader.

@MitchExpensify
Copy link
Contributor

Not overdue, being actively worked on

@melvin-bot melvin-bot bot removed the Overdue label Dec 18, 2023
@fedirjh
Copy link
Contributor

fedirjh commented Dec 18, 2023

@MitchExpensify I couldn’t recognise any bug in the recoerded video in #32752 (comment) . The skeleton is displayed at first (when we don't have any data yet) then the report is loaded and data displayed. Not sure what the screens blinks means in this case ?

@MitchExpensify
Copy link
Contributor

I think the "blink" is referring to this screen:

image

Is that right @lanitochka17 ?

@keisyrzk
Copy link
Contributor

If so, I do not experience such a behavior.

@MitchExpensify
Copy link
Contributor

Let's close this in that case. Its so minor and doesn't block any wave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

6 participants