Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-29] [CRITICAL] Update HTMLEngineProvider to use VideoRenderer #32771

Closed
francoisl opened this issue Dec 9, 2023 · 13 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2

Comments

@francoisl
Copy link
Contributor

Part of the NewDot Video Player project

Main issue: #20471
Doc section: https://docs.google.com/document/d/1Fh5Nu3D0-VW7xuV9Qc-OWWZl3-W5azx7Rr1lzNw4UGo/edit#heading=h.3iq5gzws08j5
Project: https://github.com/orgs/Expensify/projects/109

Feature Description

Update HTMLEngineProvider so we can render the video component on messages whose html value is a <video> tag

cc @Skalakid

@francoisl francoisl added the NewFeature Something to build that is a new item. label Dec 9, 2023
Copy link

melvin-bot bot commented Dec 9, 2023

@melvin-bot melvin-bot bot added the Weekly KSv2 label Dec 9, 2023
@francoisl francoisl moved this to CRITICAL in NewDot Video Player Dec 9, 2023

This comment was marked as outdated.

@Skalakid
Copy link
Contributor

Hi I’m Michał from Software Mansion, an expert agency, and I’d like to work on this issue

@francoisl
Copy link
Contributor Author

@Skalakid this is the first part that would not require all the components to be implemented, right? I'm trying to get a sense of whether this is something we can aim to finish next week, for the weekly update I'm preparing for tomorrow.

@Skalakid
Copy link
Contributor

Skalakid commented Dec 15, 2023

@francoisl No video player component need to be implemented to update HTMLEngineProvider. I think we can start by rendering <video> tags like current <a> tags. I created draft PR with the required changes

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 15, 2023
@melvin-bot melvin-bot bot changed the title [CRITICAL] Update HTMLEngineProvider to use VideoRenderer [HOLD for payment 2023-12-29] [CRITICAL] Update HTMLEngineProvider to use VideoRenderer Dec 22, 2023
Copy link

melvin-bot bot commented Dec 22, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 22, 2023
Copy link

melvin-bot bot commented Dec 22, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.15-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

  • @Skalakid does not require payment (Contractor)

Copy link

melvin-bot bot commented Dec 22, 2023

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@Skalakid] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@francoisl
Copy link
Contributor Author

This is on production, closing the issue.

@Ollyws
Copy link
Contributor

Ollyws commented Apr 10, 2024

@mallenexpensify I just noticed I was never paid for my review of #33145, any chance you could process payment for that? Thanks!

@mallenexpensify
Copy link
Contributor

Wowza, sorry @Ollyws . can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~013ee0d8a7106d964d

@Ollyws
Copy link
Contributor

Ollyws commented Apr 12, 2024

@mallenexpensify accepted, thanks!

@mallenexpensify
Copy link
Contributor

Contributor+: @Ollyws paid $500 via Upwork.

Sorry again for missing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2
Projects
No open projects
Status: CRITICAL
Development

No branches or pull requests

5 participants
@francoisl @Ollyws @mallenexpensify @Skalakid and others