-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-12-29] [CRITICAL] Update HTMLEngineProvider
to use VideoRenderer
#32771
Comments
Triggered auto assignment to @mallenexpensify ( |
This comment was marked as outdated.
This comment was marked as outdated.
Hi I’m Michał from Software Mansion, an expert agency, and I’d like to work on this issue |
@Skalakid this is the first part that would not require all the components to be implemented, right? I'm trying to get a sense of whether this is something we can aim to finish next week, for the weekly update I'm preparing for tomorrow. |
@francoisl No video player component need to be implemented to update HTMLEngineProvider. I think we can start by rendering |
HTMLEngineProvider
to use VideoRenderer
HTMLEngineProvider
to use VideoRenderer
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.15-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-12-29. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
This is on production, closing the issue. |
@mallenexpensify I just noticed I was never paid for my review of #33145, any chance you could process payment for that? Thanks! |
Wowza, sorry @Ollyws . can you please accept the job and reply here once you have? |
@mallenexpensify accepted, thanks! |
Contributor+: @Ollyws paid $500 via Upwork. Sorry again for missing this. |
Part of the NewDot Video Player project
Main issue: #20471
Doc section: https://docs.google.com/document/d/1Fh5Nu3D0-VW7xuV9Qc-OWWZl3-W5azx7Rr1lzNw4UGo/edit#heading=h.3iq5gzws08j5
Project: https://github.com/orgs/Expensify/projects/109
Feature Description
Update
HTMLEngineProvider
so we can render the video component on messages whosehtml
value is a<video>
tagcc @Skalakid
The text was updated successfully, but these errors were encountered: