IOU - User is able to select a date in the future when creating IOU request

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.11-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com.
2. Go to 1:1 DM > + > Request money.
3. Enter amount > Next.
4. Click Show more > Date.
5. Select a date in the future and create the request.

Expected Result:

User should not be allowed to select a date in the future when creating IOU request.

Actual Result:

User is able to select a date in the future when creating IOU request.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6309001_1702303263731.bandicam_2023-12-11_20-11-17-858__1_.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[shubham1206agra]

@tgolen Offending line
maxDate={dateAdd(new Date(), {years: 1})}
Is this intentional?

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Possible to select future date for IOU requests.

What is the root cause of that problem?

We set the max date to 1 year from now:

App/src/pages/iou/request/step/IOURequestStepDate.js

Line 74 in b884e29

maxDate={dateAdd(new Date(), {years: 1})}

What changes do you think we should make in order to solve the problem?

Should use maxDate={new Date()} instead if no future requests are allowed.

What alternative solutions did you explore? (Optional)

[tgolen]

This was intentional. I am closing this out because it's working as intended.

[Julesssss]

Might we need to update a testrails case here? or was this raised independently of a test case?

[luacmartins]

Agree that we should update testrail