[$500] Web - Workspace - User does not navigates to Admin room when create new Workspace

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.11-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Navigate to staging.new.expensify.com
2. Login with an account with no workspace
3. Create a workspace via the FAB button

Expected Result:

User should be navigated to the #admins room

Actual Result:

User does not navigates to Admin room

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6309344_1702315137928.Recording__1524.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fc9b8851006df053
• Upwork Job ID: 1734267218774921216
• Last Price Increase: 2024-01-22
• Automatic offers:
• DylanDylann | Contributor | 28121336

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fc9b8851006df053

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[shahinyan11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Workspace - User does not navigates to Admin room when create new Workspace

What is the root cause of that problem?

There is not navigation to admins room after clicking New Workspace

What changes do you think we should make in order to solve the problem?

1. Change this line with below code

 const adminsChatReportID = Policy.createWorkspace(policyOwnerEmail, makeMeAdmin, policyName, policyID);

2. Add below code before this line

Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(adminsChatReportID));

Untitled.mov

What alternative solutions did you explore? ( Optional)

To avoid changing the Policy.createDraftInitialWorkspace with Policy.createWorkspace we should update createDraftInitialWorkspace function so add draft report in Onyx data too

[brunovjk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The issue at hand revolves around users not being directed to the Admin room upon creating a new workspace.

What is the root cause of that problem?

The crux of the matter lies in the absence of redirection logic after crafting a workspace on the WorkspaceInitialPage. The critical sequence involves drafting, navigating to the initial workspace page, and finalizing the workspace creation. The absence to redirect to the #admins room is at the heart of the problem.

What changes do you think we should make in order to solve the problem?

I suggest we start by modifying the savePolicyDraftByNewWorkspace function in App.ts. The adjustment involves aligning it with the existing behavior in the createWorkspace function in Policy.js, ensuring a consistent approach to obtaining the adminsChatReportID after workspace creation.

function savePolicyDraftByNewWorkspace(policyID?: string, policyName?: string, policyOwnerEmail = '', makeMeAdmin = false) {
    return Policy.createWorkspace(policyOwnerEmail, makeMeAdmin, policyName, policyID);
}

Furthermore, in the WorkspaceInitialPage.js component, a delay is introduced after calling App.savePolicyDraftByNewWorkspace before navigating to the Admins Room. This delay ensures the user has adequate time to witness the workspace creation before redirection.

...
const policyDraftId = lodashGet(props.policyDraft, 'id', null);
if (!policyDraftId) {
    return;
}
const adminsChatReportID = App.savePolicyDraftByNewWorkspace(props.policyDraft.id, props.policyDraft.name, '', props.policyDraft.makeMeAdmin);

// After a small delay, navigate to Admins Room
setTimeout(() => {
    Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(adminsChatReportID));
}, 2000); // Adjust the delay time as needed

POC

32842_delay_to_admin.mp4

What alternative solutions did you explore? (Optional)

An alternative route involves integrating navigation directly to the #admins room after createDraftInitialWorkspace. This approach bypasses the intermediary step through WorkspaceInitialPage, simplifying the process.

function createWorkspaceWithPolicyDraftAndNavigateToIt(policyOwnerEmail = '', policyName = '', transitionFromOldDot = false, makeMeAdmin = false) {
...
    const adminsChatReportID = savePolicyDraftByNewWorkspace(policyID, policyName, '', makeMeAdmin);

    Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(adminsChatReportID));
...
}

32842_admin_direct.mp4

Note:I believe it would be a better approach if we can redirect to Workspace Welcome page instead of #AdminChat.

[melvin-bot]

@conorpendergrast, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[allstarsmen]

@conorpendergrast @thesahindia I don't think this is a bug.

Based on this comment in issue 28573, this is an expected behavior.

[melvin-bot]

@conorpendergrast, @thesahindia 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[conorpendergrast]

@kbecciv did this come from a specific regression test? If so, could you link to that? Otherwise, I agree that this isn't expected behaviour. I'll close for now, but am open to correction!

[kbecciv]

@conorpendergrast This came from TR here https://expensify.testrail.io/index.php?/tests/view/4055660

[zanyrenney]

apologies about the silence here @conorpendergrast - appreciate the bump.

[conorpendergrast]

@thesahindia Oh, oops, I just spotted that there are two proposals above to review!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[brunovjk]

Hi @conorpendergrast, any feedback on my proposal? Thanks.

[thesahindia]

@conorpendergrast, please reassign. I am not in a good shape, I won't be able to review.

[conorpendergrast]

Checking!

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[conorpendergrast]

Assigning @DylanDylann as C+, so adding the labels back

[shahinyan11]

@conorpendergrast Should I expect feedback about my proposal or no ?

[conorpendergrast]

@shahinyan11 Yeah; @DylanDylann has taken over as Contributor+. First task is to review all proposals!

[DylanDylann]

@conorpendergrast Thanks for clearing the step here In step 1

Login with an account with no workspace (or delete all workspaces)

You mean that we only should navigate to the admin room in the background if the user creates the first workspace, right?
In case, the current account has some workspaces and the user creates one more workspace. Do we want to navigate to the admin room in the background?

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Web - Workspace - User does not navigates to Admin room when create new Workspace

What is the root cause of that problem?

• We do not have a logic that navigates to the admin room when creating new workspace in here

What changes do you think we should make in order to solve the problem?

• Generally, we will add the admin report to the navigation stack like we add the report screen to stack if there was no report screen in the stack yet. Steps to do it:

1. Create a global variable, named policyAdminReportID and its getter, setter functions.
2. Before we open the Workspace Initial page:
   

   App/src/libs/actions/App.ts

   Line 340 in 7962905

   Navigation.navigate(ROUTES.WORKSPACE_INITIAL.getRoute(policyID));

   call:

    setPolicyAdminReportID(adminChatReportID)

3. In CustomRouter, create a function addReport that will add the report screen to the second position from the end.

const addReport = (state: State, reportID: string) => {
    const centralPaneNavigatorRoute = {
        name: NAVIGATORS.CENTRAL_PANE_NAVIGATOR,
        state: {
            routes: [
                {
                    name: SCREENS.REPORT,
                    params: {
                        reportID,
                    },
                },
            ],
        },
    };
    state.routes.splice(state.routes.length - 1, 0, centralPaneNavigatorRoute);
    // eslint-disable-next-line no-param-reassign, @typescript-eslint/non-nullable-type-assertion-style
    (state.index as number) = state.routes.length - 1;
};

4. Finally, in getRehydratedState, adding the condition:

            } else if (getPolicyAdminReportID()) {
                addReport(partialState, policyAdminReportID);
                setPolicyAdminReportID('');
            }

What alternative solutions did you explore? (Optional)

• NA

POC

Screencast.from.26-01-2024.13.23.42.webm

[shahinyan11]

Proposal

Updated

[conorpendergrast]

@DylanDylann That's a great clarifying question. Thinking through it again, I think that creating any workspace should navigate to that new workspace's room in the background (not just a first workspace). I'll check my thinking on that in the wave's Slack channel, and will come back to confirm the correct behaviour

[conorpendergrast]

Ah, I forgot that we're overhauling the new workspace flow entirely at the moment. So, this is not worth fixing! Closing out, thanks very much for your time everyone!