[$500] Android - Workspace-Tapping on triangle button user directed to "Get assistance" page for an second

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.11.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Launch app
2. Tap profile icon
3. Tap Workspaces --- Workspace --- Settings
4. Tap question mark on top
5. Tap explore help document
6. Tap Triangle icon at bottom right

Expected Result:

User must be directed to concierge page on tapping triangle button.

Actual Result:

User directed to "Get assistance" page for an second and then only directed to concierge page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6309381_1702316337276.you.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c891886ac837a3ba
• Upwork Job ID: 1734270044995203072
• Last Price Increase: 2023-12-18

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c891886ac837a3ba

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - Workspace-Tapping on triangle button user directed to "Get assistance" page for an second

What is the root cause of that problem?

The issue is related to recent deep link updates

App/src/libs/actions/Report.ts

Line 2012 in 292ad52

Navigation.waitForProtectedRoutes().then(() => {

Which adds a new promise which adds a delay
And instead of going first to ConciergePage where we would see the loader
We are waiting and then immediately navigated ConciergeReport without a loader

What changes do you think we should make in order to solve the problem?

To return to the old behavior
When we first navigate to ConciergePage
Then we see the loader
And after that, we see ConciergePage

We need to move logic from ConciergePage to Report

1. Update Report (We do not add isNavigationReady from ConciergePage because we use isNavigationReady inside waitForProtectedRoutes )

                if (route === ROUTES.CONCIERGE) {
                    Navigation.goBack(ROUTES.HOME);
                    navigateToConciergeChat(true);
                    return;
                }

App/src/libs/actions/Report.ts

Lines 2014 to 2017 in 292ad52

	if (route === ROUTES.CONCIERGE) {
	navigateToConciergeChat(true);
	return;
	}

2. Update ConciergePage (We can delete navigation logic Because we handle the navigation logic inside the Report

    useFocusEffect(() => {
        if (_.has(props.session, 'authToken')) {
            return;
        }
        Navigation.navigate();
    });

App/src/pages/ConciergePage.js

Lines 32 to 42 in 292ad52

	useFocusEffect(() => {
	if (_.has(props.session, 'authToken')) {
	// Pop the concierge loading page before opening the concierge report.
	Navigation.isNavigationReady().then(() => {
	Navigation.goBack(ROUTES.HOME);
	Report.navigateToConciergeChat();
	});
	} else {
	Navigation.navigate();
	}
	});

Screen.Recording.2023-12-12.at.22.11.49.mov

What alternative solutions did you explore? (Optional)

NA

[burczu]

Not overdue - I'll review the proposal soon.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@burczu, @miljakljajic Whoops! This issue is 2 days overdue. Let's get this updated quick!

[miljakljajic]

@burczu friendly bump! :)

[burczu]

@miljakljajic Sorry for the late answer - I've just tried to test the proposal from @ZhenjaHorbach but I could not reproduce the issue. It seems like the triangle on the help.expensify.com does not appear anymore. Could you confirm? Or maybe I'm doing it wrong? :)

Screen.Recording.2023-12-19.at.12.29.04.mov

[ZhenjaHorbach]

It's actually weird)
But yes
Maybe it's a web bug or new requirements
But I don't see the button either)

[burczu]

@miljakljajic gentle bump ;)

[burczu]

Hey @miljakljajic! I'll be OOO till January 6th, and right after that I'm leaving the C+ role and joining Waves. Could you assign another C+ engineer to handle this issue from now on? Thanks.

[miljakljajic]

Sorry to miss this! I will try to reproduce and re-assign. Have a lovely break!

[miljakljajic]

I think we can actually close this out, it doesn't fit high on our company priorities and seems like we've updated the flow anyway.