[LOW] [Splits] [$500] Chat - Member stays hidden if the reply comes in the IOU report

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.11.1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. Log in with two different accounts that didn't have any contact with each other yet
3. Account B: Create an IOU with account A
4. Account A: Open the chat with the IOU
5. Account A: Tap on the received IOU
6. Account A: Write any message
7. Account B: Navigate between conversations (to reveal the hidden account)

Expected Result:

The member should be revealed

Actual Result:

Member stays hidden if the reply comes in the IOU report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6309644_1702328633432.bandicam_2023-12-11_19-47-31-514.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cc37bbe9540440f6
• Upwork Job ID: 1734327335985864704
• Last Price Increase: 2024-01-01

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cc37bbe9540440f6

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[dksingla]

We are not getting enough details from the server about user A.

            "onyxMethod": "merge",
            "key": "personalDetailsList",
            "value": {
                "16127502": {
                    "accountID": 16127502,
                    "avatar": "https:\/\/d2k5nsl2zxldvw.cloudfront.net\/images\/avatars\/default-avatar_1.png",
                    "firstName": "",
                    "lastName": "",
                    "status": null
                },
                "16127512": {
                    "accountID": 16127512,
                    "avatar": "https:\/\/d2k5nsl2zxldvw.cloudfront.net\/images\/avatars\/default-avatar_13.png",
                    "firstName": "",
                    "lastName": "",
                    "status": null,
                    "displayName": "[email protected]",
                    "login": "[email protected]",
                    "pronouns": "",
                    "timezone": {
                        "automatic": true,
                        "selected": "Asia\/Calcutta"
                    },
                    "payPalMeAddress": "",
                    "phoneNumber": "",
                    "validated": true
                }
            }
        },```

[keisyrzk]

Hm please find my recording. I tried multiple times on staging server with fresh account being the User B. Have not seen the hidden naming at all. Did I miss something in reproduction steps?
I tried both ways when splitting the bill:
(1) click "split" on the side of the user on search

(2)
click "Request (...)" in user details

Recording:
https://github.com/Expensify/App/assets/18525360/1992cce0-2502-49f8-b53d-63729efa03d5

[abdulrahuman5196]

Reviewing now

[abdulrahuman5196]

@strepanier03 Isn't this the expected behaviour? Or are we changing the hidden feature?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@strepanier03, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@strepanier03, @abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[strepanier03]

Apologies for the delay here, I was OoO. I'll confirm the expected behavior and update everyone here.

[strepanier03]

We created a function in Auth to determine whether userA knows userB. The criteria are:

• if userB has ever requested money or sent an expense report to userA
• if userB has ever sent a message in a DM or groupDM that userA is a part of
• if userA and userB share access to at least one non-public workspace room or domain room

It looks like we need to fix this because userA replying to userB should establish the relationship between the accounts that allows for the user to be revealed.

[strepanier03]

Confirming wave/VIP here.

[melvin-bot]

@strepanier03 @abdulrahuman5196 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@strepanier03, @abdulrahuman5196 Eep! 4 days overdue now. Issues have feelings too...

[abdulrahuman5196]

We are waiting on this #32870 (comment). I think folks are off this week, so could expect delays in responses.

[strepanier03]

Assigned to a project and waiting to be picked up.

[melvin-bot]

@strepanier03, @abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[strepanier03]

Still up for grabs.

[strepanier03]

Chatting internally on the next step and urgency.

[melvin-bot]

@strepanier03, @abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[strepanier03]

Discussing whether or not to ask an expert agency to take this one on.

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[strepanier03]

Thanks for the update.

[strepanier03]

No update at this time. Low priority.

[mvtglobally]

Issue not reproducible during KI retests. (Third week)

[strepanier03]

This isn't reproducible after three weeks, so per SO, I'm going to close.