[$500] [HOLD for payment 2023-12-20] IOU - An employee cannot cancel a selected category when creating an IOU

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.11-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Preconditions:
In OldDot under admin, create a group policy, enable categories and add multiple categories, add an employee to the policy.

1. Open New Expensify app
2. Log in to the employee's account
3. Tap on the green plus button (FAB)
4. Select Request money
5. Select any currency and amount
6. Click next
7. Choose a group policy room
8. Click on "Show more"
9. In the category section, select any category
10. Navigate to the categories section again and click on the selected category marked with a green checkmark

Expected Result:

Employee must be able to override the selected category when creating an IOU

Actual Result:

An employee cannot cancel a selected category when creating an IOU

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6309688_1702331245473.Recording__919.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a8ca6c08fbc8290c
• Upwork Job ID: 1743060606199652352
• Last Price Increase: 2024-01-05

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU - An employee cannot cancel a selected category when creating an IOU

What is the root cause of that problem?

There's no clearing logic when select already selected category

App/src/pages/iou/request/step/IOURequestStepCategory.js

Lines 52 to 55 in e1d334a

	const updateCategory = (category) => {
	IOU.setMoneyRequestCategory_temporaryForRefactor(transactionID, category.searchText);
	navigateBack();
	};

What changes do you think we should make in order to solve the problem?

deselect by clearing transaction category when select category which is already selected

        IOU.setMoneyRequestCategory_temporaryForRefactor(transactionID, transaction.category === category.searchText ? '' : category.searchText);

[luacmartins]

Proposal looks good. Gonna assign @mkhutornyi to the issue

[shubham1206agra]

Please assign me here as C+

[Julesssss]

Cherry-picked to staging

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.11-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix not able to cancel selected category while creating IOU #32888

If no regressions arise, payment will be issued on 2023-12-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @shubham1206agra requires payment (Needs manual offer from BZ)
• @mkhutornyi requires payment (Needs manual offer from BZ)

[shubham1206agra]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR: Refactor the money request creation flow #28618
• [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/28618/files#r1432817280
• [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required
• [@shubham1206agra] Determine if we should create a regression test for this bug. No as we have caught this in deploy testing
• [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@luacmartins] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

@deetergp, @luacmartins, @shubham1206agra, @mkhutornyi Eep! 4 days overdue now. Issues have feelings too...

[deetergp]

Did this get paid out?

[shubham1206agra]

Nope

[melvin-bot]

@deetergp, @luacmartins, @shubham1206agra, @mkhutornyi Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@deetergp, @luacmartins, @shubham1206agra, @mkhutornyi Eep! 4 days overdue now. Issues have feelings too...

[deetergp]

@mallenexpensify I added you because I wasn't sure which label kicks off the BZ auto assigner 😅

[melvin-bot]

Current assignee @mallenexpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a8ca6c08fbc8290c

[melvin-bot]

Current assignee @shubham1206agra is eligible for the External assigner, not assigning anyone new.

[mallenexpensify]

@shubham1206agra @mkhutornyi can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01a8ca6c08fbc8290c

[shubham1206agra]

Done

[luacmartins]

Just pending payment

[mallenexpensify]

Contributor: @mkhutornyi paid $500 via Upwork
Contributor+: @shubham1206agra paid $500 via Upwork.

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

@shubham1206agra is there any reason we wouldn't want to create a regression test for this?

[shubham1206agra]

@mallenexpensify This is a deploy blocker and the applause already has this test in their flow already

[mallenexpensify]

Thanks @shubham1206agra