[HOLD for payment 2023-12-26] [$500] Chat/Search – "Hmm it's not here" page displayed on tapping Learn more link in Referral page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.11-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Navigate to staging.new.expensify.com
2. Log in with gmail account
3. Tap FAB button >> Start Chat >> Start a chat, get $250 banner >> learn more link
   OR Tap search icon in LHN >> Invite/Refer a friend banner >> Learn More link

Expected Result:

Relevant information page opens on tapping learn more link in referral page

Actual Result:

"Hmm it's not here" page displayed on tapping Learn more link in Referral page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6309703_1702332997565.RPReplay_Final1702326658.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015a99efc46bd3c79d
• Upwork Job ID: 1734339151804612608
• Last Price Increase: 2023-12-11
• Automatic offers:
• 0xmiroslav | Reviewer | 28042576
• neonbhai | Contributor | 28042578

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015a99efc46bd3c79d

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Hmm it's not here" page displayed on tapping Learn more link in Referral page

What is the root cause of that problem?

The link pointing to the referral program page is outdated:

App/src/pages/ReferralDetailsPage.js

Line 105 in 165caf5

<TextLink href={CONST.REFERRAL_PROGRAM.LEARN_MORE_LINK}>{translate('requestorStep.learnMore')}</TextLink>

What changes do you think we should make in order to solve the problem?

We need to change the value of this const:

App/src/CONST.ts

Line 2853 in 165caf5

LEARN_MORE_LINK: 'https://help.expensify.com/articles/new-expensify/billing-and-plan-types/Referral-Program',

to

https://help.expensify.com/articles/new-expensify/get-paid-back/Referral-Program

[0xmiros]

@neonbhai's proposal looks good to me
It was moved in #32787
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @nkuoch, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @0xmiroslav 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @neonbhai 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[johncschuster]

I will be OOO starting Monday, December 18, and will return Tuesday, January 2.

Current status:
Offers have been sent. We're waiting on a PR

If this issue is open when I'm back from OOO, I'll take it back over. Thank you!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.13-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: referral link #32950

If no regressions arise, payment will be issued on 2023-12-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @neonbhai requires payment automatic offer (Contributor)
• @0xmiroslav requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
• [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@0xmiroslav] Determine if we should create a regression test for this bug.
• [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@johncschuster / @michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @anmurali you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

@nkuoch, @johncschuster, @michaelhaxhiu, @anmurali, @neonbhai, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@nkuoch, @johncschuster, @michaelhaxhiu, @anmurali, @neonbhai, @0xmiroslav 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[johncschuster]

Ok! I'm back from OOO and will take this back over.

[johncschuster]

Payment Summary:

• @neonbhai - $500 - paid via Upwork (Contributor)
• @0xmiroslav - $500 - paid via Upwork (Reviewer)

[johncschuster]

@0xmiroslav can you complete the BZ checklist above when you get a moment? Do we require any regression test steps?

[0xmiros]

No need regression test as this came from helpDot change and also caught by Applause team

[johncschuster]

Sounds good! In that case, we should be good to go!

[lanitochka17]

Issue is still reproducible on the latest build 1.4.29-1

Hmm.it.s.not.here.mp4

Do we need to reopen this bug?