[HOLD for payment 2024-02-26] HIGH: Show "Workspace description" everywhere (2/2, external)

[quinthar]

Note: This is held on #32954 to fix a confusing name before we build on it further, as well as on #32615 to provide the foundation for room descriptions and description editing

Problem:
We have a "workspace welcome message" that is confusingly named (and will be renamed to "workspace description") and used unpredictably:

1. It is saved for the next invite, but cannot be edited outside of the invite flow
2. It is sent a standalone workspace invite email
3. It is sent again in a whisper in the new workspace chat

It's a strangely important and yet hidden feature.

Solution:
Let's show this important information in more places:

1. Similar to what is proposed for editing the room description, show the "workspace description" as an HTML output (ie, with hyperlinks) that can be tapped to edit via push-to-page. This will not only make it more obvious how to set it, but also show it to members looking at the workspace.

+-------------------------+
| < Workspace             |
|           +----+        |
|           |    |        |
|           |    |        |
|           +----+        |
|       Expensify Chat    |
|                         |
| (workspace description) | <- Show HTML description; push to page to edit
|                         |
| S Settings              |
| C Cards                 |
| R Reimbursements        |
| B Bills                 |
| I Invoices              |
| T Travel                |
| M Members               |
| B Bank account          |
| D Delete workspace      |
|                         |
|                         |
|                         |
+-------------------------+

2. This description will live in the description field on the policy in Onyx and be updated via the UpdateWorkspaceDescription API command

3. We should support the POLICYCHANGELOG_UPDATE_DESCRIPTION reportAction for displaying the changelog for the description in the #admins room

4. Let's remove the "add message" page from the invite flow altogether.

5. Let's se the workspace description as the room description for the workspace chat. So replace this message:

Collaboration between David Barrett and Expensify Inc. (NewDot Test Workspace) starts here! 🎉 This is the place to chat, request money and settle up.

With the workspace description:

Welcome to our NewDot test policy. You have been invited to submit ...

In this image:

This should reuse the the new room description feature code, so it'll appear both in the room description, as well as in the header:

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01172a1898d99f6e20
• Upwork Job ID: 1747013547396116480
• Last Price Increase: 2024-01-15
• Automatic offers:
• jjcoffee | Reviewer | 28108605
• esh-g | Contributor | 28108607

[esh-g]

Proposal

Please re-state the problem we are trying to solve?

Change 'workspace welcome message' to 'workspace description` and implement design

What is the root cause of the problem?

N/A (New feature)

What changes should be made to fix this?

1. To add the Description menu field to the WorkspaceInitialPage we can just add a MenuItemWithTopDescription just like I proposed for the roomDescription page here: [HOLD for payment 2024-02-15] [HOLD for payment 2024-02-14] [$1000] HIGH: Show "Room description" everywhere (2/2, external) #32615 (comment)
   We would also need to add a WORKSPACE_DESCRIPTION route and page for that route which can be just like the WelcomeMessage page for room description using the utilities that will be implemented in the internal issue.

<MenuItemWithTopDescription
      shouldShowRightIcon={isPolicyAdmin}
      description={translate('common.description')}
      title={policy.description}
      shouldRenderAsHTML
      onPress={() => Navigation.navigate(ROUTES.WORKSPACE_DESCRIPTION.getRoute(policyID))}
  />

2. As for displaying the header, I have already included it my proposal for roomDescription

3. Now for the Welcome message text, we can once again use the same approach used in my proposal for roomDescription here:
   

   App/src/components/ReportWelcomeText.js

   Lines 83 to 90 in 88d837c

   	{isPolicyExpenseChat && (
   	<>
   	<Text>{props.translate('reportActionsView.beginningOfChatHistoryPolicyExpenseChatPartOne')}</Text>
   	<Text style={[styles.textStrong]}>{ReportUtils.getDisplayNameForParticipant(props.report.ownerAccountID)}</Text>
   	<Text>{props.translate('reportActionsView.beginningOfChatHistoryPolicyExpenseChatPartTwo')}</Text>
   	<Text style={[styles.textStrong]}>{ReportUtils.getPolicyName(props.report)}</Text>
   	<Text>{props.translate('reportActionsView.beginningOfChatHistoryPolicyExpenseChatPartThree')}</Text>
   	</>

{policy.description ? <RenderHTML html={policy.description} /> : (

[melvin-bot]

Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Still overdue 6 days?! Let's take care of this!

[melvin-bot]

10 days overdue. I'm getting more depressed than Marvin.

[melvin-bot]

12 days overdue. Walking. Toward. The. Light...

[melvin-bot]

This issue has not been updated in over 14 days. eroding to Weekly issue.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01172a1898d99f6e20

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[puneetlath]

@esh-g I believe you said you expect to have a PR for this one ready today, is that right?

[esh-g]

Made the PR here: #36058
Some polishing and adding test steps is left. I'll add the steps ASAP.

[jjcoffee]

Just double checking, are we all aligned that we shouldn't be removing the "add message" page from the invite flow, per this comment? cc @quinthar @puneetlath

[puneetlath]

Yes, sounds good. We can always decide to do that after. It doesn't need to be a blocking decision for this PR for sure.

[puneetlath]

PR was merged.

Putting this from @jjcoffee here, so we don't forget:

@puneetlath Just wanted to flag a few issues that haven't been fixed here.
Bug: Android Native: The description text input doesn't immediately render at the correct size. - we decided this is most likely unrelated to this PR and should be fixed either separately or on a followup.
Bug: Sign out and sign in again, open a workspace chat with a description set. The chat initially shows "Workspace chat" before the actual description loads. (I couldn't replicate the same thing for room descriptions). - this seems like a BE issue
Bug: refreshing after navigating to the settings page to edit the description will display the chat in the background, rather than the settings page. - we've agreed on Slack that this shouldn't be a blocker (I believe this should be fixed at some point though!)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add workspace description #36058

If no regressions arise, payment will be issued on 2024-02-26. 🎊

For reference, here are some details about the assignees on this issue:

• @jjcoffee requires payment automatic offer (Reviewer)
• @esh-g requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jjcoffee] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[jjcoffee]

Regression Test Proposal

1. Navigate to the settings tab for any workspace and add a description
2. Verify that the description is saved
3. Go to the policy expense chat
4. Verify that the added description is shown both in header and chat masthead
5. Verify that clicking on the header description or chat masthead description opens the description edit page
6. Update the description
7. Verify that the #admins workspace room has the updated description report action

Do we agree 👍 or 👎

[jjcoffee]

@puneetlath Friendly bump for payment on this 🙇

[puneetlath]

Updated regression test issue here: https://github.com/Expensify/Expensify/issues/374200

[puneetlath]

Sorry for the delay. All paid. Thanks y'all!