[$500] Web - Settings - reload on set status closes RHN on back

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.12-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal team
Slack conversation:

Action Performed:

1. Open the app
2. Open settings->profile->status->status
3. Reload on the page
4. Click on back twice and observe that instead of opening profile page, it closes RHN

Expected Result:

App should open profile page on click on back on status page

Actual Result:

On reload on set status page and back twice, app closes RHN instead of opening profile page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6311905_1702485009367.windows_chrome_-_reload_on_set_status_closes_RHN_on_back.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0170b01de1f11ae942
• Upwork Job ID: 1735019080921497600
• Last Price Increase: 2023-12-27

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0170b01de1f11ae942

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[yh-0218]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Settings - reload on set status closes RHN on back

What is the root cause of that problem?

App/src/pages/settings/Profile/CustomStatus/StatusPage.js

Line 54 in 2782381

const navigateBackToSettingsPage = useCallback(() => {

we are now back to topMostReportID.

What changes do you think we should make in order to solve the problem?

we can use only this.

 Navigation.goBack(ROUTES.SETTINGS_PROFILE, false, true);

What alternative solutions did you explore? (Optional)

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Web - Settings - reload on set status closes RHN on back

What is the root cause of that problem?

• In the latest main, we have a logic to handle the back button in StatusPage:
  

  App/src/pages/settings/Profile/CustomStatus/StatusPage.js

  Line 72 in e81ed8f

  const navigateBackToPreviousScreen = useCallback(() => Navigation.goBack(ROUTES.SETTINGS_PROFILE, false, true), []);

• But in the staging, it will be (This change will fix the issue App should navigate back to current chat report after closing status modal #31051, but I do not know why we revert it in the latest main - See the pr) :

   const navigateBackToSettingsPage = useCallback(() => {
        const topMostReportID = Navigation.getTopmostReportId();
        if (topMostReportID) {
            Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(topMostReportID));
        } else {
            Navigation.goBack(ROUTES.SETTINGS_PROFILE, false, true);
        }
    }, []);

• So, because the bug is reported in staging env, I will do the RCA with the above code.
• The RCA is that, when we refresh the page, then click back button, Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(topMostReportID)); is called
• Then, in the Navigation.goback function, the logic bellow is called:
  

  App/src/libs/Navigation/Navigation.ts

  Lines 170 to 173 in e81ed8f

  	if (shouldEnforceFallback || (isFirstRouteInNavigator && fallbackRoute)) {
  	navigate(fallbackRoute, CONST.NAVIGATION.TYPE.UP);
  	return;
  	}

• That leads to the behavior: RHN is closed

What changes do you think we should make in order to solve the problem?

• Also, we can use the backTo params, that will store the previous screen to the URL params, and based on it, we know which screen we should navigate to after clicking on back button. Do it by the following main steps:

1. Update:
   

   App/src/ROUTES.ts

   Line 142 in e81ed8f

   SETTINGS_STATUS: 'settings/profile/status',

   
   to:

  SETTINGS_STATUS: {route: 'settings/profile/status', getRoute: (backTo?: string) => getUrlWithBackToParam('settings/profile/status', backTo)},

2. Update:
   

   App/src/pages/home/sidebar/AvatarWithOptionalStatus.js

   Lines 38 to 39 in e81ed8f

   	Navigation.setShouldPopAllStateOnUP();
   	Navigation.navigate(ROUTES.SETTINGS_STATUS);

   
   to:

        const activeRoute = Navigation.getActiveRouteWithoutParams();
        Navigation.navigate(ROUTES.SETTINGS_STATUS.getRoute(activeRoute));

3. Finally, update the navigateBackToPreviousScreen to:

    const navigateBackToPreviousScreen = useCallback(() => {
        const backTo = lodashGet(route, 'params.backTo', '');
        Navigation.goBack(backTo || ROUTES.SETTINGS_PROFILE);
    }, [route]);

What alternative solutions did you explore? (Optional)

• First, we need to revert the change that was removed.
• We can export the shouldPopAllStateOnUP - which Inform the navigation that next time user presses UP we should pop all the state back to LHN
• Then, update the above navigateBackToSettingsPage to:

    const navigateBackToPreviousScreen = useCallback(() => {
        const topMostReportID = Navigation.getTopmostReportId();
+      const shouldPopAllStateOnUP = Navigation.getShouldPopAllStateOnUP();
+        if (shouldPopAllStateOnUP && topMostReportID) {
            Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(topMostReportID));
        } else {
            Navigation.goBack(ROUTES.SETTINGS_PROFILE, false, true);
        }
    }, []);

[abdulrahuman5196]

Hi, Will review today.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[abdulrahuman5196]

Reviewing now

[abdulrahuman5196]

@slafortune

I am seeing a different flow in current staging, am I need to be in some beta to be able to see the flow mentioned in the bug?

Screen.Recording.2023-12-20.at.11.11.33.PM.mov

[abdulrahuman5196]

Waiting on @slafortune here #33002 (comment).
I think folks are off this week. So could expect delay in responses.

[melvin-bot]

@slafortune @abdulrahuman5196 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[slafortune]

Actually @abdulrahuman5196 I'm not able to reproduce this again now either!