-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Paid in money request preview #33020
Conversation
const getSettledMessage = () => { | ||
if (isExpensifyCardTransaction) { | ||
return props.translate('common.done'); | ||
} | ||
switch (lodashGet(props.action, 'originalMessage.paymentType', '')) { | ||
case CONST.IOU.PAYMENT_TYPE.EXPENSIFY: | ||
return props.translate('iou.settledExpensify'); | ||
default: | ||
return props.translate('iou.settledElsewhere'); | ||
return translate('common.done'); | ||
} | ||
return translate('iou.settledExpensify'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the important change, the rest is beauty
@mountiny lint is failing |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.13-0 🚀
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.13-0 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.4.13-8 🚀
|
Details
The IOU create action does not know what payment type has been used to settle a report so lets just use the generic
Paid
message in the report.The payment type is captured in the
Pay
action which is then at the end of the report.Fixed Issues
Partially #32412
Tests
Paid
Repeat same for the expense report
Notice the card says
Paid
but the message below says the payment typeOffline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Simple logic change
Android: mWeb Chrome
Simple logic change
iOS: Native
Simple logic change
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Same as web