-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-12-26] [Wave 6: Workspace Chats] The Next steps are not showing in plural as they do in OldDot #33022
Comments
Triggered auto assignment to @sophiepintoraetz ( |
Job added to Upwork: https://www.upwork.com/jobs/~01c12e2ada13c1b9c0 |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Contributor Plus for review of internal employee PR - @situchan ( |
This can be handled internally as its a simple fix |
Merged and nothing to pay |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.13-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-12-26. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO. |
This is done |
Problem
Coming from here, there is an inconsistency with OldDot next steps.
In OldDot the expense report shows the next steps in plural language as
These expenses are going to be submitted...
etc, whereas in NewDot we are showing this message as singular. That is used in the expense megaEdit in OldDot, but it should not be used hereSolution
Update the language to be plural to make it consistent with the OldDot view
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: