Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Desktop app updates then is backgrounded, chats don't load #33024

Closed
1 of 6 tasks
m-natarajan opened this issue Dec 13, 2023 · 23 comments
Closed
1 of 6 tasks

When Desktop app updates then is backgrounded, chats don't load #33024

m-natarajan opened this issue Dec 13, 2023 · 23 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@m-natarajan
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1702503781867299

Action Performed:

  1. App is updated
  2. App opens and is backgrounded (ie. another window is open on top of NewDot)

Expected Result:

App to load, inc. LHN and a chat

Actual Result:

App just shows the E logo and doesn't load until it's in the foreground.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

@m-natarajan m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 13, 2023
Copy link

melvin-bot bot commented Dec 13, 2023

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Dec 13, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@mallenexpensify
Copy link
Contributor

mallenexpensify commented Dec 13, 2023

@TMisiukiewicz want me to assign this to you?
Further discussion is here https://expensify.slack.com/archives/C05LX9D6E07/p1698250259267259

@TMisiukiewicz
Copy link
Contributor

@mallenexpensify please assign me, thanks!

@mallenexpensify
Copy link
Contributor

Assigned @TMisiukiewicz !
I feel like I had an instance late last week where the app was backgrounded and DID load. I'll attempt to reproduce and report back if it is loading while backgrounded.

@mallenexpensify
Copy link
Contributor

I just updated to Version 1.4.14-0 and the app loaded while backgrounded.
I closed NewDot ,reopened and immediately backgrounded and the appeared to not show chats when backgrounded (I should prolly test this more though)

@TMisiukiewicz
Copy link
Contributor

@mallenexpensify I was not able to reproduce it yet, gonna try again today also with reopening and immediate backgrounding 👍

@TMisiukiewicz
Copy link
Contributor

Still cannot reproduce it in any way. However I have investigated when the splash screen is displayed and there are numerous conditions that has to be met to hide it:

  • app needs to get server's response to determine if a room is public
  • navigation is ready
  • user is not authenticated or the sidebar is loaded
  • splash screen is visible

I assume one of them is not met in some specific situation but since I couldn't reproduce it, it's hard to point which one. In my opinion the biggest possibility is server response and loaded sidebar, however I always got correct values here.

I closed NewDot ,reopened and immediately backgrounded and the appeared to not show chats when backgrounded (I should prolly test this more though)

@mallenexpensify did you see the green splash screen and Expensify logo in this situation, or you had skeleton loader instead of chats?

@mallenexpensify
Copy link
Contributor

Just closed and reopened.

  • Showed green page with icon for a while ~30 seconds
  • App loaded as expected

So...I'm not experiencing the issue any more. I did post in #expensify-bugs to see if others were though, since it used to happen to me allllll the time
https://expensify.slack.com/archives/C049HHMV9SM/p1703025068775339?thread_ts=1702503781.867299&cid=C049HHMV9SM

@TMisiukiewicz
Copy link
Contributor

Let's wait some time to see if it is reproducible for others then 👍

@dylanexpensify
Copy link
Contributor

reviewing today reproducibility!

@mallenexpensify
Copy link
Contributor

I think I had a weird instance this morn

  • Updated desktop
  • Background desktop briefly
  • Put computer to sleep by dragging cursor to bottom left corner (not the same as closing lid on laptop)
  • Logged back in using fingerprint
  • When I finally foregrounded NewDot, it hadn't loaded, think it was just he E icon then skeleton then loaded.

Def an edge case but dropping in here cuz I happened to see this issue in my inbox

@melvin-bot melvin-bot bot added the Overdue label Dec 22, 2023
Copy link

melvin-bot bot commented Dec 25, 2023

@TMisiukiewicz, @dylanexpensify Huh... This is 4 days overdue. Who can take care of this?

Copy link

melvin-bot bot commented Dec 27, 2023

@TMisiukiewicz @dylanexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Dec 27, 2023

@TMisiukiewicz, @dylanexpensify Still overdue 6 days?! Let's take care of this!

Copy link

melvin-bot bot commented Dec 29, 2023

@TMisiukiewicz, @dylanexpensify 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

Copy link

melvin-bot bot commented Jan 2, 2024

@TMisiukiewicz, @dylanexpensify 12 days overdue now... This issue's end is nigh!

@TMisiukiewicz
Copy link
Contributor

still couldn't reproduce

@melvin-bot melvin-bot bot removed the Overdue label Jan 3, 2024
Copy link

melvin-bot bot commented Jan 3, 2024

@TMisiukiewicz @dylanexpensify this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@mallenexpensify
Copy link
Contributor

Haven't had this happen for a bit and it doesn't appear others have so... gonna close

@mallenexpensify
Copy link
Contributor

Reopening, this just happened to me now, Desktop was background for many minutes (unsure, but at least 10?) and didn't load til I clicked it. Pretty sure it happened yesterday too but I tested, by closing/reopening and it loaded correctly, so the bug might be specific to Desktop updating to a new version

@melvin-bot melvin-bot bot added the Overdue label Jan 22, 2024
@dylanexpensify
Copy link
Contributor

Oh weird, will investigate

@melvin-bot melvin-bot bot removed the Overdue label Jan 23, 2024
@mallenexpensify
Copy link
Contributor

fwiw... gonna close again cuz I've been trying to reproduce and am unable to. I'm guessing others aren't able to either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

4 participants