[$500] App missing parameter triggers backend error

[tylerkaraszewski]

This issue was created: https://github.com/Expensify/Expensify/issues/349757

Because this line:
https://github.com/Expensify/App/pull/30737/files#diff-112aa19f2ab27905a9cd6ce992a483fff32792ea32ede1767f2af6e42e1e548bR130

Seems to have been triggered without a transaction object. Since this code was jsut introduced on staging yesterday, I'm assigning @tgolen to look.

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Action Performed:

Break down in numbered steps

Expected Result:

Describe what you think should've happened

Actual Result:

Describe what actually happened

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c2cd3f67471d554b
• Upwork Job ID: 1735678345901907968
• Last Price Increase: 2023-12-15

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c2cd3f67471d554b

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[tgolen]

I am heads down in some other stuff so I am opening this up to contributors to look into it.

[trjExpensify]

Posted in C+: https://expensify.slack.com/archives/C02NK2DQWUX/p1702653244173719

[situchan]

Seems like all these regressions came from same PR:

• [HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] Expense - App crashes when saving expense date twice in offline mode #33098
• [$500] App missing parameter triggers backend error #33099
• Web - Expense - Fields are blank and header shows $0.00 request when changing date #33103

[abzokhattab]

Unable to access this issue: https://github.com/Expensify/Expensify/issues/349757

[trjExpensify]

One of Tyler's comments is:

Someone called UpdateMoneyRequestDate with no transactionID.

[situchan]

This is dupe of #33098.
So transactionID is missing in UpdateMoneyRequestDate api param when update date 2nd time in offline mode

[rushatgabhane]

not sure how i can help here

[trjExpensify]

So @situchan are you saying we should close this issue in favour of #33098?

[situchan]

So @situchan are you saying we should close this issue in favour of #33098?

yes

[situchan]

Or @tylerkaraszewski can double check before closing, as the fix is now on staging

[jasperhuangg]

I re-tested these flows and they appear to be working, closing this out