Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the recentlyUsedReportFields to Onyx #33129

Closed
thienlnam opened this issue Dec 14, 2023 · 13 comments
Closed

Pass the recentlyUsedReportFields to Onyx #33129

thienlnam opened this issue Dec 14, 2023 · 13 comments
Assignees
Labels
Daily KSv2

Comments

@thienlnam
Copy link
Contributor

https://docs.google.com/document/d/1LXGXwWsei-Zx2wJMaYBmVe_M8NH7AHJZ5bIqwSec4uo/edit#bookmark=id.dbp78kbhqu10

@thienlnam thienlnam added the Daily KSv2 label Dec 14, 2023
@thienlnam thienlnam self-assigned this Dec 14, 2023
Copy link

melvin-bot bot commented Dec 18, 2023

@thienlnam Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Dec 18, 2023
Copy link

melvin-bot bot commented Dec 18, 2023

@thienlnam Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Dec 20, 2023

@thienlnam Eep! 4 days overdue now. Issues have feelings too...

@thienlnam
Copy link
Contributor Author

Working on this - it's a bit tricky as we need to migrate all historical data and make sure this still works

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 20, 2023
Copy link

melvin-bot bot commented Dec 26, 2023

@thienlnam Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Dec 28, 2023

@thienlnam 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Copy link

melvin-bot bot commented Jan 1, 2024

@thienlnam 10 days overdue. Is anyone even seeing these? Hello?

1 similar comment
Copy link

melvin-bot bot commented Jan 1, 2024

@thienlnam 10 days overdue. Is anyone even seeing these? Hello?

@thienlnam
Copy link
Contributor Author

Starting on this today

@melvin-bot melvin-bot bot removed the Overdue label Jan 2, 2024
@thienlnam
Copy link
Contributor Author

There's a few steps that need to happen in order

  1. Create the recentlyUsedReportFields NVP, and update the locations where a new NVP is saved
  2. Migrate all historical data to this new NVP
  3. Update the instances where the old NVP is being used to fetch a value, and retrieve it from the new NVP

@melvin-bot melvin-bot bot added the Overdue label Jan 5, 2024
@thienlnam
Copy link
Contributor Author

To avoid needlessly overengineering this, I'm going to reuse the old format of the recently used in https://github.com/Expensify/Web-Expensify/pull/40370

@melvin-bot melvin-bot bot removed the Overdue label Jan 8, 2024
@thienlnam thienlnam changed the title Create the recentlyUsedReportFields NVP Pass the recentlyUsedReportFields to Onyx Jan 8, 2024
@thienlnam
Copy link
Contributor Author

@melvin-bot melvin-bot bot added the Overdue label Jan 10, 2024
@thienlnam
Copy link
Contributor Author

This is live!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2
Projects
None yet
Development

No branches or pull requests

1 participant