[$500] mWeb/Chrome - Chat – Deleted message appears briefly when navigate via IOU link after re-login. #33144

izarutskaya · 2023-12-15T09:52:47Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: v1.4.13-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

Go to https://staging.new.expensify.com/
As account A, create an IOU with account B.
Navigate to the IOU details page and copy the URL.
Log out.
Log in with the same account or account B and navigate to the copied URL.

Expected Result:

IOU link opens.

Actual Result:

Deleted message appears briefly in a chat when navigate via IOU link after re-login.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6314216_1702630093991.Deleted_message.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010bcca99fc0ffe3ae
Upwork Job ID: 1735598780619743232
Last Price Increase: 2023-12-29

melvin-bot · 2023-12-15T09:52:51Z

Job added to Upwork: https://www.upwork.com/jobs/~010bcca99fc0ffe3ae

melvin-bot · 2023-12-15T09:52:52Z

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-12-15T09:52:53Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2023-12-15T09:52:57Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

bernhardoj · 2023-12-15T10:41:08Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

[Delete message] shows in the money request detail header after login.

What is the root cause of that problem?

The header should show the transaction name if it is working correctly.

App/src/libs/ReportUtils.ts

Lines 2261 to 2263 in 8bef4bb

    
           if (isNotEmptyObject(parentReportAction) && ReportActionsUtils.isTransactionThread(parentReportAction)) { 
        
               return getTransactionReportName(parentReportAction); 
        
           }

But the parentReportAction is empty, so the header will show [Deleted message].

App/src/libs/ReportUtils.ts

Line 2276 in 8bef4bb

    
           return parentReportActionMessage || Localize.translateLocal('parentReportAction.deletedMessage');

Even when the report loading is complete, the parentReportAction is not immediately available. From my findings, when we open the transaction report/thread, it will call the OpenReport API and it will return the transaction report data along with the parent report action data. But it takes time to merge them all, so we can briefly see the [Deleted message].

What changes do you think we should make in order to solve the problem?

If the report has a parentReportID and parentReportActionID, keep showing the skeleton loader until the parent report action is available.

The code will look like this:

(props.report && props.report.parentReportID && props.report.parentReportActionID && _.isEmpty(ReportActionsUtils.getParentReportAction(props.report)))

yh-0218 · 2023-12-15T11:07:30Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

[Delete message] shows in the money request detail header after login.

What is the root cause of that problem?

Report actions is slowly loaded than reports.
Transaction title should returned here

App/src/libs/ReportUtils.ts

Line 2262 in 4592a7c

return getTransactionReportName(parentReportAction);

But returned here because parentReportAction is empty

App/src/libs/ReportUtils.ts

Line 2276 in 4592a7c

    
           return parentReportActionMessage || Localize.translateLocal('parentReportAction.deletedMessage');

What changes do you think we should make in order to solve the problem?

We need to check all actions is loaded before returning.

       const allReportActions = ReportActionsUtils.getAllReportActions(report.reportID);
        if(!parentReportActionMessage && isEmptyObject(allReportActions)) {
            return '';
        }

We need to add this code before return delete title.

App/src/libs/ReportUtils.ts

Line 2276 in 4592a7c

    
           return parentReportActionMessage || Localize.translateLocal('parentReportAction.deletedMessage');

when we return '', header will be shown as loading.

What alternative solutions did you explore? (Optional)

Screen.Recording.2023-12-15.at.1.06.23.PM.mov

melvin-bot · 2023-12-18T11:22:12Z

@NicMendonca, @fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

fedirjh · 2023-12-18T22:08:19Z

@bernhardoj Thanks for the proposal.

The code will look like this:

Where this code should be placed ?

fedirjh · 2023-12-18T22:11:20Z

@yh-0218 Thanks for the proposal.

Report actions is slowly loaded than reports.

What does it means slowly loaded in this case ?

We need to check all actions is loaded before returning.

Can you elaborate more on this point ? How to check if all actions are loaded ?

yh-0218 · 2023-12-18T22:29:01Z

I got const allReportActions = ReportActionsUtils.getAllReportActions(report.reportID);
When we get props.report value on HeaderView, allReportActions of ReportActionsUtils is {} during very short time.
This time is long on Android(because android is slow).
so we get return value here.

App/src/libs/ReportUtils.ts

Line 2276 in 648c000

    
           return parentReportActionMessage || Localize.translateLocal('parentReportAction.deletedMessage');

Because of ParentReportAction is {}, we get deleted message.
So during allReportActions is {} (very short time), I returned '' value.
when title is '', HeaderView is on loading status.
When allReportActions has value, then we can get correct title.

@fedirjh

yh-0218 · 2023-12-18T22:32:05Z

App/src/libs/ReportUtils.ts

Line 2259 in 648c000

const parentReportAction = ReportActionsUtils.getParentReportAction(report);

We get parentReportAction to get title, but above code is available when allReportActions of ReportActionsUtils has value.
So I checked that value.

fedirjh · 2023-12-18T23:07:54Z

const allReportActions = ReportActionsUtils.getAllReportActions(report.reportID);
if(!parentReportActionMessage && isEmptyObject(parentReportAction)) {
return '';
}

@yh-0218 you get allReportActions but you didn’t use it in your code , that’s confusing.

bernhardoj · 2023-12-19T05:33:56Z

@fedirjh we will put it in HeaderView and ReportScreen.

App/src/pages/home/HeaderView.js

Lines 199 to 209 in aa1d87c

    
           const isLoading = !props.report || !title; 
        
           return ( 
        
               <View 
        
                   style={[styles.appContentHeader, shouldShowBorderBottom && styles.borderBottom]} 
        
                   dataSet={{dragArea: true}} 
        
               > 
        
                   <View style={[styles.appContentHeaderTitle, !isSmallScreenWidth && !isLoading && styles.pl5]}> 
        
                       {isLoading ? ( 
        
                           <ReportHeaderSkeletonView onBackButtonPress={props.onNavigationMenuButtonClicked} /> 
        
                       ) : (

App/src/pages/home/ReportScreen.js

Line 190 in aa1d87c

const isLoading = !reportID || !isSidebarLoaded || _.isEmpty(personalDetails);

App/src/pages/home/ReportScreen.js

Line 467 in aa1d87c

    
           {(!isReportReadyForDisplay || isLoadingInitialReportActions || isLoading) && <ReportActionsSkeletonView />}

yh-0218 · 2023-12-19T08:15:30Z

const allReportActions = ReportActionsUtils.getAllReportActions(report.reportID);
if(!parentReportActionMessage && isEmptyObject(allReportActions)) {
    return '';
}

Sorry @fedirjh
My mistake to create proposal.
We need to check allReportActions is empty.

melvin-bot · 2023-12-22T11:20:13Z

@NicMendonca, @fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot · 2023-12-22T16:00:14Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

NicMendonca · 2023-12-22T17:20:55Z

@fedirjh proposals for you! ^

melvin-bot · 2023-12-26T11:39:30Z

@NicMendonca, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot · 2023-12-28T11:35:42Z

@NicMendonca, @fedirjh Huh... This is 4 days overdue. Who can take care of this?

melvin-bot · 2023-12-29T11:02:46Z

@NicMendonca @fedirjh this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot · 2023-12-29T16:00:44Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

fedirjh · 2023-12-30T07:34:42Z

@bernhardoj @yh-0218 Why the skeleton is not diplayed when the parentReportAction is empty ? So if there was a delay with Onyx then it should display the skeleton in the meantime. it seems that there is something wrong with rendering cycle .

bernhardoj · 2023-12-30T07:48:45Z

@fedirjh you mean you still didn't see the skeleton after applying the solution? If yes, I don't know if it gonna help but can you try to subscribe to the parentReportActions onyx?

parentReportActions: {
    key: ({report}) => `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report?.parentReportID}`,
    canEvict: false,
},

Then, you can do this to get the specific parent report action.

const parentReportAction = props.parentReportActions[`${props.report.parentReportActionID}`];

theoritically, you should see the skeleton without the above code, but we still need to apply the above code at the end
The code I wrote in the proposal is just to make it simple.

fedirjh · 2024-01-02T17:18:46Z

you mean you still didn't see the skeleton after applying the solution?

@bernhardoj Not really, what I meant is that if the data is in loading state then why getReportName is called ? then I just realised that the report is loaded but the parentReportAction is not loaded yet.

So the problem is within this line :

App/src/libs/ReportUtils.ts

Line 2276 in 4592a7c

    
           return parentReportActionMessage || Localize.translateLocal('parentReportAction.deletedMessage');

we assume that empty parentReportActionMessage means the report is deleted, but we didn’t consider the case when the parentReportAction is still loading.

melvin-bot · 2024-01-02T17:33:33Z

@NicMendonca, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!

fedirjh · 2024-01-02T19:22:59Z

This is quite tricky.

@bernhardoj , I believe your solution may not be correct. I suspect it could fail in the case of a deleted parent report action, which would result in the skeleton being displayed indefinitely. I think we should also check whether the parentReportAction has been deleted or not. Is that possible?

@yh-0218, your solution makes sense, but the code does not appear to be correct. As @bernhardoj mentioned, we should verify whether the report contains both a parentReportID and a parentReportActionID. We will use the parentReportID to retrieve the parent report action, not the reportID.

bernhardoj · 2024-01-03T03:29:53Z

I suspect it could fail in the case of a deleted parent report action, which would result in the skeleton being displayed indefinitely

From my testing, if the parent action is deleted, the action still exists, only the message is deleted.

Here is how the action object looks on a normal thread

Here is how the action object looks on a transaction (IOU) thread

yh-0218 · 2024-01-03T05:30:32Z

@fedirjh I think this is good way.

if(report?.parentReportID && report?.parentReportActionID && isEmptyObject(parentReportAction)) {
    return '';
}

NicMendonca · 2024-01-04T21:05:10Z

Navigate to the IOU details page and copy the URL.
Log out
Log in with the same account or account B and navigate to the copied URL

^ I am not sure how common of a practice this is going to be for end-users.

So with that, I am going to close this based on this -- https://expensify.slack.com/archives/C01GTK53T8Q/p1702496349813859

Since this is not directly related to a roadmap feature.

Appreciate the discussion so far!

izarutskaya added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 15, 2023

melvin-bot bot assigned NicMendonca Dec 15, 2023

melvin-bot bot changed the title ~~mWeb/Chrome - Chat – Deleted message appears briefly when navigate via IOU link after re-login.~~ [$500] mWeb/Chrome - Chat – Deleted message appears briefly when navigate via IOU link after re-login. Dec 15, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 15, 2023

melvin-bot bot assigned fedirjh Dec 15, 2023

melvin-bot bot added the Overdue label Dec 18, 2023

melvin-bot bot removed the Overdue label Dec 18, 2023

melvin-bot bot added the Overdue label Dec 21, 2023

melvin-bot bot added Overdue and removed Overdue labels Dec 22, 2023

melvin-bot bot removed the Overdue label Dec 30, 2023

melvin-bot bot added the Overdue label Jan 1, 2024

melvin-bot bot removed the Overdue label Jan 2, 2024

NicMendonca closed this as completed Jan 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[$500] mWeb/Chrome - Chat – Deleted message appears briefly when navigate via IOU link after re-login. #33144

[$500] mWeb/Chrome - Chat – Deleted message appears briefly when navigate via IOU link after re-login. #33144

izarutskaya commented Dec 15, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Dec 15, 2023

melvin-bot bot commented Dec 15, 2023

melvin-bot bot commented Dec 15, 2023

melvin-bot bot commented Dec 15, 2023

bernhardoj commented Dec 15, 2023 •

edited

Loading

yh-0218 commented Dec 15, 2023 •

edited

Loading

melvin-bot bot commented Dec 18, 2023

fedirjh commented Dec 18, 2023

fedirjh commented Dec 18, 2023

yh-0218 commented Dec 18, 2023

yh-0218 commented Dec 18, 2023

fedirjh commented Dec 18, 2023

bernhardoj commented Dec 19, 2023

yh-0218 commented Dec 19, 2023

melvin-bot bot commented Dec 22, 2023

melvin-bot bot commented Dec 22, 2023

NicMendonca commented Dec 22, 2023

melvin-bot bot commented Dec 26, 2023

melvin-bot bot commented Dec 28, 2023

melvin-bot bot commented Dec 29, 2023

melvin-bot bot commented Dec 29, 2023

fedirjh commented Dec 30, 2023

bernhardoj commented Dec 30, 2023

fedirjh commented Jan 2, 2024

melvin-bot bot commented Jan 2, 2024

fedirjh commented Jan 2, 2024

bernhardoj commented Jan 3, 2024

yh-0218 commented Jan 3, 2024

NicMendonca commented Jan 4, 2024

[$500] mWeb/Chrome - Chat – Deleted message appears briefly when navigate via IOU link after re-login. #33144

[$500] mWeb/Chrome - Chat – Deleted message appears briefly when navigate via IOU link after re-login. #33144

Comments

izarutskaya commented Dec 15, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Dec 15, 2023

melvin-bot bot commented Dec 15, 2023

melvin-bot bot commented Dec 15, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Dec 15, 2023

bernhardoj commented Dec 15, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

yh-0218 commented Dec 15, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot bot commented Dec 18, 2023

fedirjh commented Dec 18, 2023

fedirjh commented Dec 18, 2023

yh-0218 commented Dec 18, 2023

yh-0218 commented Dec 18, 2023

fedirjh commented Dec 18, 2023

bernhardoj commented Dec 19, 2023

yh-0218 commented Dec 19, 2023

melvin-bot bot commented Dec 22, 2023

melvin-bot bot commented Dec 22, 2023

NicMendonca commented Dec 22, 2023

melvin-bot bot commented Dec 26, 2023

melvin-bot bot commented Dec 28, 2023

melvin-bot bot commented Dec 29, 2023

melvin-bot bot commented Dec 29, 2023

fedirjh commented Dec 30, 2023

bernhardoj commented Dec 30, 2023

fedirjh commented Jan 2, 2024

melvin-bot bot commented Jan 2, 2024

fedirjh commented Jan 2, 2024

bernhardoj commented Jan 3, 2024

yh-0218 commented Jan 3, 2024

NicMendonca commented Jan 4, 2024

izarutskaya commented Dec 15, 2023 •

edited by melvin-bot bot

Loading

bernhardoj commented Dec 15, 2023 •

edited

Loading

yh-0218 commented Dec 15, 2023 •

edited

Loading