[HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [$500] Web - IOU – Unable to create IOU with non-existing user via 1:1 conversation

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.13-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Open staging.new.expensify.com
2. Navigate to FAB> Start Chat
3. Enter email address of non-existing user
4. Click on "+" button from created chat
5. Select Request money> Add amount and click Next

Expected Result:

Request button should be active and Money request should be created successfully with non-existing user just like creating IOU with non-existing user from FAB button

Actual Result:

Unable to create IOU with non-existing user via 1:1 conversation. Request button is inactive

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6314381_1702638196788.Recording__1568.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010d40f7ed4256dace
• Upwork Job ID: 1735619257477193728
• Last Price Increase: 2023-12-15
• Automatic offers:
• paultsimura | Contributor | 28062298

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010d40f7ed4256dace

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Julesssss]

Likely caused by fixes for the big refactor PR...

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unable to create an IOU with a hidden user.

What is the root cause of that problem?

We are filtering out the hidden participants (who have no login but have an accountID) when building a list of participants of the IOR Request:

App/src/pages/iou/request/step/IOURequestStepConfirmation.js

Lines 81 to 91 in fd71747

	const participants = useMemo(
	() =>
	_.chain(transaction.participants)
	.map((participant) => {
	const isPolicyExpenseChat = lodashGet(participant, 'isPolicyExpenseChat', false);
	return isPolicyExpenseChat ? OptionsListUtils.getPolicyExpenseReportOption(participant) : OptionsListUtils.getParticipantsOption(participant, personalDetails);
	})
	.filter((participant) => !!participant.login || !!participant.text)
	.value(),
	[transaction.participants, personalDetails],
	);

And this is what the participants list of the transaction looks like for a hidden participant:

[
    {
        "accountID": 3680713,
        "selected": true
    }
]

What changes do you think we should make in order to solve the problem?

We should not filter out accounts that have an accountID set here:

.filter((participant) => !!participant.login || !!participant.accountID || !!participant.text)

What alternative solutions did you explore? (Optional)

[Julesssss]

Replacing C+ as this is urgent

[allroundexperts]

@paultsimura's proposal looks good to me. Simple fix.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @Julesssss is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[Julesssss]

Thank you.

[melvin-bot]

📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.13-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: Retain hidden participants when creating an IOU request #33156

If no regressions arise, payment will be issued on 2023-12-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @paultsimura requires payment automatic offer (Contributor)
• @allroundexperts requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: Retain hidden participants when creating an IOU request #33156

If no regressions arise, payment will be issued on 2023-12-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @paultsimura requires payment automatic offer (Contributor)
• @allroundexperts requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR: Refactor the money request creation flow #28618
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/28618/files#r1440647938
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/356629

[joekaufmanexpensify]

Per this, payment may be delayed a few days here because of the holidays. @allroundexperts if you have time over the next week to handle the BZ checklist too, that'd be great!

[melvin-bot]

@Julesssss, @paultsimura, @allroundexperts, @joekaufmanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@Julesssss, @paultsimura, @allroundexperts, @joekaufmanexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[joekaufmanexpensify]

@allroundexperts could you please complete the checklist so we can issue payment?

[melvin-bot]

@Julesssss, @paultsimura, @allroundexperts, @joekaufmanexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[joekaufmanexpensify]

Bumped in Slack

[joekaufmanexpensify]

Still discussing in Slack

[paultsimura]

Does the BZ usually affect the Contributor payout as well?

[joekaufmanexpensify]

Yep! As soon as the BZ checklist is complete, we'll issue payment to everyone.

[allroundexperts]

Checklist

1. Refactor the money request creation flow #28618
2. https://github.com/Expensify/App/pull/28618/files#r1440647938
3. N/A
4. A regression test would be helpful.

Regression test

1. Open the app and navigate to FAB -> Start Chat
2. Enter email address of non-existing user
3. Click on "+" button from created chat
4. Select Request money -> Add amount and click Next
5. Verify that request button should be active and money request should be created successfully with non-existing user just like creating IOU with non-existing user from FAB button.

Do we 👍 or 👎 ?

[joekaufmanexpensify]

Added regression test above. Checklist is complete. All set to issue payment.

[joekaufmanexpensify]

We need to make the following payments:

• @paultsimura - $500 for PR. Paid via Upwork.
• @allroundexperts - $500 for C+ review. Paid via NewDot.

[joekaufmanexpensify]

@paultsimura $500 sent and contract ended!

[joekaufmanexpensify]

@allroundexperts could you please request $500 and confirm here once you've done that?

[joekaufmanexpensify]

Chatted with @allroundexperts and confirmed good to close.

[JmillsExpensify]

$500 payment to @allroundexperts based on this comment.