[HOLD for payment 2024-01-17] [$500] Wallet - Extra top padding on each field in Additional details page

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.13-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Navigate to https://staging.new.expensify.com/enable-payments

Expected Result:

Each field is spaced adequately.

Actual Result:

Each field has excess top padding, making each field look wide apart from one another.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013a9a9a0a9a660619
• Upwork Job ID: 1735630071530536960
• Last Price Increase: 2023-12-15
• Automatic offers:
• jjcoffee | Contributor | 28062309

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013a9a9a0a9a660619

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[namhihi237]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Extra top padding on each field in Additional details page

What is the root cause of that problem?

Currently we have a margin-top: 16px each fileds

containerStyles={[styles.mt4]}

App/src/pages/EnablePayments/AdditionalDetailsStep.js

Line 224 in 173582f

containerStyles={[styles.mt4]}

What changes do you think we should make in order to solve the problem?

we should remove margin-top

containerStyles={[styles.mt4]} // remove 

Or we can update to mt-2

What alternative solutions did you explore? (Optional)

N/A

[FitseTLT]

But why is it not reproducible in production @namhihi237? Because the line of code you're referring to is an old one. 😕

[GItGudRatio]

Proposal

I'm available for fixing this issue immediately.

Please re-state the problem that we are trying to solve in this issue.

Wallet - Extra top padding on each field in Additional details page

What is the root cause of that problem?

This is a regression from #24620.

The addition of this line here is causing the issue:
4068e30#diff-a97b40d6cf9952955d364e70010b61de4d91a39d1281c4e39f2178e24b9deff9R264

What changes do you think we should make in order to solve the problem?

Remove this line to fix the issue.

After Fix:

2023-12-15.17-44-30.mp4

[melvin-bot]

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

I think this is minor issue so it does not have to be a blocker, but also I think that should be handled with the PR authors @perunt @allroundexperts @jjcoffee

[mountiny]

Bumped in slack

[perunt]

I made a PR for that. It's a duplication of the style's name. I don't know why it wasn't a thing on merge conflicts.

[stephanieelliott]

Hey @perunt @allroundexperts @jjcoffee is there a PR for this? I don't see one linked.

[perunt]

@stephanieelliott, here's the PR that resolved the issue: #33221

[stephanieelliott]

All reviews completed, PR is undergoing QA

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.23-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Rename style container for the TextInput #33221

If no regressions arise, payment will be issued on 2024-01-17. 🎊

For reference, here are some details about the assignees on this issue:

• @jjcoffee requires payment automatic offer (Contributor)
• @allroundexperts requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jjcoffee / @allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@jjcoffee / @allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jjcoffee / @allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jjcoffee / @allroundexperts] Determine if we should create a regression test for this bug.
• [@jjcoffee / @allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @allroundexperts owed $500 via NewDot

BugZero Checklist (@stephanieelliott)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1735630071530536960/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[stephanieelliott]

This is a followup PR to resolve a regression from a PR that the contributor/C+ reviewed, so no payment is due here! Payment will be handled on the original issue.