Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Member - The search bar is not cleared after going to the new member invitation page #33195

Closed
6 tasks done
lanitochka17 opened this issue Dec 15, 2023 · 9 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Dec 15, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.13-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Open New Expensify app
  2. Navigate to the settings of the existing WS
  3. Navigate to "Members"
  4. In the search bar, type any email account
  5. Tap on "Invite"

Expected Result:

After navigating to the new member invitation page, the search bar should clear from the data entered on the members page

Actual Result:

After going to the page of inviting new members, the search bar is not cleared from the data entered on the members page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6304889_1701979699566.RPReplay_Final1701971603.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 15, 2023
Copy link

melvin-bot bot commented Dec 15, 2023

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 15, 2023
Copy link

melvin-bot bot commented Dec 15, 2023

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Dec 15, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link

melvin-bot bot commented Dec 15, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

@abzokhattab
Copy link
Contributor

abzokhattab commented Dec 15, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

The search bar is not cleared after going to the new member invitation page

What is the root cause of that problem?

This behavior is caused by this issue #22534 where the initial value for the input search is fetched from the previous page here:

useEffect(() => {
if (!SearchInputManager.searchInput) {
return;
}
setSearchTerm(SearchInputManager.searchInput);
}, []);

What changes do you think we should make in order to solve the problem?

remove this useEffect solves the issue

@bernhardoj
Copy link
Contributor

Based on this comment, it is intentional.

Maybe we need to update the testrail and remove this search value clearing code that was used before?

const inviteUser = () => {
setSearchValue('');
Navigation.navigate(ROUTES.WORKSPACE_INVITE.getRoute(props.route.params.policyID));
};

@hoangzinh
Copy link
Contributor

agree with @bernhardoj. It looks like intentional cc @isabelastisser

@melvin-bot melvin-bot bot added the Overdue label Dec 20, 2023
@hoangzinh
Copy link
Contributor

cc @isabelastisser

@melvin-bot melvin-bot bot removed the Overdue label Dec 20, 2023
@isabelastisser
Copy link
Contributor

Thanks for the insight, closing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

5 participants