Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Workspace -Assign Task-Random employee can edit/reassign task #33241

Closed
5 of 6 tasks
izarutskaya opened this issue Dec 18, 2023 · 24 comments
Closed
5 of 6 tasks

[$500] Workspace -Assign Task-Random employee can edit/reassign task #33241

izarutskaya opened this issue Dec 18, 2023 · 24 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@izarutskaya
Copy link

izarutskaya commented Dec 18, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v1.4.12-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation: @

Action Performed:

Precondition: Prepare 3 accounts:
A workspace admin
A workspace employee A (task creator)
A workspace employee B
Add all accounts to the workspace of the workspace admin
Should be executed after C2661791

  1. Log in to a Staging.new.expensify.com
  2. Navigate to the workspace #Announce room
  3. Click on the task created by the workspace employee A
  4. Edit the title of the task
  5. Reassign the task
  6. Edit the description of the task

Expected Result:

Employees who are non creators nor assigned should Not have permission to edit and reassign tasks created by other employees of the workspace.

Actual Result:

Employees who are non creators nor assigned should Have permission to edit and reassign tasks created by other employees of the workspace.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6315478_1702687645645.bugWork.mp4

Bug6315478_1702687645640!pas29-3

Bug6315478_1702687645632!pas29-1

Bug6315478_1702687645626!pas29-2

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a704827129d85780
  • Upwork Job ID: 1736774593975758848
  • Last Price Increase: 2024-01-15
@izarutskaya izarutskaya added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 18, 2023
@melvin-bot melvin-bot bot changed the title Workspace -Assign Task-Random employee can edit/reassign task [$500] Workspace -Assign Task-Random employee can edit/reassign task Dec 18, 2023
Copy link

melvin-bot bot commented Dec 18, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01a704827129d85780

Copy link

melvin-bot bot commented Dec 18, 2023

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 18, 2023
Copy link

melvin-bot bot commented Dec 18, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link

melvin-bot bot commented Dec 18, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

@karimiBadr
Copy link

@allroundexperts
I believe this issue has already been fixed.
#32165

@melvin-bot melvin-bot bot added the Overdue label Dec 21, 2023
Copy link

melvin-bot bot commented Dec 22, 2023

@michaelhaxhiu, @allroundexperts Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Dec 25, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Dec 26, 2023

@michaelhaxhiu, @allroundexperts 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Copy link

melvin-bot bot commented Dec 28, 2023

@michaelhaxhiu, @allroundexperts 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

Copy link

melvin-bot bot commented Jan 1, 2024

@michaelhaxhiu @allroundexperts this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Jan 1, 2024

@michaelhaxhiu, @allroundexperts 12 days overdue. Walking. Toward. The. Light...

Copy link

melvin-bot bot commented Jan 1, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Jan 1, 2024

@michaelhaxhiu @allroundexperts this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@melvin-bot melvin-bot bot removed the Daily KSv2 label Jan 3, 2024
Copy link

melvin-bot bot commented Jan 3, 2024

This issue has not been updated in over 14 days. @michaelhaxhiu, @allroundexperts eroding to Weekly issue.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Overdue labels Jan 3, 2024
Copy link

melvin-bot bot commented Jan 8, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Jan 8, 2024

@michaelhaxhiu @allroundexperts this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@melvin-bot melvin-bot bot added Engineering and removed Weekly KSv2 labels Jan 8, 2024
Copy link

melvin-bot bot commented Jan 11, 2024

@michaelhaxhiu, @allroundexperts Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Jan 15, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Jan 15, 2024

@michaelhaxhiu @allroundexperts this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

  • Decide whether any proposals currently meet our guidelines and can be approved as-is today
  • If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

@melvin-bot melvin-bot bot added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Jan 15, 2024
Copy link

melvin-bot bot commented Jan 15, 2024

Current assignee @allroundexperts is eligible for the Internal assigner, not assigning anyone new.

Copy link

melvin-bot bot commented Jan 15, 2024

@michaelhaxhiu, @allroundexperts Still overdue 6 days?! Let's take care of this!

Copy link

melvin-bot bot commented Jan 17, 2024

@michaelhaxhiu, @allroundexperts Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@michaelhaxhiu
Copy link
Contributor

no longer reproducible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

5 participants