Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-01-03] Task - Assignee list opens after some delay #33282

Closed
5 of 6 tasks
kbecciv opened this issue Dec 19, 2023 · 17 comments
Closed
5 of 6 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Dec 19, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v1.4.14-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to 1:1 DM.
  2. Click + > Assign task.
  3. Create a task with no assignee.
  4. Open task report.
  5. Click Assignee.

Expected Result:

Assignee list opens without delay.

Actual Result:

Assignee list opens after some delay.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6319454_1702985304748.20231219_154147__1_.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Dec 19, 2023
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Dec 19, 2023

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@pecanoro
Copy link
Contributor

It seems to be working just fine for me

@pecanoro
Copy link
Contributor

hmm, maybe there is a super small delay now that you mentioned

@pecanoro
Copy link
Contributor

Either way, not a deploy blocker since functionality is still intact, it's just a one second delay (but we should still fix it if something is broken).

@pecanoro pecanoro added Bug Something is broken. Auto assigns a BugZero manager. and removed DeployBlockerCash This issue or pull request should block deployment labels Dec 19, 2023
Copy link

melvin-bot bot commented Dec 19, 2023

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Dec 19, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@pecanoro
Copy link
Contributor

Ohh the delay is much worse in my expensify account comparing to my expensifail one

@pecanoro pecanoro added the DeployBlockerCash This issue or pull request should block deployment label Dec 19, 2023
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@pecanoro
Copy link
Contributor

Bringing back the label for the blocker until I identify where the problem is coming from

@pecanoro
Copy link
Contributor

I think I found the PR that caused it but I would need to test it: #32962

@s77rt
Copy link
Contributor

s77rt commented Dec 19, 2023

@TMisiukiewicz This effect https://github.com/callstack-internal/Expensify-App/blob/aa1d87caddb6831061f3750bd78f77b42603e5e3/src/pages/tasks/TaskAssigneeSelectorModal.js#L121-L123 run more than it should (3 instead of 1) due to the dependency on updateOptions. The PR is reverted so let's not remove the debounce function on this page (or prevent the effect from running this many times)

@pecanoro
Copy link
Contributor

PR was reverted so we can close this one.

TMisiukiewicz added a commit to callstack-internal/Expensify-App that referenced this issue Dec 20, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Hourly KSv2 labels Dec 20, 2023
@melvin-bot melvin-bot bot added the Weekly KSv2 label Dec 20, 2023
Copy link

melvin-bot bot commented Dec 26, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 27, 2023
@melvin-bot melvin-bot bot changed the title Task - Assignee list opens after some delay [HOLD for payment 2024-01-03] Task - Assignee list opens after some delay Dec 27, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 27, 2023
Copy link

melvin-bot bot commented Dec 27, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 27, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.17-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

Copy link

melvin-bot bot commented Dec 27, 2023

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@pecanoro] The PR that introduced the bug has been identified. Link to the PR:
  • [@pecanoro] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@pecanoro] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@pecanoro] Determine if we should create a regression test for this bug.
  • [@pecanoro] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants