[HOLD for payment 2024-01-17] [$500] Web - Profile - Legal name not saved/no validation if language specific characters used

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.1.14.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Log in New Expensify with any account
2. Navigate to Settings > Profile > Personal details > Legal name
3. Enter first and last names which contain language specific characters e. g., "Stanisław" and "Kamiński"
4. Click on Save

Expected Result:

Either the Legal name should be saved or a validation error informing that such characters are not supported should be shown.

Actual Result:

User is redirected back to Personal details page, and the Legal name is briefly shown but disappears, no validation errors.
The same characters are correctly saved and rendered if used in Display name.
Reproduced with Polish, Turkish, Slovak characters.
Example names to reproduce:
Polish: Stanisław, Rafał, Kamiński.
Turkish: Çağrı, Şimal.
Slovak: Matúš, Mikuláš

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6319768_1702997482216.2023-12-19_15-48-31.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0129b368859e3458c1
• Upwork Job ID: 1739984270624288768
• Last Price Increase: 2023-12-27
• Automatic offers:
• situchan | Reviewer | 28070802
• sourcecodedeveloper | Contributor | 28070803

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018f46e881dc753267

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[ZhenjaHorbach]

I think this should be fixed on the BE side

[dicong-zhao]

The API request for Updating Legal Name is https://www.expensify.com/api?command=UpdateLegalName(POST method)
This is the payload ( https://prnt.sc/yCmHYb3m-Bys)
As we see, payload is correct. but if we see the response, it doesn't return the legalFirstname and legalLastName ( https://prnt.sc/e1JVZW0AyvVb)
So I think this issue is related on the Backend side.

[melvin-bot]

📣 @steve-zhao0903! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[dicong-zhao]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~0148c62c1a4c8e3182

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[kmwamasali]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Profile - Legal name not saved/no validation if language specific

What is the root cause of that problem?

The validation check for the legal name only passes if the characters are in latin text

App/src/pages/settings/Profile/PersonalDetails/LegalNamePage.js

Line 58 in 91c7d0c

if (!ValidationUtils.isValidLegalName(values.legalFirstName)) {

What changes do you think we should make in order to solve the problem?

Add more language validations to the regex that tests the name validity

https://github.com/Expensify/App/blob/91c7d0c6a9c8c418ae0273dfb4c49f7de52ca2c1/src/libs/ValidationUtils.ts#L320C24-L320C24

[narefyev91]

Proposal from @Sourcecodedeveloper looks good to me #33294 (comment)
We already have FE logic to validate characters - let's adjust it
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @luacmartins, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[narefyev91]

@narefyev91 Thanks. I understand I need to wait to get assigned to the issue before preparing PR.

Yup we need final review from @luacmartins

[luacmartins]

all yours @Sourcecodedeveloper

[melvin-bot]

📣 @Sourcecodedeveloper 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[situchan]

@Sourcecodedeveloper nvm, not affect your payment

[situchan]

@Sourcecodedeveloper I will be reviewing https://github.com/Expensify/App/pull/33563. Ignore Melvin's comment

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0129b368859e3458c1

[melvin-bot]

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @Sourcecodedeveloper 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[sakluger]

Hmm, that actually made things a bit confusing, now each contributor has been sent two Upwork offers. No worries - since the original offers are for the correct amounts and since they have been accepted, we can use those (even though they both say "contributor", it's okay as long as we are paying the correct amounts). I'm going to withdraw the new offers to keep things simple.

Here are the offers we will be paying out once the PR is deployed:

• Contributor+: @situchan - https://www.upwork.com/nx/wm/offer/28069800
• Contributor: @Sourcecodedeveloper - https://www.upwork.com/nx/wm/offer/28066013

[sakluger]

@Sourcecodedeveloper - The amounts are the same for both roles, so it's okay if the role in the Upwork job title is incorrect, as long as everyone gets paid the correct amount. Since the original offers have already been accepted, I am going to use those offers when we need to pay out.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.23-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/33563

If no regressions arise, payment will be issued on 2024-01-17. 🎊

For reference, here are some details about the assignees on this issue:

• @situchan requires payment automatic offer (Reviewer)
• @Sourcecodedeveloper requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sakluger]

Thanks everyone, I paid out both offers via Upwork.

@situchan could you please complete the BZ checklist? Thanks!

[situchan]

No PR caused regression. We can skip regression test as caught by QA team.

[sakluger]

Sounds good, thanks!