Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Web - Chat-Mouse scroll and slide functions reversely if pressed on mouse wheel #33299

Closed
1 of 6 tasks
kbecciv opened this issue Dec 19, 2023 · 23 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@kbecciv
Copy link

kbecciv commented Dec 19, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.14.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Login to ND Expensify
  2. Navigate to a chat that has a lot of messages in the conversation history
  3. Scroll to the top of the conversation via scroll bar
  4. Press on the mouse wheel and try to slide down to the bottom of the conversation
  5. Slide to the bottom of the conversation
  6. Press on the mouse wheel and try to slide up to the top of the conversation

Expected Result:

While pressing on the mouse wheel, sliding should be harmonious with the scroll bar

Actual Result:

While pressing on the mouse wheel, if user tries to slide down or up, sliding functions reversely. Mouse cursor works opposite with the scroll bar.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6319865_1703001796494.2023-12-19_15-15-30.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ece60315a26cd5ed
  • Upwork Job ID: 1737142924592078848
  • Last Price Increase: 2024-01-02
  • Automatic offers:
    • situchan | Contributor | 28077572
@kbecciv kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 19, 2023
@melvin-bot melvin-bot bot changed the title Web - Chat-Mouse scroll and slide functions reversely if pressed on mouse wheel [$500] Web - Chat-Mouse scroll and slide functions reversely if pressed on mouse wheel Dec 19, 2023
Copy link

melvin-bot bot commented Dec 19, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01ece60315a26cd5ed

Copy link

melvin-bot bot commented Dec 19, 2023

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Dec 19, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 19, 2023
Copy link

melvin-bot bot commented Dec 19, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

@yh-0218
Copy link
Contributor

yh-0218 commented Dec 19, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Chat-Mouse scroll and slide functions reversely if pressed on mouse wheel

What is the root cause of that problem?

Mouse wheel direction is reversed.

What changes do you think we should make in order to solve the problem?

We can custom mouse wheel direction.

export function useHorizontalScroll() {
  const elRef = useRef();
  useEffect(() => {
    const el = elRef.current;
    if (el) {
      const onWheel = e => {
        if (e.deltaY == 0) return;
        e.preventDefault();
        el.scrollTo({
          left: el.scrollLeft + e.deltaY,
          behavior: "smooth"
        });
      };
      el.addEventListener("wheel", onWheel);
      return () => el.removeEventListener("wheel", onWheel);
    }
  }, []);
  return elRef;
}

What alternative solutions did you explore? (Optional)

@KevinBlakeLopez
Copy link

KevinBlakeLopez commented Dec 20, 2023

I am considering presenting a proposal in the near future, and I want to verify if this is an issue worth fixing or not or whether it would be included in a wave latter on or if it will be paid out if we are able to present a solution. Is this issue a priority for you guys and will you pay out for it if a solution is presented?

Copy link

melvin-bot bot commented Dec 20, 2023

📣 @KevinBlakeLopez! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@KevinBlakeLopez
Copy link

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01a4b93f700f1a3a06?viewMode=1

Copy link

melvin-bot bot commented Dec 20, 2023

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@cartersteinhoff
Copy link

cartersteinhoff commented Dec 21, 2023

@thesahindia Hi, I'm also interested in presenting a proposal. Is this issue available to take on?

@melvin-bot melvin-bot bot added the Overdue label Dec 21, 2023
@NicMendonca
Copy link
Contributor

@thesahindia a proposal for you here!

@melvin-bot melvin-bot bot removed the Overdue label Dec 22, 2023
@thesahindia
Copy link
Member

I won't be able to take this. Please reassign.

@thesahindia thesahindia removed their assignment Dec 22, 2023
@situchan
Copy link
Contributor

@NicMendonca I can take over

@melvin-bot melvin-bot bot added the Overdue label Dec 25, 2023
Copy link

melvin-bot bot commented Dec 26, 2023

@NicMendonca Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Dec 26, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Dec 28, 2023

@NicMendonca Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Jan 1, 2024

@NicMendonca 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

1 similar comment
Copy link

melvin-bot bot commented Jan 1, 2024

@NicMendonca 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

Copy link

melvin-bot bot commented Jan 2, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Jan 2, 2024

@NicMendonca this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 2, 2024
Copy link

melvin-bot bot commented Jan 2, 2024

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@melvin-bot melvin-bot bot removed the Overdue label Jan 2, 2024
@NicMendonca
Copy link
Contributor

@situchan sorry - just saw this now! assigned you

@melvin-bot melvin-bot bot added the Overdue label Jan 4, 2024
@NicMendonca
Copy link
Contributor

I am going to close this as per this update - https://expensify.slack.com/archives/C01GTK53T8Q/p1702496349813859

This isn't directly related to a roadmap issue

@melvin-bot melvin-bot bot removed the Overdue label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

7 participants